Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in kobject_set_name_vargs
BUG: memory leak
unreferenced object 0xffff88812b283d40 (size 32):
comm "kworker/1:7", pid 9710, jiffies 4294944644 (age 14.810s)
hex dump (first 32 bytes):
75 73 62 2d 30 30 31 3a 30 30 32 00 00 00 00 00 usb-001:002.....
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff81484516>] kstrdup+0x36/0x70 mm/util.c:60
[<ffffffff814845a3>] kstrdup_const+0x53/0x80 mm/util.c:83
[<ffffffff82297212>] kvasprintf_const+0xc2/0x110 lib/kasprintf.c:48
[<ffffffff823593bb>] kobject_set_name_vargs+0x3b/0xe0 lib/kobject.c:289
[<ffffffff82657c63>] dev_set_name+0x63/0x90 drivers/base/core.c:3147
[<ffffffff828dddbb>] __mdiobus_register+0xbb/0x450 drivers/net/phy/mdio_bus.c:535
[<ffffffff828cbfb5>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
[<ffffffff82b93230>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
[<ffffffff82b93230>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
[<ffffffff82baab6f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
[<ffffffff82c37637>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<ffffffff82662387>] call_driver_probe drivers/base/dd.c:517 [inline]
[<ffffffff82662387>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
[<ffffffff8266272c>] really_probe drivers/base/dd.c:558 [inline]
[<ffffffff8266272c>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
[<ffffffff8266282a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
[<ffffffff82663096>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
[<ffffffff8265f317>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
[<ffffffff82662c12>] __device_attach+0x122/0x260 drivers/base/dd.c:969
BUG: memory leak
unreferenced object 0xffff88812b3f3100 (size 256):
comm "kworker/1:7", pid 9710, jiffies 4294944644 (age 14.810s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 08 31 3f 2b 81 88 ff ff .........1?+....
08 31 3f 2b 81 88 ff ff 00 7d 65 82 ff ff ff ff .1?+.....}e.....
backtrace:
[<ffffffff8265d61b>] kmalloc include/linux/slab.h:591 [inline]
[<ffffffff8265d61b>] kzalloc include/linux/slab.h:721 [inline]
[<ffffffff8265d61b>] device_private_init drivers/base/core.c:3203 [inline]
[<ffffffff8265d61b>] device_add+0x89b/0xdf0 drivers/base/core.c:3253
[<ffffffff828dddc3>] __mdiobus_register+0xc3/0x450 drivers/net/phy/mdio_bus.c:537
[<ffffffff828cbfb5>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
[<ffffffff82b93230>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
[<ffffffff82b93230>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
[<ffffffff82baab6f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
[<ffffffff82c37637>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<ffffffff82662387>] call_driver_probe drivers/base/dd.c:517 [inline]
[<ffffffff82662387>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
[<ffffffff8266272c>] really_probe drivers/base/dd.c:558 [inline]
[<ffffffff8266272c>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
[<ffffffff8266282a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
[<ffffffff82663096>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
[<ffffffff8265f317>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
[<ffffffff82662c12>] __device_attach+0x122/0x260 drivers/base/dd.c:969
[<ffffffff82660f86>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:487
[<ffffffff8265d37b>] device_add+0x5fb/0xdf0 drivers/base/core.c:3359
[<ffffffff82c34bd9>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2170
[<ffffffff82c44f5c>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
BUG: memory leak
unreferenced object 0xffff88812c36f2c0 (size 32):
comm "kworker/0:0", pid 5, jiffies 4294944704 (age 14.210s)
hex dump (first 32 bytes):
75 73 62 2d 30 30 38 3a 30 30 32 00 00 00 00 00 usb-008:002.....
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff81484516>] kstrdup+0x36/0x70 mm/util.c:60
[<ffffffff814845a3>] kstrdup_const+0x53/0x80 mm/util.c:83
[<ffffffff82297212>] kvasprintf_const+0xc2/0x110 lib/kasprintf.c:48
[<ffffffff823593bb>] kobject_set_name_vargs+0x3b/0xe0 lib/kobject.c:289
[<ffffffff82657c63>] dev_set_name+0x63/0x90 drivers/base/core.c:3147
[<ffffffff828dddbb>] __mdiobus_register+0xbb/0x450 drivers/net/phy/mdio_bus.c:535
[<ffffffff828cbfb5>] __devm_mdiobus_register+0x75/0xf0 drivers/net/phy/mdio_devres.c:87
[<ffffffff82b93230>] ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline]
[<ffffffff82b93230>] ax88772_bind+0x330/0x480 drivers/net/usb/asix_devices.c:786
[<ffffffff82baab6f>] usbnet_probe+0x3ff/0xdf0 drivers/net/usb/usbnet.c:1745
[<ffffffff82c37637>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<ffffffff82662387>] call_driver_probe drivers/base/dd.c:517 [inline]
[<ffffffff82662387>] really_probe.part.0+0xe7/0x380 drivers/base/dd.c:596
[<ffffffff8266272c>] really_probe drivers/base/dd.c:558 [inline]
[<ffffffff8266272c>] __driver_probe_device+0x10c/0x1e0 drivers/base/dd.c:751
[<ffffffff8266282a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:781
[<ffffffff82663096>] __device_attach_driver+0xf6/0x140 drivers/base/dd.c:898
[<ffffffff8265f317>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:427
[<ffffffff82662c12>] __device_attach+0x122/0x260 drivers/base/dd.c:969
Tested on:
commit: 0513e464 Merge tag 'perf-tools-fixes-for-v5.15-2021-09..
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=13d62140b00000
patch:
https://syzkaller.appspot.com/x/patch.diff?x=15c8726b300000