Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in generic_make_request_checks
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device nullb0 (partno 0)
WARNING: CPU: 0 PID: 8195 at block/blk-core.c:852 bio_check_ro block/blk-core.c:852 [inline]
WARNING: CPU: 0 PID: 8195 at block/blk-core.c:852 generic_make_request_checks+0x1cb0/0x21c0 block/blk-core.c:988
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 8195 Comm: syz-executor.0 Not tainted 5.8.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x18f/0x20d lib/dump_stack.c:118
panic+0x2e3/0x75c kernel/panic.c:231
__warn.cold+0x20/0x45 kernel/panic.c:600
report_bug+0x1bd/0x210 lib/bug.c:198
handle_bug+0x38/0x90 arch/x86/kernel/traps.c:235
exc_invalid_op+0x13/0x40 arch/x86/kernel/traps.c:255
asm_exc_invalid_op+0x12/0x20 arch/x86/include/asm/idtentry.h:542
RIP: 0010:bio_check_ro block/blk-core.c:852 [inline]
RIP: 0010:generic_make_request_checks+0x1cb0/0x21c0 block/blk-core.c:988
Code: 1a 05 00 00 44 8b ab ac 05 00 00 48 8d 74 24 70 48 89 ef e8 92 0f fe ff 48 c7 c7 60 9a 91 88 48 89 c6 44 89 ea e8 c2 87 c2 fd <0f> 0b 48 b8 00 00 00 00 00 fc ff df 4c 89 e2 48 c1 ea 03 80 3c 02
RSP: 0018:ffffc90004927478 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff8880a12aa000 RCX: 0000000000000000
RDX: ffff8880932ea400 RSI: ffffffff815d4f87 RDI: fffff52000924e81
RBP: ffff8880a1d3fc00 R08: 0000000000000001 R09: ffff8880ae6318e7
R10: 0000000000000000 R11: 0000000000000000 R12: ffff8880a1d3fc08
R13: 0000000000000000 R14: 0000000000000001 R15: ffff8880a12a5080
generic_make_request+0x89/0xc00 block/blk-core.c:1112
submit_bio+0x263/0x5b0 block/blk-core.c:1275
submit_bh_wbc+0x68d/0x8e0 fs/buffer.c:3073
__block_write_full_page+0x837/0x12e0 fs/buffer.c:1811
block_write_full_page+0x214/0x270 fs/buffer.c:2997
__writepage+0x60/0x170 mm/page-writeback.c:2313
write_cache_pages+0x736/0x11b0 mm/page-writeback.c:2248
generic_writepages mm/page-writeback.c:2339 [inline]
generic_writepages+0xe2/0x150 mm/page-writeback.c:2328
do_writepages+0xec/0x290 mm/page-writeback.c:2354
__filemap_fdatawrite_range+0x2a1/0x380 mm/filemap.c:421
filemap_write_and_wait_range mm/filemap.c:654 [inline]
filemap_write_and_wait_range+0xe1/0x1c0 mm/filemap.c:648
filemap_write_and_wait include/linux/fs.h:2765 [inline]
__sync_blockdev fs/block_dev.c:490 [inline]
sync_blockdev fs/block_dev.c:499 [inline]
__blkdev_put+0x60b/0x8c0 fs/block_dev.c:1910
blkdev_close+0x8c/0xb0 fs/block_dev.c:1967
__fput+0x33c/0x880 fs/file_table.c:281
task_work_run+0xdd/0x190 kernel/task_work.c:135
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_usermode_loop arch/x86/entry/common.c:239 [inline]
__prepare_exit_to_usermode+0x1e9/0x1f0 arch/x86/entry/common.c:269
do_syscall_64+0x6c/0xe0 arch/x86/entry/common.c:393
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45cba9
Code: Bad RIP value.
RSP: 002b:00007f67cfe7fc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: 0000000020000000 RBX: 00000000004f6ea0 RCX: 000000000045cba9
RDX: 000000000200000e RSI: 0000000000e7e000 RDI: 0000000020000000
RBP: 000000000078bf00 R08: 0000000000000003 R09: 0000000000000000
R10: 0000000000000013 R11: 0000000000000246 R12: 00000000ffffffff
R13: 000000000000075e R14: 00000000004ca61f R15: 00007f67cfe806d4
Kernel Offset: disabled
Rebooting in 86400 seconds..
Tested on:
commit: 11ba4688 Linux 5.8-rc5
git tree: git://
git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git master
console output:
https://syzkaller.appspot.com/x/log.txt?x=1375a968900000
kernel config:
https://syzkaller.appspot.com/x/.config?x=5b77dd4385c2d488
patch:
https://syzkaller.appspot.com/x/patch.diff?x=17a85817100000