[syzbot] possible deadlock in loop_probe
32 views
Skip to first unread message
syzbot
Jun 16, 2021, 5:18:18 PM6/16/21
to ax...@fb.com, ax...@kernel.dk, gre...@linuxfoundation.org, h...@lst.de, kbu...@kernel.org, linux...@vger.kernel.org, linux-...@vger.kernel.org, linux...@lists.infradead.org, raf...@kernel.org, sa...@grimberg.me, syzkall...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 8ecfa36c Merge tag 'riscv-for-linus-5.13-rc6' of git://git..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17121304300000
kernel config: https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler: Debian clang version 11.0.1-2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17065d1fd00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12de53afd00000
The issue was bisected to:
commit 5befc7c26e5a98cd49789fb1beb52c62bd472dba
Author: Keith Busch <kbu...@kernel.org>
Date: Wed Mar 24 23:18:05 2021 +0000
nvme: implement non-mdts command limits
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15e62857d00000
final oops: https://syzkaller.appspot.com/x/report.txt?x=17e62857d00000
console output: https://syzkaller.appspot.com/x/log.txt?x=13e62857d00000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Fixes: 5befc7c26e5a ("nvme: implement non-mdts command limits")
======================================================
WARNING: possible circular locking dependency detected
5.13.0-rc5-syzkaller #0 Not tainted
------------------------------------------------------
systemd-udevd/8445 is trying to acquire lock:
ffffffff8d671688 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_probe+0xe1/0x220 drivers/block/loop.c:2234
but task is already holding lock:
ffffffff8d4db008 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x2f/0x1c0 block/genhd.c:680
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (major_names_lock){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
__register_blkdev+0x2c/0x360 block/genhd.c:223
register_mtd_blktrans+0x94/0x3d0 drivers/mtd/mtd_blkdevs.c:534
do_one_initcall+0x1a7/0x400 init/main.c:1249
do_initcall_level+0x14a/0x1f5 init/main.c:1322
do_initcalls+0x4b/0x8c init/main.c:1338
kernel_init_freeable+0x3fd/0x58a init/main.c:1560
kernel_init+0xd/0x290 init/main.c:1447
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
-> #2 (mtd_table_mutex){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
blktrans_open+0x61/0x430 drivers/mtd/mtd_blkdevs.c:212
__blkdev_get+0x293/0xa50 fs/block_dev.c:1311
blkdev_get_by_dev+0xf9/0x640 fs/block_dev.c:1451
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #1 (&bdev->bd_mutex){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
del_gendisk+0x2ab/0x860 block/genhd.c:610
loop_remove drivers/block/loop.c:2180 [inline]
loop_control_ioctl+0x62c/0x770 drivers/block/loop.c:2280
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:1069 [inline]
__se_sys_ioctl+0xfb/0x170 fs/ioctl.c:1055
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #0 (loop_ctl_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add+0x4f9/0x5b60 kernel/locking/lockdep.c:3061
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x4307/0x6040 kernel/locking/lockdep.c:4902
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
loop_probe+0xe1/0x220 drivers/block/loop.c:2234
blk_request_module+0x19d/0x1c0 block/genhd.c:683
blkdev_get_no_open+0x44/0x1f0 fs/block_dev.c:1374
blkdev_get_by_dev+0x82/0x640 fs/block_dev.c:1437
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
other info that might help us debug this:
Chain exists of:
loop_ctl_mutex --> mtd_table_mutex --> major_names_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(major_names_lock);
lock(mtd_table_mutex);
lock(major_names_lock);
lock(loop_ctl_mutex);
*** DEADLOCK ***
1 lock held by systemd-udevd/8445:
#0: ffffffff8d4db008 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x2f/0x1c0 block/genhd.c:680
stack backtrace:
CPU: 1 PID: 8445 Comm: systemd-udevd Not tainted 5.13.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x202/0x31e lib/dump_stack.c:120
print_circular_bug+0xb17/0xdc0 kernel/locking/lockdep.c:2007
check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2129
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add+0x4f9/0x5b60 kernel/locking/lockdep.c:3061
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x4307/0x6040 kernel/locking/lockdep.c:4902
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
loop_probe+0xe1/0x220 drivers/block/loop.c:2234
blk_request_module+0x19d/0x1c0 block/genhd.c:683
blkdev_get_no_open+0x44/0x1f0 fs/block_dev.c:1374
blkdev_get_by_dev+0x82/0x640 fs/block_dev.c:1437
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f666c06a840
Code: 73 01 c3 48 8b 0d 68 77 20 00 f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 83 3d 89 bb 20 00 00 75 10 b8 02 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 1e f6 ff ff 48 89 04 24
RSP: 002b:00007ffc880be598 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 000055dd2c8278f0 RCX: 00007f666c06a840
RDX: 000055dd2c52efe3 RSI: 00000000000a0800 RDI: 000055dd2c827830
RBP: 00007ffc880be710 R08: 000055dd2c52e670 R09: 0000000000000010
R10: 000055dd2c52ed0c R11: 0000000000000246 R12: 00007ffc880be660
R13: 000055dd2c829010 R14: 0000000000000003 R15: 000000000000000e
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches
syzbot found the following issue on:
HEAD commit: 8ecfa36c Merge tag 'riscv-for-linus-5.13-rc6' of git://git..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17121304300000
kernel config: https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler: Debian clang version 11.0.1-2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17065d1fd00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12de53afd00000
The issue was bisected to:
commit 5befc7c26e5a98cd49789fb1beb52c62bd472dba
Author: Keith Busch <kbu...@kernel.org>
Date: Wed Mar 24 23:18:05 2021 +0000
nvme: implement non-mdts command limits
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15e62857d00000
final oops: https://syzkaller.appspot.com/x/report.txt?x=17e62857d00000
console output: https://syzkaller.appspot.com/x/log.txt?x=13e62857d00000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Fixes: 5befc7c26e5a ("nvme: implement non-mdts command limits")
======================================================
WARNING: possible circular locking dependency detected
5.13.0-rc5-syzkaller #0 Not tainted
------------------------------------------------------
systemd-udevd/8445 is trying to acquire lock:
ffffffff8d671688 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_probe+0xe1/0x220 drivers/block/loop.c:2234
but task is already holding lock:
ffffffff8d4db008 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x2f/0x1c0 block/genhd.c:680
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (major_names_lock){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
__register_blkdev+0x2c/0x360 block/genhd.c:223
register_mtd_blktrans+0x94/0x3d0 drivers/mtd/mtd_blkdevs.c:534
do_one_initcall+0x1a7/0x400 init/main.c:1249
do_initcall_level+0x14a/0x1f5 init/main.c:1322
do_initcalls+0x4b/0x8c init/main.c:1338
kernel_init_freeable+0x3fd/0x58a init/main.c:1560
kernel_init+0xd/0x290 init/main.c:1447
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
-> #2 (mtd_table_mutex){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
blktrans_open+0x61/0x430 drivers/mtd/mtd_blkdevs.c:212
__blkdev_get+0x293/0xa50 fs/block_dev.c:1311
blkdev_get_by_dev+0xf9/0x640 fs/block_dev.c:1451
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #1 (&bdev->bd_mutex){+.+.}-{3:3}:
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
del_gendisk+0x2ab/0x860 block/genhd.c:610
loop_remove drivers/block/loop.c:2180 [inline]
loop_control_ioctl+0x62c/0x770 drivers/block/loop.c:2280
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:1069 [inline]
__se_sys_ioctl+0xfb/0x170 fs/ioctl.c:1055
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #0 (loop_ctl_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add+0x4f9/0x5b60 kernel/locking/lockdep.c:3061
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x4307/0x6040 kernel/locking/lockdep.c:4902
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
loop_probe+0xe1/0x220 drivers/block/loop.c:2234
blk_request_module+0x19d/0x1c0 block/genhd.c:683
blkdev_get_no_open+0x44/0x1f0 fs/block_dev.c:1374
blkdev_get_by_dev+0x82/0x640 fs/block_dev.c:1437
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
other info that might help us debug this:
Chain exists of:
loop_ctl_mutex --> mtd_table_mutex --> major_names_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(major_names_lock);
lock(mtd_table_mutex);
lock(major_names_lock);
lock(loop_ctl_mutex);
*** DEADLOCK ***
1 lock held by systemd-udevd/8445:
#0: ffffffff8d4db008 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x2f/0x1c0 block/genhd.c:680
stack backtrace:
CPU: 1 PID: 8445 Comm: systemd-udevd Not tainted 5.13.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x202/0x31e lib/dump_stack.c:120
print_circular_bug+0xb17/0xdc0 kernel/locking/lockdep.c:2007
check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2129
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add+0x4f9/0x5b60 kernel/locking/lockdep.c:3061
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x4307/0x6040 kernel/locking/lockdep.c:4902
lock_acquire+0x17f/0x720 kernel/locking/lockdep.c:5512
__mutex_lock_common+0x1bf/0x3100 kernel/locking/mutex.c:959
__mutex_lock kernel/locking/mutex.c:1104 [inline]
mutex_lock_nested+0x1a/0x20 kernel/locking/mutex.c:1119
loop_probe+0xe1/0x220 drivers/block/loop.c:2234
blk_request_module+0x19d/0x1c0 block/genhd.c:683
blkdev_get_no_open+0x44/0x1f0 fs/block_dev.c:1374
blkdev_get_by_dev+0x82/0x640 fs/block_dev.c:1437
blkdev_open+0x132/0x2c0 fs/block_dev.c:1546
do_dentry_open+0x7cb/0x1010 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x28e6/0x39b0 fs/namei.c:3494
do_filp_open+0x221/0x460 fs/namei.c:3521
do_sys_openat2+0x124/0x460 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1207
do_syscall_64+0x3f/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f666c06a840
Code: 73 01 c3 48 8b 0d 68 77 20 00 f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 83 3d 89 bb 20 00 00 75 10 b8 02 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 1e f6 ff ff 48 89 04 24
RSP: 002b:00007ffc880be598 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 000055dd2c8278f0 RCX: 00007f666c06a840
RDX: 000055dd2c52efe3 RSI: 00000000000a0800 RDI: 000055dd2c827830
RBP: 00007ffc880be710 R08: 000055dd2c52e670 R09: 0000000000000010
R10: 000055dd2c52ed0c R11: 0000000000000246 R12: 00007ffc880be660
R13: 000055dd2c829010 R14: 0000000000000003 R15: 000000000000000e
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches
Desmond Cheong Zhi Xi
Jun 16, 2021, 11:27:01 PM6/16/21
to syzbot+6a8a0d...@syzkaller.appspotmail.com, syzkall...@googlegroups.com
#syz test:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
Just a hypothesis.
Best,
Desmond
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
Just a hypothesis.
Best,
Desmond
syzbot
Jun 17, 2021, 2:03:07 AM6/17/21
to desmond...@gmail.com, syzkall...@googlegroups.com
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in loop_probe
======================================================
WARNING: possible circular locking dependency detected
5.13.0-rc6-syzkaller #0 Not tainted
------------------------------------------------------
systemd-udevd/10220 is trying to acquire lock:
ffffffff8c26dc68 (
loop_ctl_mutex){+.+.}-{3:3}, at: loop_probe+0xc7/0x150 drivers/block/loop.c:2234
but task is already holding lock:
ffffffff8bfe01e8 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x25/0x1d0 block/genhd.c:680
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (major_names_lock){+.+.}-{3:3}:
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
__register_blkdev+0x2b/0x3e0 block/genhd.c:223
register_mtd_blktrans+0x85/0x3c0 drivers/mtd/mtd_blkdevs.c:534
do_one_initcall+0x103/0x650 init/main.c:1249
do_initcall_level init/main.c:1322 [inline]
do_initcalls init/main.c:1338 [inline]
do_basic_setup init/main.c:1358 [inline]
kernel_init_freeable+0x6c4/0x74d init/main.c:1560
kernel_init+0xd/0x1b8 init/main.c:1447
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
blktrans_open+0x69/0x600 drivers/mtd/mtd_blkdevs.c:212
__blkdev_get+0x182/0xa30 fs/block_dev.c:1311
blkdev_get_by_dev fs/block_dev.c:1451 [inline]
blkdev_get_by_dev+0x200/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
del_gendisk+0x24b/0xa00 block/genhd.c:610
loop_remove drivers/block/loop.c:2180 [inline]
loop_control_ioctl drivers/block/loop.c:2280 [inline]
loop_control_ioctl+0x3e7/0x4c0 drivers/block/loop.c:2240
__x64_sys_ioctl+0x193/0x200 fs/ioctl.c:1055
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
loop_probe+0xc7/0x150 drivers/block/loop.c:2234
blk_request_module+0x111/0x1d0 block/genhd.c:683
blkdev_get_no_open+0x1d8/0x250 fs/block_dev.c:1374
blkdev_get_by_dev fs/block_dev.c:1437 [inline]
blkdev_get_by_dev+0x76/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
#0: ffffffff8bfe01e8 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x25/0x1d0 block/genhd.c:680
stack backtrace:
CPU: 0 PID: 10220 Comm: systemd-udevd Not tainted 5.13.0-rc6-syzkaller #0
check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2129
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add kernel/locking/lockdep.c:3061 [inline]
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
loop_probe+0xc7/0x150 drivers/block/loop.c:2234
blk_request_module+0x111/0x1d0 block/genhd.c:683
blkdev_get_no_open+0x1d8/0x250 fs/block_dev.c:1374
blkdev_get_by_dev fs/block_dev.c:1437 [inline]
blkdev_get_by_dev+0x76/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f22c440a840
RAX: ffffffffffffffda RBX: 0000558e425f5640 RCX: 00007f22c440a840
RDX: 0000558e42281fe3 RSI: 00000000000a0800 RDI: 0000558e42606fb0
RBP: 00007ffeed68a780 R08: 0000558e42281670 R09: 0000000000000010
R10: 00007f22c4184d70 R11: 0000000000000246 R12: 00007ffeed68a6d0
R13: 0000558e425f9540 R14: 0000000000000003 R15: 000000000000000e
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13d2d4a4300000
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
patch: https://syzkaller.appspot.com/x/patch.diff?x=140ce284300000
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in loop_probe
======================================================
WARNING: possible circular locking dependency detected
------------------------------------------------------
systemd-udevd/10220 is trying to acquire lock:
ffffffff8c26dc68 (
loop_ctl_mutex){+.+.}-{3:3}, at: loop_probe+0xc7/0x150 drivers/block/loop.c:2234
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (major_names_lock){+.+.}-{3:3}:
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
__register_blkdev+0x2b/0x3e0 block/genhd.c:223
register_mtd_blktrans+0x85/0x3c0 drivers/mtd/mtd_blkdevs.c:534
do_one_initcall+0x103/0x650 init/main.c:1249
do_initcall_level init/main.c:1322 [inline]
do_initcalls init/main.c:1338 [inline]
do_basic_setup init/main.c:1358 [inline]
kernel_init_freeable+0x6c4/0x74d init/main.c:1560
kernel_init+0xd/0x1b8 init/main.c:1447
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
-> #2 (mtd_table_mutex){+.+.}-{3:3}:
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
-> #2 (mtd_table_mutex){+.+.}-{3:3}:
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
blktrans_open+0x69/0x600 drivers/mtd/mtd_blkdevs.c:212
__blkdev_get+0x182/0xa30 fs/block_dev.c:1311
blkdev_get_by_dev fs/block_dev.c:1451 [inline]
blkdev_get_by_dev+0x200/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x119/0x1c0 fs/open.c:1207
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #1 (&bdev->bd_mutex
){+.+.}-{3:3}:
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
-> #1 (&bdev->bd_mutex
){+.+.}-{3:3}:
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
del_gendisk+0x24b/0xa00 block/genhd.c:610
loop_remove drivers/block/loop.c:2180 [inline]
loop_control_ioctl drivers/block/loop.c:2280 [inline]
loop_control_ioctl+0x3e7/0x4c0 drivers/block/loop.c:2240
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:1069 [inline]
__se_sys_ioctl fs/ioctl.c:1055 [inline]
__do_sys_ioctl fs/ioctl.c:1069 [inline]
__x64_sys_ioctl+0x193/0x200 fs/ioctl.c:1055
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
-> #0
(loop_ctl_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add kernel/locking/lockdep.c:3061 [inline]
-> #0
(loop_ctl_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:2938 [inline]
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
loop_probe+0xc7/0x150 drivers/block/loop.c:2234
blk_request_module+0x111/0x1d0 block/genhd.c:683
blkdev_get_no_open+0x1d8/0x250 fs/block_dev.c:1374
blkdev_get_by_dev fs/block_dev.c:1437 [inline]
blkdev_get_by_dev+0x76/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x119/0x1c0 fs/open.c:1207
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
other info that might help us debug this:
Chain exists of:
loop_ctl_mutex --> mtd_table_mutex --> major_names_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(major_names_lock);
lock(mtd_table_mutex);
lock(major_names_lock);
lock(loop_ctl_mutex);
*** DEADLOCK ***
1 lock held by systemd-udevd/10220:
other info that might help us debug this:
Chain exists of:
loop_ctl_mutex --> mtd_table_mutex --> major_names_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(major_names_lock);
lock(mtd_table_mutex);
lock(major_names_lock);
lock(loop_ctl_mutex);
*** DEADLOCK ***
#0: ffffffff8bfe01e8 (major_names_lock){+.+.}-{3:3}, at: blk_request_module+0x25/0x1d0 block/genhd.c:680
stack backtrace:
CPU: 0 PID: 10220 Comm: systemd-udevd Not tainted 5.13.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x141/0x1d7 lib/dump_stack.c:120
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2129
check_prev_add kernel/locking/lockdep.c:2938 [inline]
check_prevs_add kernel/locking/lockdep.c:3061 [inline]
validate_chain kernel/locking/lockdep.c:3676 [inline]
__lock_acquire+0x2a17/0x5230 kernel/locking/lockdep.c:4902
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x1ab/0x740 kernel/locking/lockdep.c:5477
__mutex_lock_common kernel/locking/mutex.c:959 [inline]
__mutex_lock+0x139/0x10c0 kernel/locking/mutex.c:1104
loop_probe+0xc7/0x150 drivers/block/loop.c:2234
blk_request_module+0x111/0x1d0 block/genhd.c:683
blkdev_get_no_open+0x1d8/0x250 fs/block_dev.c:1374
blkdev_get_by_dev fs/block_dev.c:1437 [inline]
blkdev_get_by_dev+0x76/0x660 fs/block_dev.c:1423
blkdev_open+0x154/0x2b0 fs/block_dev.c:1546
do_dentry_open+0x4b9/0x11b0 fs/open.c:826
do_open fs/namei.c:3361 [inline]
path_openat+0x1c0e/0x27e0 fs/namei.c:3494
do_filp_open+0x190/0x3d0 fs/namei.c:3521
do_sys_openat2+0x16d/0x420 fs/open.c:1187
do_sys_open fs/open.c:1203 [inline]
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
__x64_sys_open+0x119/0x1c0 fs/open.c:1207
__do_sys_open fs/open.c:1211 [inline]
__se_sys_open fs/open.c:1207 [inline]
do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f22c440a840
Code: 73 01 c3 48 8b 0d 68 77 20 00 f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 83 3d 89 bb 20 00 00 75 10 b8 02 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 1e f6 ff ff 48 89 04 24
RSP: 002b:00007ffeed68a608 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 0000558e425f5640 RCX: 00007f22c440a840
RDX: 0000558e42281fe3 RSI: 00000000000a0800 RDI: 0000558e42606fb0
RBP: 00007ffeed68a780 R08: 0000558e42281670 R09: 0000000000000010
R10: 00007f22c4184d70 R11: 0000000000000246 R12: 00007ffeed68a6d0
R13: 0000558e425f9540 R14: 0000000000000003 R15: 000000000000000e
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13d2d4a4300000
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
patch: https://syzkaller.appspot.com/x/patch.diff?x=140ce284300000
Desmond Cheong Zhi Xi
Jun 17, 2021, 4:40:19 AM6/17/21
to syzbot, syzkall...@googlegroups.com
On 17/6/21 2:03 pm, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> possible deadlock in loop_probe
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.13.0-rc6-syzkaller #0 Not tainted
Best,
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> possible deadlock in loop_probe
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.13.0-rc6-syzkaller #0 Not tainted
Desmond
syzbot
Jun 17, 2021, 4:59:12 AM6/17/21
to desmond...@gmail.com, syzkall...@googlegroups.com
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
Note: testing is done by a robot and is best-effort only.
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
patch: https://syzkaller.appspot.com/x/patch.diff?x=170c8548300000
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
Note: testing is done by a robot and is best-effort only.
syzbot
Jun 17, 2021, 10:23:08 AM6/17/21
to desmond...@gmail.com, syzkall...@googlegroups.com
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
patch: https://syzkaller.appspot.com/x/patch.diff?x=147de058300000
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
commit: 70585216 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
syzbot
Jun 18, 2021, 12:30:11 PM6/18/21
to penguin...@i-love.sakura.ne.jp, syzkall...@googlegroups.com
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
commit: fd0aa1a4 Merge tag 'for-linus' of git://git.kernel.org/pub..
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-and-tested-by: syzbot+6a8a0d...@syzkaller.appspotmail.com
Tested on:
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
patch: https://syzkaller.appspot.com/x/patch.diff?x=144d340c300000
kernel config: https://syzkaller.appspot.com/x/.config?x=3df058fc9d413abe
dashboard link: https://syzkaller.appspot.com/bug?extid=6a8a0d93c91e8fbf2e80
compiler:
Reply all
Reply to author
Forward
0 new messages