KASAN: slab-out-of-bounds Write in bitmap_ip_del

22 views
Skip to first unread message

syzbot

unread,
Jan 20, 2020, 1:47:08 AM1/20/20
to all...@lohutok.net, core...@netfilter.org, da...@davemloft.net, f...@strlen.de, gre...@linuxfoundation.org, jer...@azazel.net, kad...@netfilter.org, linux-...@vger.kernel.org, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, syzkall...@googlegroups.com, tg...@linutronix.de
Hello,

syzbot found the following crash on:

HEAD commit: 09d4f10a net: sched: act_ctinfo: fix memory leak
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=168f73b9e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=7e89bd00623fe71e
dashboard link: https://syzkaller.appspot.com/bug?extid=24d0577de55b8b8f6975
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1799c135e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=176b8faee00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+24d057...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in test_and_clear_bit include/asm-generic/bitops/instrumented-atomic.h:83 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_do_del net/netfilter/ipset/ip_set_bitmap_ip.c:89 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_del+0xdb/0x380 net/netfilter/ipset/ip_set_bitmap_gen.h:182
Write of size 8 at addr ffff888094779ec0 by task syz-executor498/9869

CPU: 0 PID: 9869 Comm: syz-executor498 Not tainted 5.5.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x197/0x210 lib/dump_stack.c:118
print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
__kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506
kasan_report+0x12/0x20 mm/kasan/common.c:639
check_memory_region_inline mm/kasan/generic.c:185 [inline]
check_memory_region+0x134/0x1a0 mm/kasan/generic.c:192
__kasan_check_write+0x14/0x20 mm/kasan/common.c:101
test_and_clear_bit include/asm-generic/bitops/instrumented-atomic.h:83 [inline]
bitmap_ip_do_del net/netfilter/ipset/ip_set_bitmap_ip.c:89 [inline]
bitmap_ip_del+0xdb/0x380 net/netfilter/ipset/ip_set_bitmap_gen.h:182
bitmap_ip_uadt+0x73e/0xa10 net/netfilter/ipset/ip_set_bitmap_ip.c:186
call_ad+0x1a0/0x5a0 net/netfilter/ipset/ip_set_core.c:1716
ip_set_ad.isra.0+0x572/0xb20 net/netfilter/ipset/ip_set_core.c:1804
ip_set_udel+0x3a/0x50 net/netfilter/ipset/ip_set_core.c:1838
nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:639 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:659
____sys_sendmsg+0x753/0x880 net/socket.c:2330
___sys_sendmsg+0x100/0x170 net/socket.c:2384
__sys_sendmsg+0x105/0x1d0 net/socket.c:2417
__do_sys_sendmsg net/socket.c:2426 [inline]
__se_sys_sendmsg net/socket.c:2424 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440689
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc9c51e348 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440689
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000000000004
RBP: 00000000006ca018 R08: 000000000000001c R09: 00000000004002c8
R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000401f10
R13: 0000000000401fa0 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 9869:
save_stack+0x23/0x90 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
__kasan_kmalloc mm/kasan/common.c:513 [inline]
__kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:486
kasan_kmalloc+0x9/0x10 mm/kasan/common.c:527
__do_kmalloc mm/slab.c:3656 [inline]
__kmalloc+0x163/0x770 mm/slab.c:3665
kmalloc include/linux/slab.h:561 [inline]
kzalloc include/linux/slab.h:670 [inline]
ip_set_alloc+0x38/0x5e net/netfilter/ipset/ip_set_core.c:255
init_map_ip net/netfilter/ipset/ip_set_bitmap_ip.c:223 [inline]
bitmap_ip_create+0x6ec/0xc20 net/netfilter/ipset/ip_set_bitmap_ip.c:327
ip_set_create+0x6f1/0x1500 net/netfilter/ipset/ip_set_core.c:1111
nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:639 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:659
____sys_sendmsg+0x753/0x880 net/socket.c:2330
___sys_sendmsg+0x100/0x170 net/socket.c:2384
__sys_sendmsg+0x105/0x1d0 net/socket.c:2417
__do_sys_sendmsg net/socket.c:2426 [inline]
__se_sys_sendmsg net/socket.c:2424 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 9598:
save_stack+0x23/0x90 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
kasan_set_free_info mm/kasan/common.c:335 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/common.c:474
kasan_slab_free+0xe/0x10 mm/kasan/common.c:483
__cache_free mm/slab.c:3426 [inline]
kfree+0x10a/0x2c0 mm/slab.c:3757
tomoyo_check_open_permission+0x19e/0x3e0 security/tomoyo/file.c:786
tomoyo_file_open security/tomoyo/tomoyo.c:319 [inline]
tomoyo_file_open+0xa9/0xd0 security/tomoyo/tomoyo.c:314
security_file_open+0x71/0x300 security/security.c:1497
do_dentry_open+0x37a/0x1380 fs/open.c:784
vfs_open+0xa0/0xd0 fs/open.c:914
do_last fs/namei.c:3420 [inline]
path_openat+0x10df/0x4500 fs/namei.c:3537
do_filp_open+0x1a1/0x280 fs/namei.c:3567
do_sys_open+0x3fe/0x5d0 fs/open.c:1097
__do_sys_open fs/open.c:1115 [inline]
__se_sys_open fs/open.c:1110 [inline]
__x64_sys_open+0x7e/0xc0 fs/open.c:1110
do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff888094779ec0
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes inside of
32-byte region [ffff888094779ec0, ffff888094779ee0)
The buggy address belongs to the page:
page:ffffea000251de40 refcount:1 mapcount:0 mapping:ffff8880aa4001c0 index:0xffff888094779fc1
raw: 00fffe0000000200 ffffea00027fee88 ffffea0002a42888 ffff8880aa4001c0
raw: ffff888094779fc1 ffff888094779000 000000010000002f 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff888094779d80: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff888094779e00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
>ffff888094779e80: 00 00 05 fc fc fc fc fc 04 fc fc fc fc fc fc fc
^
ffff888094779f00: 00 fc fc fc fc fc fc fc 00 00 03 fc fc fc fc fc
ffff888094779f80: fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

syzbot

unread,
Jan 20, 2020, 8:00:02 AM1/20/20
to all...@lohutok.net, arvid....@alten.se, core...@netfilter.org, da...@davemloft.net, dirk.van...@netronome.com, f...@strlen.de, gre...@linuxfoundation.org, jakub.k...@netronome.com, jer...@azazel.net, kad...@netfilter.org, linux-...@vger.kernel.org, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, syzkall...@googlegroups.com, tg...@linutronix.de
syzbot has bisected this bug to:

commit 0f93242d96ff5a04fe02c4978e8dddb014235971
Author: Jakub Kicinski <jakub.k...@netronome.com>
Date: Tue Jul 9 02:53:08 2019 +0000

nfp: tls: ignore queue limits for delete commands

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11f4e966e00000
start commit: 09d4f10a net: sched: act_ctinfo: fix memory leak
git tree: net
final crash: https://syzkaller.appspot.com/x/report.txt?x=13f4e966e00000
console output: https://syzkaller.appspot.com/x/log.txt?x=15f4e966e00000
Reported-by: syzbot+24d057...@syzkaller.appspotmail.com
Fixes: 0f93242d96ff ("nfp: tls: ignore queue limits for delete commands")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

syzbot

unread,
Feb 21, 2020, 2:05:03 PM2/21/20
to all...@lohutok.net, arvid....@alten.se, core...@netfilter.org, da...@davemloft.net, dirk.van...@netronome.com, f...@strlen.de, gre...@linuxfoundation.org, in...@metux.net, jakub.k...@netronome.com, jer...@azazel.net, kad...@blackhole.kfki.hu, kad...@netfilter.org, linux-...@vger.kernel.org, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, syzkall...@googlegroups.com, tg...@linutronix.de
syzbot suspects this bug was fixed by commit:

commit 32c72165dbd0e246e69d16a3ad348a4851afd415
Author: Kadlecsik József <kad...@blackhole.kfki.hu>
Date: Sun Jan 19 21:06:49 2020 +0000

netfilter: ipset: use bitmap infrastructure completely

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1226da7ee00000
start commit: d96d875e Merge tag 'fixes_for_v5.5-rc8' of git://git.kerne..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=cf8e288883e40aba
dashboard link: https://syzkaller.appspot.com/bug?extid=24d0577de55b8b8f6975
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14cddd76e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10f459c9e00000

If the result looks correct, please mark the bug fixed by replying with:

#syz fix: netfilter: ipset: use bitmap infrastructure completely

syzbot

unread,
Feb 22, 2020, 5:30:36 AM2/22/20
to Jozsef Kadlecsik, kad...@netfilter.org, syzkall...@googlegroups.com
> #syz fix: netfilter: ipset: use bitmap infrastructure completely

Your 'fix:' command is accepted, but please keep syzkall...@googlegroups.com mailing list in CC next time. It serves as a history of what happened with each bug report. Thank you.
> -
> E-mail : kad...@blackhole.kfki.hu, kadlecsi...@wigner.hu
> PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
> Address : Wigner Research Centre for Physics
> H-1525 Budapest 114, POB. 49, Hungary
Reply all
Reply to author
Forward
0 new messages