[syzbot] [udf?] WARNING in udf_new_block

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: eeac8ede1755 Linux 6.3-rc2
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16e97a70c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=dbab9019ad6fc418
dashboard link: https://syzkaller.appspot.com/bug?extid=cc717c6c5fee9ed6e41d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/204f10b1db6d/disk-eeac8ede.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c0ab57601df9/vmlinux-eeac8ede.xz
kernel image: https://storage.googleapis.com/syzbot-assets/21d53c00efd1/bzImage-eeac8ede.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cc717c...@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 14411 at fs/udf/udfdecl.h:123 udf_add_free_space fs/udf/balloc.c:125 [inline]
WARNING: CPU: 1 PID: 14411 at fs/udf/udfdecl.h:123 udf_table_new_block fs/udf/balloc.c:667 [inline]
WARNING: CPU: 1 PID: 14411 at fs/udf/udfdecl.h:123 udf_new_block+0x1dc2/0x2130 fs/udf/balloc.c:733
Modules linked in:
CPU: 1 PID: 14411 Comm: syz-executor.0 Not tainted 6.3.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
RIP: 0010:udf_updated_lvid fs/udf/udfdecl.h:121 [inline]
RIP: 0010:udf_add_free_space fs/udf/balloc.c:125 [inline]
RIP: 0010:udf_table_new_block fs/udf/balloc.c:667 [inline]
RIP: 0010:udf_new_block+0x1dc2/0x2130 fs/udf/balloc.c:733
Code: fe e9 00 fd ff ff e8 ed 61 8d fe 48 8b bc 24 88 00 00 00 e8 60 82 b8 07 45 31 f6 48 8b 5c 24 78 e9 6d fd ff ff e8 ce 61 8d fe <0f> 0b e9 64 fc ff ff 89 d9 80 e1 07 fe c1 38 c1 0f 8c 7d e3 ff ff
RSP: 0018:ffffc9001688f580 EFLAGS: 00010287
RAX: ffffffff82fde5b2 RBX: 000000004c84c04c RCX: 0000000000040000
RDX: ffffc90012967000 RSI: 0000000000000938 RDI: 0000000000000939
RBP: ffffc9001688f7d0 R08: ffffffff82fde210 R09: fffffbfff1ca8066
R10: 0000000000000000 R11: dffffc0000000001 R12: 0000000000000000
R13: dffffc0000000000 R14: ffff8880489d301c R15: 0000000000000037
FS: 00007fe1f2f80700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000002004c000 CR3: 000000001e4ed000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
udf_new_inode+0x389/0xd10 fs/udf/ialloc.c:71
udf_create+0x21/0xe0 fs/udf/namei.c:384
lookup_open fs/namei.c:3416 [inline]
open_last_lookups fs/namei.c:3484 [inline]
path_openat+0x13df/0x3170 fs/namei.c:3712
do_filp_open+0x234/0x490 fs/namei.c:3742
do_sys_openat2+0x13f/0x500 fs/open.c:1348
do_sys_open fs/open.c:1364 [inline]
__do_sys_open fs/open.c:1372 [inline]
__se_sys_open fs/open.c:1368 [inline]
__x64_sys_open+0x225/0x270 fs/open.c:1368
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fe1f228c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe1f2f80168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007fe1f23ac050 RCX: 00007fe1f228c0f9
RDX: 0000000000000048 RSI: 00000000000060c2 RDI: 0000000020000100
RBP: 00007fe1f22e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffec8d11ecf R14: 00007fe1f2f80300 R15: 0000000000022000
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 10a6e5feccb8 Merge tag 'drm-fixes-2023-10-13' of git://ano..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=113e0565680000
kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
dashboard link: https://syzkaller.appspot.com/bug?extid=cc717c6c5fee9ed6e41d
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16700ae5680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17f897f1680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/21775b2ca981/disk-10a6e5fe.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/dc65fd4b8051/vmlinux-10a6e5fe.xz
kernel image: https://storage.googleapis.com/syzbot-assets/77c25d5e1726/bzImage-10a6e5fe.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/0eb31cc26570/mount_5.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/57ae6a77a446/mount_9.gz
mounted in repro #3: https://storage.googleapis.com/syzbot-assets/0ed1541d7830/mount_17.gz
mounted in repro #4: https://storage.googleapis.com/syzbot-assets/92cae054e78b/mount_18.gz
mounted in repro #5: https://storage.googleapis.com/syzbot-assets/292eda4b66a9/mount_34.gz
mounted in repro #6: https://storage.googleapis.com/syzbot-assets/7066203790a0/mount_43.gz
mounted in repro #7: https://storage.googleapis.com/syzbot-assets/a204a71df92a/mount_47.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cc717c...@syzkaller.appspotmail.com

------------[ cut here ]------------

WARNING: CPU: 1 PID: 5033 at fs/udf/udfdecl.h:123 udf_add_free_space fs/udf/balloc.c:121 [inline]
WARNING: CPU: 1 PID: 5033 at fs/udf/udfdecl.h:123 udf_bitmap_new_block fs/udf/balloc.c:365 [inline]
WARNING: CPU: 1 PID: 5033 at fs/udf/udfdecl.h:123 udf_new_block+0x1dea/0x2130 fs/udf/balloc.c:725
Modules linked in:
CPU: 1 PID: 5033 Comm: syz-executor112 Not tainted 6.6.0-rc5-syzkaller-00192-g10a6e5feccb8 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023

RIP: 0010:udf_updated_lvid fs/udf/udfdecl.h:121 [inline]

RIP: 0010:udf_add_free_space fs/udf/balloc.c:121 [inline]
RIP: 0010:udf_bitmap_new_block fs/udf/balloc.c:365 [inline]
RIP: 0010:udf_new_block+0x1dea/0x2130 fs/udf/balloc.c:725
Code: 87 fe 0f 0b e9 64 fc ff ff 89 d9 80 e1 07 fe c1 38 c1 0f 8c 7d e3 ff ff 48 89 df e8 60 53 e2 fe e9 70 e3 ff ff e8 56 d4 87 fe <0f> 0b e9 10 ff ff ff 89 f9 80 e1 07 80 c1 03 38 c1 0f 8c fa e3 ff
RSP: 0018:ffffc9000395f5c0 EFLAGS: 00010293
RAX: ffffffff8306378a RBX: 0000000070d0c345 RCX: ffff88807e139dc0
RDX: 0000000000000000 RSI: 0000000070d0c345 RDI: 0000000000000000
RBP: ffffc9000395f810 R08: ffffffff83063694 R09: 1ffff1100ee3b7d0
R10: dffffc0000000000 R11: ffffed100ee3b7d1 R12: 000000000000003e
R13: dffffc0000000000 R14: ffff88807e23401c R15: 00000000000000fe
FS: 00005555572c4380(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f2aa7df4000 CR3: 0000000075d20000 CR4: 00000000003506e0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

udf_new_inode+0x389/0xcf0 fs/udf/ialloc.c:67
udf_create+0x21/0xe0 fs/udf/namei.c:380
lookup_open fs/namei.c:3495 [inline]
open_last_lookups fs/namei.c:3563 [inline]
path_openat+0x13e7/0x3180 fs/namei.c:3793
do_filp_open+0x234/0x490 fs/namei.c:3823
do_sys_openat2+0x13e/0x1d0 fs/open.c:1422
do_sys_open fs/open.c:1437 [inline]
__do_sys_creat fs/open.c:1513 [inline]
__se_sys_creat fs/open.c:1507 [inline]
__x64_sys_creat+0x123/0x160 fs/open.c:1507

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

RIP: 0033:0x7f2ab0213579
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc0fb25858 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f2ab025c04b RCX: 00007f2ab0213579
RDX: 00007f2ab0212870 RSI: 0000000000000000 RDI: 0000000020000440
RBP: 00007f2ab025c060 R08: 000000000001f21e R09: 00000000200012c0
R10: 000000000001f222 R11: 0000000000000246 R12: 00007f2ab025e158
R13: 000000000000ba30 R14: 0000000000000001 R15: 0000000000000001
</TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <ja...@suse.cz>
Date: Wed Nov 1 17:43:10 2023 +0000

fs: Block writes to mounted block devices

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15fe39a7e80000
start commit: 10a6e5feccb8 Merge tag 'drm-fixes-2023-10-13' of git://ano..
git tree: upstream

kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
dashboard link: https://syzkaller.appspot.com/bug?extid=cc717c6c5fee9ed6e41d

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16700ae5680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17f897f1680000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: Block writes to mounted block devices

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Jan Kara]

On Sat 27-01-24 17:57:03, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 6f861765464f43a71462d52026fbddfc858239a5
> Author: Jan Kara <ja...@suse.cz>
> Date: Wed Nov 1 17:43:10 2023 +0000
>
> fs: Block writes to mounted block devices
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15fe39a7e80000
> start commit: 10a6e5feccb8 Merge tag 'drm-fixes-2023-10-13' of git://ano..
> git tree: upstream
> kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
> dashboard link: https://syzkaller.appspot.com/bug?extid=cc717c6c5fee9ed6e41d
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16700ae5680000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17f897f1680000
>
> If the result looks correct, please mark the issue as fixed by replying with:

Yes, I was suspecting this from my experiments for a long time :)

#syz fix: fs: Block writes to mounted block devices

Honza
--
Jan Kara <ja...@suse.com>
SUSE Labs, CR