[syzbot] [gfs2?] BUG: sleeping function called from invalid context in gfs2_withdraw

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 65d6e954e378 Merge tag 'gfs2-v6.5-rc5-fixes' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10994bcc680000
kernel config: https://syzkaller.appspot.com/x/.config?x=cbf8b29a87b8a830
dashboard link: https://syzkaller.appspot.com/bug?extid=577d06779fa95206ba66
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10cd8e20680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=115ddba8680000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-65d6e954.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/040b1e85a692/vmlinux-65d6e954.xz
kernel image: https://storage.googleapis.com/syzbot-assets/984f55ac441b/bzImage-65d6e954.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/cd97a0244981/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+577d06...@syzkaller.appspotmail.com

loop0: rw=1, sector=3280942697285464, nr_sectors = 8 limit=32768
gfs2: fsid=syz:syz.0: Error 10 writing to journal, jid=0
gfs2: fsid=syz:syz.0: fatal: I/O error(s)
gfs2: fsid=syz:syz.0: about to withdraw this file system
BUG: sleeping function called from invalid context at fs/gfs2/util.c:157
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 5141, name: syz-executor200
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
Preemption disabled at:
[<0000000000000000>] 0x0
CPU: 1 PID: 5141 Comm: syz-executor200 Not tainted 6.5.0-syzkaller-11938-g65d6e954e378 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x125/0x1b0 lib/dump_stack.c:106
__might_resched+0x3c3/0x5e0 kernel/sched/core.c:10187
signal_our_withdraw fs/gfs2/util.c:157 [inline]
gfs2_withdraw+0xc7d/0x1280 fs/gfs2/util.c:342
gfs2_ail1_empty+0x8cc/0xab0 fs/gfs2/log.c:377
gfs2_flush_revokes+0x6b/0x90 fs/gfs2/log.c:815
revoke_lo_before_commit+0x22/0x640 fs/gfs2/lops.c:867
lops_before_commit fs/gfs2/lops.h:40 [inline]
gfs2_log_flush+0x105e/0x27f0 fs/gfs2/log.c:1101
gfs2_write_inode+0x24a/0x4b0 fs/gfs2/super.c:453
write_inode fs/fs-writeback.c:1456 [inline]
__writeback_single_inode+0xa81/0xe70 fs/fs-writeback.c:1668
writeback_single_inode+0x2af/0x590 fs/fs-writeback.c:1724
sync_inode_metadata+0xa5/0xe0 fs/fs-writeback.c:2786
gfs2_fsync+0x218/0x380 fs/gfs2/file.c:761
vfs_fsync_range+0x141/0x220 fs/sync.c:188
generic_write_sync include/linux/fs.h:2625 [inline]
gfs2_file_write_iter+0xd97/0x10c0 fs/gfs2/file.c:1150
call_write_iter include/linux/fs.h:1985 [inline]
do_iter_readv_writev+0x21e/0x3c0 fs/read_write.c:735
do_iter_write+0x17f/0x830 fs/read_write.c:860
vfs_iter_write+0x7a/0xb0 fs/read_write.c:901
iter_file_splice_write+0x698/0xbf0 fs/splice.c:736
do_splice_from fs/splice.c:933 [inline]
direct_splice_actor+0x118/0x180 fs/splice.c:1142
splice_direct_to_actor+0x347/0xa30 fs/splice.c:1088
do_splice_direct+0x1af/0x280 fs/splice.c:1194
do_sendfile+0xb88/0x1390 fs/read_write.c:1254
__do_sys_sendfile64 fs/read_write.c:1322 [inline]
__se_sys_sendfile64 fs/read_write.c:1308 [inline]
__x64_sys_sendfile64+0x1d6/0x220 fs/read_write.c:1308
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f86c8957779
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffef8d7a208 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007ffef8d7a3d8 RCX: 00007f86c8957779
RDX: 0000000000000000 RSI: 0000000000000007 RDI: 0000000000000006
RBP: 00007f86c89dc610 R08: 00007ffef8d7a3d8 R09: 00007ffef8d7a3d8
R10: 0001000000201004 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffef8d7a3c8 R14: 0000000000000001 R15: 0000000000000001
</TASK>
BUG: scheduling while atomic: syz-executor200/5141/0x00000002
INFO: lockdep is turned off.
Modules linked in:
Preemption disabled at:
[<0000000000000000>] 0x0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <ja...@suse.cz>
Date: Wed Nov 1 17:43:10 2023 +0000

fs: Block writes to mounted block devices

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=119f927a180000
start commit: 6465e260f487 Linux 6.6-rc3
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=8d7d7928f78936aa
dashboard link: https://syzkaller.appspot.com/bug?extid=577d06779fa95206ba66
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10dbcdc1680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17a367b6680000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: Block writes to mounted block devices

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Andreas Gruenbacher]

Sounds reasonable:

#syz fix: fs: Block writes to mounted block devices

Andreas