KASAN: slab-out-of-bounds Read in bitmap_ip_ext_cleanup

21 views
Skip to first unread message

syzbot

unread,
Jan 19, 2020, 6:17:10 PM1/19/20
to core...@netfilter.org, da...@davemloft.net, florent...@wifirst.fr, f...@strlen.de, jer...@azazel.net, johann...@intel.com, kad...@netfilter.org, linux-...@vger.kernel.org, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, syzkall...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: 09d4f10a net: sched: act_ctinfo: fix memory leak
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=15fec135e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=7e89bd00623fe71e
dashboard link: https://syzkaller.appspot.com/bug?extid=6491ea8f6dddbf04930e
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=141af959e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1067fa85e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+6491ea...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in test_bit include/asm-generic/bitops/instrumented-non-atomic.h:110 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_ext_cleanup+0xd8/0x290 net/netfilter/ipset/ip_set_bitmap_gen.h:51
Read of size 8 at addr ffff8880a7d15c80 by task syz-executor874/9996

CPU: 1 PID: 9996 Comm: syz-executor874 Not tainted 5.5.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x197/0x210 lib/dump_stack.c:118
print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
__kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506
kasan_report+0x12/0x20 mm/kasan/common.c:639
check_memory_region_inline mm/kasan/generic.c:185 [inline]
check_memory_region+0x134/0x1a0 mm/kasan/generic.c:192
__kasan_check_read+0x11/0x20 mm/kasan/common.c:95
test_bit include/asm-generic/bitops/instrumented-non-atomic.h:110 [inline]
bitmap_ip_ext_cleanup+0xd8/0x290 net/netfilter/ipset/ip_set_bitmap_gen.h:51
bitmap_ip_destroy+0x180/0x1d0 net/netfilter/ipset/ip_set_bitmap_gen.h:64
ip_set_create+0xe47/0x1500 net/netfilter/ipset/ip_set_core.c:1165
nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:639 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:659
____sys_sendmsg+0x753/0x880 net/socket.c:2330
___sys_sendmsg+0x100/0x170 net/socket.c:2384
__sys_sendmsg+0x105/0x1d0 net/socket.c:2417
__do_sys_sendmsg net/socket.c:2426 [inline]
__se_sys_sendmsg net/socket.c:2424 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x441459
Code: e8 fc ab 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 9b 09 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffee4e5cf88 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441459
RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000003
RBP: 000000000001ac44 R08: 00000000004002c8 R09: 00000000004002c8
R10: 0000000000000004 R11: 0000000000000246 R12: 0000000000402280
R13: 0000000000402310 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 9996:
save_stack+0x23/0x90 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
__kasan_kmalloc mm/kasan/common.c:513 [inline]
__kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:486
kasan_kmalloc+0x9/0x10 mm/kasan/common.c:527
__do_kmalloc mm/slab.c:3656 [inline]
__kmalloc+0x163/0x770 mm/slab.c:3665
kmalloc include/linux/slab.h:561 [inline]
kzalloc include/linux/slab.h:670 [inline]
ip_set_alloc+0x38/0x5e net/netfilter/ipset/ip_set_core.c:255
init_map_ip net/netfilter/ipset/ip_set_bitmap_ip.c:223 [inline]
bitmap_ip_create+0x6ec/0xc20 net/netfilter/ipset/ip_set_bitmap_ip.c:327
ip_set_create+0x6f1/0x1500 net/netfilter/ipset/ip_set_core.c:1111
nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
sock_sendmsg_nosec net/socket.c:639 [inline]
sock_sendmsg+0xd7/0x130 net/socket.c:659
____sys_sendmsg+0x753/0x880 net/socket.c:2330
___sys_sendmsg+0x100/0x170 net/socket.c:2384
__sys_sendmsg+0x105/0x1d0 net/socket.c:2417
__do_sys_sendmsg net/socket.c:2426 [inline]
__se_sys_sendmsg net/socket.c:2424 [inline]
__x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 9722:
save_stack+0x23/0x90 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
kasan_set_free_info mm/kasan/common.c:335 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/common.c:474
kasan_slab_free+0xe/0x10 mm/kasan/common.c:483
__cache_free mm/slab.c:3426 [inline]
kfree+0x10a/0x2c0 mm/slab.c:3757
single_release+0x95/0xc0 fs/seq_file.c:609
__fput+0x2ff/0x890 fs/file_table.c:280
____fput+0x16/0x20 fs/file_table.c:313
task_work_run+0x145/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:195 [inline]
syscall_return_slowpath arch/x86/entry/common.c:278 [inline]
do_syscall_64+0x676/0x790 arch/x86/entry/common.c:304
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8880a7d15c80
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes inside of
32-byte region [ffff8880a7d15c80, ffff8880a7d15ca0)
The buggy address belongs to the page:
page:ffffea00029f4540 refcount:1 mapcount:0 mapping:ffff8880aa4001c0 index:0xffff8880a7d15fc1
raw: 00fffe0000000200 ffffea00027c0bc8 ffffea00029aa6c8 ffff8880aa4001c0
raw: ffff8880a7d15fc1 ffff8880a7d15000 0000000100000034 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8880a7d15b80: 00 05 fc fc fc fc fc fc fb fb fb fb fc fc fc fc
ffff8880a7d15c00: 00 00 00 fc fc fc fc fc 00 fc fc fc fc fc fc fc
>ffff8880a7d15c80: 04 fc fc fc fc fc fc fc 00 00 00 fc fc fc fc fc
^
ffff8880a7d15d00: 04 fc fc fc fc fc fc fc fb fb fb fb fc fc fc fc
ffff8880a7d15d80: 05 fc fc fc fc fc fc fc 00 00 fc fc fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

syzbot

unread,
Jan 19, 2020, 8:35:02 PM1/19/20
to a...@unstable.cc, ak...@linux-foundation.org, all...@lohutok.net, ar...@arndb.de, ax...@kernel.dk, b.a.t...@lists.open-mesh.org, b...@alien8.de, catalin...@arm.com, ch...@zankel.net, chri...@brauner.io, core...@netfilter.org, da...@davemloft.net, elena.r...@intel.com, florent...@wifirst.fr, f...@strlen.de, ge...@linux-m68k.org, ha...@suse.com, heiko.c...@de.ibm.com, h...@zytor.com, in...@metux.net, jcmv...@gmail.com, jer...@azazel.net, johann...@intel.com, kad...@netfilter.org, linu...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux-...@linux-xtensa.org, li...@armlinux.org.uk, marekl...@neomailbox.ch, mi...@redhat.com, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, pet...@infradead.org, s...@simonwunderlich.de, syzkall...@googlegroups.com, tg...@linutronix.de, vi...@zeniv.linux.org.uk, wi...@kernel.org, x...@kernel.org
syzbot has bisected this bug to:

commit d68dbb0c9ac8b1ff52eb09aa58ce6358400fa939
Author: Christian Brauner <chri...@brauner.io>
Date: Thu Jun 20 23:26:35 2019 +0000

arch: handle arches who do not yet define clone3

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1456fed1e00000
start commit: 09d4f10a net: sched: act_ctinfo: fix memory leak
git tree: net
final crash: https://syzkaller.appspot.com/x/report.txt?x=1656fed1e00000
console output: https://syzkaller.appspot.com/x/log.txt?x=1256fed1e00000
Reported-by: syzbot+6491ea...@syzkaller.appspotmail.com
Fixes: d68dbb0c9ac8 ("arch: handle arches who do not yet define clone3")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Christian Brauner

unread,
Jan 20, 2020, 8:22:34 AM1/20/20
to syzbot, a...@unstable.cc, ak...@linux-foundation.org, all...@lohutok.net, ar...@arndb.de, ax...@kernel.dk, b.a.t...@lists.open-mesh.org, b...@alien8.de, catalin...@arm.com, ch...@zankel.net, chri...@brauner.io, core...@netfilter.org, da...@davemloft.net, elena.r...@intel.com, florent...@wifirst.fr, f...@strlen.de, ge...@linux-m68k.org, ha...@suse.com, heiko.c...@de.ibm.com, h...@zytor.com, in...@metux.net, jcmv...@gmail.com, jer...@azazel.net, johann...@intel.com, kad...@netfilter.org, linu...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux-...@linux-xtensa.org, li...@armlinux.org.uk, marekl...@neomailbox.ch, mi...@redhat.com, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, pet...@infradead.org, s...@simonwunderlich.de, syzkall...@googlegroups.com, tg...@linutronix.de, vi...@zeniv.linux.org.uk, wi...@kernel.org, x...@kernel.org
This bisect seems bogus.

Christian

Dan Carpenter

unread,
Jan 20, 2020, 12:43:30 PM1/20/20
to Christian Brauner, syzbot, a...@unstable.cc, ak...@linux-foundation.org, all...@lohutok.net, ar...@arndb.de, ax...@kernel.dk, b.a.t...@lists.open-mesh.org, b...@alien8.de, catalin...@arm.com, ch...@zankel.net, chri...@brauner.io, core...@netfilter.org, da...@davemloft.net, elena.r...@intel.com, florent...@wifirst.fr, f...@strlen.de, ge...@linux-m68k.org, ha...@suse.com, heiko.c...@de.ibm.com, h...@zytor.com, in...@metux.net, jcmv...@gmail.com, jer...@azazel.net, johann...@intel.com, kad...@netfilter.org, linu...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux-...@linux-xtensa.org, li...@armlinux.org.uk, marekl...@neomailbox.ch, mi...@redhat.com, net...@vger.kernel.org, netfilt...@vger.kernel.org, pa...@netfilter.org, pet...@infradead.org, s...@simonwunderlich.de, syzkall...@googlegroups.com, tg...@linutronix.de, vi...@zeniv.linux.org.uk, wi...@kernel.org, x...@kernel.org
Yeah. József Kadlecsik already fixed the bug in a different thread. It
was reported as seven different bugs so there was a bunch of threads for
it.

regards,
dan carpenter

syzbot

unread,
Mar 15, 2020, 10:40:04 PM3/15/20
to a...@unstable.cc, ak...@linux-foundation.org, all...@lohutok.net, ar...@arndb.de, ax...@kernel.dk, b.a.t...@lists.open-mesh.org, b...@alien8.de, catalin...@arm.com, ch...@zankel.net, christia...@ubuntu.com, chri...@brauner.io, core...@netfilter.org, dan.ca...@oracle.com, da...@davemloft.net, elena.r...@intel.com, florent...@wifirst.fr, f...@strlen.de, ge...@linux-m68k.org, ha...@suse.com, heiko.c...@de.ibm.com, h...@zytor.com, in...@drgreenstore.com, in...@metux.net, jcmv...@gmail.com, jer...@azazel.net, johann...@intel.com, kad...@blackhole.kfki.hu, kad...@netfilter.org, linu...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux-...@linux-xtensa.org, li...@armlinux.org.uk, marekl...@neomailbox.ch, mi...@redhat.com, net...@vger.kernel.org, netfilter-...@lists.netfilter.org, netfilt...@vger.kernel.org, pa...@netfilter.org, pet...@infradead.org, s...@simonwunderlich.de, syzkall...@googlegroups.com, tg...@linutronix.de, vi...@zeniv.linux.org.uk, wi...@kernel.org, x...@kernel.org
syzbot suspects this bug was fixed by commit:

commit 32c72165dbd0e246e69d16a3ad348a4851afd415
Author: Kadlecsik József <kad...@blackhole.kfki.hu>
Date: Sun Jan 19 21:06:49 2020 +0000

netfilter: ipset: use bitmap infrastructure completely

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16b8e545e00000
start commit: d96d875e Merge tag 'fixes_for_v5.5-rc8' of git://git.kerne..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=cf8e288883e40aba
dashboard link: https://syzkaller.appspot.com/bug?extid=6491ea8f6dddbf04930e
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=126748d6e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1385f959e00000

If the result looks correct, please mark the bug fixed by replying with:

#syz fix: netfilter: ipset: use bitmap infrastructure completely

syzbot

unread,
Mar 16, 2020, 4:20:54 AM3/16/20
to Jozsef Kadlecsik, kad...@netfilter.org, syzkall...@googlegroups.com
> #syz fix: netfilter: ipset: use bitmap infrastructure completely

Your 'fix:' command is accepted, but please keep syzkall...@googlegroups.com mailing list in CC next time. It serves as a history of what happened with each bug report. Thank you.
> -
> E-mail : kad...@blackhole.kfki.hu, kadlecsi...@wigner.hu
> PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
> Address : Wigner Research Centre for Physics
> H-1525 Budapest 114, POB. 49, Hungary
Reply all
Reply to author
Forward
0 new messages