[syzbot] [pm?] KASAN: use-after-free Read in netdev_unregister_kobject

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3cdb45594619 Merge tag 's390-6.9-4' of git://git.kernel.or..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=13d23353180000
kernel config: https://syzkaller.appspot.com/x/.config?x=d239903bd07761e5
dashboard link: https://syzkaller.appspot.com/bug?extid=6cf5652d3df49fae2e3f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=172afcbf180000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144067cb180000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/5135044ea611/disk-3cdb4559.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3c5a5ab80ba8/vmlinux-3cdb4559.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e215eb6531dd/bzImage-3cdb4559.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6cf565...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: use-after-free in device_for_each_child+0xa7/0x170 drivers/base/core.c:4044
Read of size 8 at addr ffff88807bee95f8 by task kbnepd bnep0/5202

CPU: 0 PID: 5202 Comm: kbnepd bnep0 Not tainted 6.9.0-rc4-syzkaller-00173-g3cdb45594619 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
print_address_description mm/kasan/report.c:377 [inline]
print_report+0x169/0x550 mm/kasan/report.c:488
kasan_report+0x143/0x180 mm/kasan/report.c:601
device_for_each_child+0xa7/0x170 drivers/base/core.c:4044
pm_runtime_set_memalloc_noio+0x114/0x260 drivers/base/power/runtime.c:248
netdev_unregister_kobject+0x178/0x250 net/core/net-sysfs.c:2106
unregister_netdevice_many_notify+0x11dd/0x16e0 net/core/dev.c:11135
unregister_netdevice_many net/core/dev.c:11163 [inline]
unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11042
unregister_netdevice include/linux/netdevice.h:3115 [inline]
unregister_netdev+0x1c/0x30 net/core/dev.c:11181
bnep_session+0x2e09/0x3000 net/bluetooth/bnep/core.c:525
kthread+0x2f2/0x390 kernel/kthread.c:388
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
</TASK>

The buggy address belongs to the physical page:
page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x400000000 pfn:0x7bee9
flags: 0xfff80000000000(node=0|zone=1|lastcpupid=0xfff)
page_type: 0xffffffff()
raw: 00fff80000000000 0000000000000000 dead000000000122 0000000000000000
raw: 0000000400000000 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 2, migratetype Unmovable, gfp_mask 0x40dc0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO), pid 5095, tgid -432259438 (syz-executor223), ts 5095, free_ts 96070220809
set_page_owner include/linux/page_owner.h:32 [inline]
post_alloc_hook+0x1ea/0x210 mm/page_alloc.c:1534
prep_new_page mm/page_alloc.c:1541 [inline]
get_page_from_freelist+0x3410/0x35b0 mm/page_alloc.c:3317
__alloc_pages+0x256/0x6c0 mm/page_alloc.c:4575
__alloc_pages_node include/linux/gfp.h:238 [inline]
alloc_pages_node include/linux/gfp.h:261 [inline]
__kmalloc_large_node+0x91/0x1f0 mm/slub.c:3911
__do_kmalloc_node mm/slub.c:3954 [inline]
__kmalloc+0x320/0x4a0 mm/slub.c:3979
kmalloc include/linux/slab.h:632 [inline]
kzalloc include/linux/slab.h:749 [inline]
hci_alloc_dev_priv+0x27/0x2030 net/bluetooth/hci_core.c:2500
hci_alloc_dev include/net/bluetooth/hci_core.h:1672 [inline]
__vhci_create_device drivers/bluetooth/hci_vhci.c:406 [inline]
vhci_create_device+0x12e/0x720 drivers/bluetooth/hci_vhci.c:480
vhci_get_user drivers/bluetooth/hci_vhci.c:537 [inline]
vhci_write+0x3cb/0x480 drivers/bluetooth/hci_vhci.c:617
call_write_iter include/linux/fs.h:2110 [inline]
new_sync_write fs/read_write.c:497 [inline]
vfs_write+0xa86/0xcb0 fs/read_write.c:590
ksys_write+0x1a0/0x2c0 fs/read_write.c:643
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
page last free pid 5095 tgid 5095 stack trace:
reset_page_owner include/linux/page_owner.h:25 [inline]
free_pages_prepare mm/page_alloc.c:1141 [inline]
free_unref_page_prepare+0x986/0xab0 mm/page_alloc.c:2347
free_unref_page+0x37/0x3f0 mm/page_alloc.c:2487
__folio_put_large+0x13f/0x190 mm/swap.c:132
__folio_put+0x299/0x390 mm/swap.c:140
folio_put include/linux/mm.h:1506 [inline]
free_large_kmalloc+0x105/0x1c0 mm/slub.c:4361
kfree+0x1ca/0x3a0 mm/slub.c:4384
hci_release_dev+0x1516/0x16a0 net/bluetooth/hci_core.c:2833
bt_host_release+0x83/0x90 net/bluetooth/hci_sysfs.c:94
device_release+0x9b/0x1c0
kobject_cleanup lib/kobject.c:689 [inline]
kobject_release lib/kobject.c:720 [inline]
kref_put include/linux/kref.h:65 [inline]
kobject_put+0x231/0x480 lib/kobject.c:737
vhci_release+0x8b/0xd0 drivers/bluetooth/hci_vhci.c:675
__fput+0x42b/0x8a0 fs/file_table.c:422
task_work_run+0x251/0x310 kernel/task_work.c:180
exit_task_work include/linux/task_work.h:38 [inline]
do_exit+0xa1b/0x27e0 kernel/exit.c:878
do_group_exit+0x207/0x2c0 kernel/exit.c:1027
__do_sys_exit_group kernel/exit.c:1038 [inline]
__se_sys_exit_group kernel/exit.c:1036 [inline]
__x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1036

Memory state around the buggy address:
ffff88807bee9480: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88807bee9500: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88807bee9580: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88807bee9600: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88807bee9680: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[Hillf Danton]

On Mon, 22 Apr 2024 08:35:25 -0700

> syzbot found the following issue on:
>
> HEAD commit: 3cdb45594619 Merge tag 's390-6.9-4' of git://git.kernel.or..
> git tree: upstream

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144067cb180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3cdb45594619

--- x/net/bluetooth/bnep/core.c
+++ y/net/bluetooth/bnep/core.c
@@ -659,7 +659,7 @@ int bnep_del_connection(struct bnep_conn
if (req->flags & ~valid_flags)
return -EINVAL;

- down_read(&bnep_session_sem);
+ down_write(&bnep_session_sem);

s = __bnep_get_session(req->dst);
if (s) {
@@ -668,7 +668,7 @@ int bnep_del_connection(struct bnep_conn
} else
err = -ENOENT;

- up_read(&bnep_session_sem);
+ up_write(&bnep_session_sem);
return err;
}

--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: use-after-free Read in netdev_unregister_kobject

==================================================================
BUG: KASAN: use-after-free in device_for_each_child+0xa7/0x170 drivers/base/core.c:4044

Read of size 8 at addr ffff8880293555f8 by task kbnepd bnep0/5664

CPU: 0 PID: 5664 Comm: kbnepd bnep0 Not tainted 6.9.0-rc4-syzkaller-00173-g3cdb45594619-dirty #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
print_address_description mm/kasan/report.c:377 [inline]
print_report+0x169/0x550 mm/kasan/report.c:488
kasan_report+0x143/0x180 mm/kasan/report.c:601
device_for_each_child+0xa7/0x170 drivers/base/core.c:4044
pm_runtime_set_memalloc_noio+0x114/0x260 drivers/base/power/runtime.c:248
netdev_unregister_kobject+0x178/0x250 net/core/net-sysfs.c:2106
unregister_netdevice_many_notify+0x11dd/0x16e0 net/core/dev.c:11135
unregister_netdevice_many net/core/dev.c:11163 [inline]
unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11042
unregister_netdevice include/linux/netdevice.h:3115 [inline]
unregister_netdev+0x1c/0x30 net/core/dev.c:11181
bnep_session+0x2e09/0x3000 net/bluetooth/bnep/core.c:525
kthread+0x2f2/0x390 kernel/kthread.c:388
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
</TASK>

The buggy address belongs to the physical page:

page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x29355

flags: 0xfff80000000000(node=0|zone=1|lastcpupid=0xfff)
page_type: 0xffffffff()

raw: 00fff80000000000 ffffea0000a4d588 ffffea0000a4d508 0000000000000000
raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000

page dumped because: kasan: bad access detected
page_owner tracks the page as freed

page last allocated via order 2, migratetype Unmovable, gfp_mask 0x140dc0(GFP_USER|__GFP_COMP|__GFP_ZERO), pid 5470, tgid 1627921193 (syz-executor.4), ts 5470, free_ts 128431373442

page last free pid 5470 tgid 5470 stack trace:

ffff888029355480: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff888029355500: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff888029355580: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff888029355600: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff888029355680: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================


Tested on:

commit: 3cdb4559 Merge tag 's390-6.9-4' of git://git.kernel.or..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=10c3d0d3180000

kernel config: https://syzkaller.appspot.com/x/.config?x=d239903bd07761e5
dashboard link: https://syzkaller.appspot.com/bug?extid=6cf5652d3df49fae2e3f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=105d6b20980000

[Hillf Danton]

On Mon, 22 Apr 2024 08:35:25 -0700

> syzbot found the following issue on:
>
> HEAD commit: 3cdb45594619 Merge tag 's390-6.9-4' of git://git.kernel.or..
> git tree: upstream

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144067cb180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3cdb45594619

--- x/net/bluetooth/bnep/core.c
+++ y/net/bluetooth/bnep/core.c

@@ -535,6 +535,7 @@ static int bnep_session(void *arg)
__bnep_unlink_session(s);

up_write(&bnep_session_sem);
+ put_device(dev->dev.parent);
free_netdev(dev);
module_put_and_kthread_exit(0);
return 0;
@@ -618,7 +619,7 @@ int bnep_add_connection(struct bnep_conn
bnep_set_default_proto_filter(s);
#endif

- SET_NETDEV_DEV(dev, bnep_get_device(s));
+ SET_NETDEV_DEV(dev, get_device(bnep_get_device(s)));
SET_NETDEV_DEVTYPE(dev, &bnep_type);

err = register_netdev(dev);
--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:

KASAN: out-of-bounds Read in netdev_unregister_kobject

==================================================================
BUG: KASAN: out-of-bounds in device_for_each_child+0xa7/0x170 drivers/base/core.c:4044
Read of size 8 at addr ffff88806e92d5f8 by task kbnepd bnep0/5637

CPU: 0 PID: 5637 Comm: kbnepd bnep0 Not tainted 6.9.0-rc4-syzkaller-00173-g3cdb45594619-dirty #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
print_address_description mm/kasan/report.c:377 [inline]
print_report+0x169/0x550 mm/kasan/report.c:488
kasan_report+0x143/0x180 mm/kasan/report.c:601
device_for_each_child+0xa7/0x170 drivers/base/core.c:4044
pm_runtime_set_memalloc_noio+0x114/0x260 drivers/base/power/runtime.c:248
netdev_unregister_kobject+0x178/0x250 net/core/net-sysfs.c:2106
unregister_netdevice_many_notify+0x11dd/0x16e0 net/core/dev.c:11135
unregister_netdevice_many net/core/dev.c:11163 [inline]
unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11042
unregister_netdevice include/linux/netdevice.h:3115 [inline]
unregister_netdev+0x1c/0x30 net/core/dev.c:11181

bnep_session+0x2e09/0x3030 net/bluetooth/bnep/core.c:525

kthread+0x2f2/0x390 kernel/kthread.c:388
ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
</TASK>

The buggy address belongs to the physical page:

page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x6e92c
head: order:2 entire_mapcount:0 nr_pages_mapped:0 pincount:0
flags: 0xfff80000000040(head|node=0|zone=1|lastcpupid=0xfff)
page_type: 0xffffffff()
raw: 00fff80000000040 0000000000000000 dead000000000122 0000000000000000
raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000
head: 00fff80000000040 0000000000000000 dead000000000122 0000000000000000
head: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000
head: 00fff80000000002 ffffea0001ba4b01 dead000000000122 00000000ffffffff
head: 0000000400000000 0000000000000000 00000000ffffffff 0000000000000000

page dumped because: kasan: bad access detected

page_owner tracks the page as allocated
page last allocated via order 2, migratetype Unmovable, gfp_mask 0x140dc0(GFP_USER|__GFP_COMP|__GFP_ZERO), pid 5732, tgid -1102947349 (syz-executor.3), ts 5732, free_ts 127654865274

page last free pid 5462 tgid 5462 stack trace:

ffff88806e92d500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88806e92d580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88806e92d600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
ffff88806e92d680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88806e92d700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

==================================================================


Tested on:

commit: 3cdb4559 Merge tag 's390-6.9-4' of git://git.kernel.or..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

console output: https://syzkaller.appspot.com/x/log.txt?x=12f4cd9f180000

kernel config: https://syzkaller.appspot.com/x/.config?x=d239903bd07761e5
dashboard link: https://syzkaller.appspot.com/bug?extid=6cf5652d3df49fae2e3f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=124cca53180000

[Hillf Danton]

On Mon, 22 Apr 2024 08:35:25 -0700

> syzbot found the following issue on:
>
> HEAD commit: 3cdb45594619 Merge tag 's390-6.9-4' of git://git.kernel.or..
> git tree: upstream

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144067cb180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3cdb45594619

--- x/net/bluetooth/bnep/core.c
+++ y/net/bluetooth/bnep/core.c

@@ -540,16 +540,6 @@ static int bnep_session(void *arg)
return 0;
}

-static struct device *bnep_get_device(struct bnep_session *session)
-{
- struct l2cap_conn *conn = l2cap_pi(session->sock->sk)->chan->conn;
-
- if (!conn || !conn->hcon)
- return NULL;
-
- return &conn->hcon->dev;
-}
-
static const struct device_type bnep_type = {
.name = "bluetooth",
};
@@ -618,7 +608,6 @@ int bnep_add_connection(struct bnep_conn

bnep_set_default_proto_filter(s);
#endif

- SET_NETDEV_DEV(dev, bnep_get_device(s));

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+6cf565...@syzkaller.appspotmail.com

Tested on:

commit: 3cdb4559 Merge tag 's390-6.9-4' of git://git.kernel.or..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

console output: https://syzkaller.appspot.com/x/log.txt?x=119e4230980000

kernel config: https://syzkaller.appspot.com/x/.config?x=d239903bd07761e5
dashboard link: https://syzkaller.appspot.com/bug?extid=6cf5652d3df49fae2e3f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=15e9a8d3180000

Note: testing is done by a robot and is best-effort only.