Hello,
syzbot has tested the proposed patch but the reproducer still triggered
crash:
KASAN: use-after-free Read in __vb2_perform_fileio
8021q: adding VLAN 0 to HW filter on device team0
8021q: adding VLAN 0 to HW filter on device team0
vivid-000: kernel_thread() failed
vivid-000: kernel_thread() failed
==================================================================
BUG: KASAN: use-after-free in __vb2_perform_fileio+0x10e2/0x1210
drivers/media/common/videobuf2/videobuf2-core.c:2567
Read of size 4 at addr ffff8801c05aa79c by task syz-executor4/7617
CPU: 0 PID: 7617 Comm: syz-executor4 Not tainted 4.20.0-rc1+ #1
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x244/0x39d lib/dump_stack.c:113
print_address_description.cold.7+0x9/0x1ff mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.8+0x242/0x309 mm/kasan/report.c:412
__asan_report_load4_noabort+0x14/0x20 mm/kasan/report.c:432
__vb2_perform_fileio+0x10e2/0x1210
drivers/media/common/videobuf2/videobuf2-core.c:2567
vb2_read+0x3b/0x50 drivers/media/common/videobuf2/videobuf2-core.c:2678
vb2_fop_read+0x20a/0x400
drivers/media/common/videobuf2/videobuf2-v4l2.c:1065
v4l2_read+0x168/0x220 drivers/media/v4l2-core/v4l2-dev.c:317
__vfs_read+0x117/0x9b0 fs/read_write.c:416
vfs_read+0x17f/0x3c0 fs/read_write.c:452
ksys_read+0x101/0x260 fs/read_write.c:578
__do_sys_read fs/read_write.c:588 [inline]
__se_sys_read fs/read_write.c:586 [inline]
__ia32_sys_read+0x71/0xb0 fs/read_write.c:586
do_syscall_32_irqs_on arch/x86/entry/common.c:326 [inline]
do_fast_syscall_32+0x34d/0xfb2 arch/x86/entry/common.c:397
entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139
RIP: 0023:0xf7f92a29
Code: 85 d2 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 3c 24 c3 90 90
90 90 90 90 90 90 90 90 90 90 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90
90 90 90 eb 0d 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 002b:00000000f7f8e0cc EFLAGS: 00000296 ORIG_RAX: 0000000000000003
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000020000040
RDX: 000000000000004a RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Allocated by task 7617:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553
kmem_cache_alloc_trace+0x152/0x750 mm/slab.c:3620
kmalloc include/linux/slab.h:546 [inline]
kzalloc include/linux/slab.h:741 [inline]
__vb2_init_fileio+0x1ce/0xc90
drivers/media/common/videobuf2/videobuf2-core.c:2412
__vb2_perform_fileio+0xcfd/0x1210
drivers/media/common/videobuf2/videobuf2-core.c:2546
vb2_read+0x3b/0x50 drivers/media/common/videobuf2/videobuf2-core.c:2678
vb2_fop_read+0x20a/0x400
drivers/media/common/videobuf2/videobuf2-v4l2.c:1065
v4l2_read+0x168/0x220 drivers/media/v4l2-core/v4l2-dev.c:317
__vfs_read+0x117/0x9b0 fs/read_write.c:416
vfs_read+0x17f/0x3c0 fs/read_write.c:452
ksys_read+0x101/0x260 fs/read_write.c:578
__do_sys_read fs/read_write.c:588 [inline]
__se_sys_read fs/read_write.c:586 [inline]
__ia32_sys_read+0x71/0xb0 fs/read_write.c:586
do_syscall_32_irqs_on arch/x86/entry/common.c:326 [inline]
do_fast_syscall_32+0x34d/0xfb2 arch/x86/entry/common.c:397
entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139
Freed by task 7614:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xcf/0x230 mm/slab.c:3817
__vb2_cleanup_fileio+0xf8/0x160
drivers/media/common/videobuf2/videobuf2-core.c:2505
vb2_core_queue_release+0x1e/0x80
drivers/media/common/videobuf2/videobuf2-core.c:2228
vb2_queue_release drivers/media/common/videobuf2/videobuf2-v4l2.c:837
[inline]
_vb2_fop_release+0x1d2/0x2b0
drivers/media/common/videobuf2/videobuf2-v4l2.c:1010
vb2_fop_release+0x77/0xc0
drivers/media/common/videobuf2/videobuf2-v4l2.c:1024
vivid_fop_release+0x18e/0x440 drivers/media/platform/vivid/vivid-core.c:474
v4l2_release+0x224/0x3a0 drivers/media/v4l2-core/v4l2-dev.c:456
__fput+0x385/0xa30 fs/file_table.c:278
____fput+0x15/0x20 fs/file_table.c:309
task_work_run+0x1e8/0x2a0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_usermode_loop+0x318/0x380 arch/x86/entry/common.c:166
prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
syscall_return_slowpath arch/x86/entry/common.c:268 [inline]
do_syscall_32_irqs_on arch/x86/entry/common.c:341 [inline]
do_fast_syscall_32+0xcd5/0xfb2 arch/x86/entry/common.c:397
entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139
The buggy address belongs to the object at ffff8801c05aa480
which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 796 bytes inside of
1024-byte region [ffff8801c05aa480, ffff8801c05aa880)
The buggy address belongs to the page:
page:ffffea0007016a80 count:1 mapcount:0 mapping:ffff8801da800ac0 index:0x0
compound_mapcount: 0
flags: 0x2fffc0000010200(slab|head)
raw: 02fffc0000010200 ffffea00073b0b08 ffffea000701e388 ffff8801da800ac0
raw: 0000000000000000 ffff8801c05aa000 0000000100000007 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff8801c05aa680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8801c05aa700: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> ffff8801c05aa780: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8801c05aa800: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8801c05aa880: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================
Tested on:
commit: b00d209241ff Merge tag 'compiler-attributes-for-linus-v4.2..
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=10c1545d400000
kernel config:
https://syzkaller.appspot.com/x/.config?x=8f559fee2fc3375a
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
userspace arch: i386
patch:
https://syzkaller.appspot.com/x/patch.diff?x=13379225400000