Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: out-of-bounds Read in leaf_paste_entries
REISERFS (device loop5): Using tea hash to sort names
REISERFS (device loop5): using 3.5.x disk format
==================================================================
BUG: KASAN: out-of-bounds in memmove include/linux/string.h:421 [inline]
BUG: KASAN: out-of-bounds in leaf_paste_entries+0x453/0x910 fs/reiserfs/lbalance.c:1377
Read of size 18446744073709547488 at addr ffff888054500fbf by task syz-executor.5/8365
CPU: 1 PID: 8365 Comm: syz-executor.5 Not tainted 5.9.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x198/0x1fd lib/dump_stack.c:118
print_address_description.constprop.0.cold+0xae/0x497 mm/kasan/report.c:383
__kasan_report mm/kasan/report.c:513 [inline]
kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
check_memory_region_inline mm/kasan/generic.c:186 [inline]
check_memory_region+0x13d/0x180 mm/kasan/generic.c:192
memmove+0x20/0x60 mm/kasan/common.c:94
memmove include/linux/string.h:421 [inline]
leaf_paste_entries+0x453/0x910 fs/reiserfs/lbalance.c:1377
balance_leaf_finish_node_paste_dirent fs/reiserfs/do_balan.c:1295 [inline]
balance_leaf_finish_node_paste fs/reiserfs/do_balan.c:1321 [inline]
balance_leaf_finish_node fs/reiserfs/do_balan.c:1364 [inline]
balance_leaf+0x915f/0xd320 fs/reiserfs/do_balan.c:1452
do_balance+0x311/0x800 fs/reiserfs/do_balan.c:1888
reiserfs_paste_into_item+0x762/0x8e0 fs/reiserfs/stree.c:2132
reiserfs_add_entry+0x8cb/0xcf0 fs/reiserfs/namei.c:566
reiserfs_mkdir+0x66e/0x980 fs/reiserfs/namei.c:858
create_privroot fs/reiserfs/xattr.c:882 [inline]
reiserfs_xattr_init+0x4de/0xb52 fs/reiserfs/xattr.c:1004
reiserfs_fill_super+0x215d/0x2df3 fs/reiserfs/super.c:2177
mount_bdev+0x32e/0x3f0 fs/super.c:1417
legacy_get_tree+0x105/0x220 fs/fs_context.c:592
vfs_get_tree+0x89/0x2f0 fs/super.c:1547
do_new_mount fs/namespace.c:2875 [inline]
path_mount+0x1387/0x20a0 fs/namespace.c:3192
do_mount fs/namespace.c:3205 [inline]
__do_sys_mount fs/namespace.c:3413 [inline]
__se_sys_mount fs/namespace.c:3390 [inline]
__x64_sys_mount+0x27f/0x300 fs/namespace.c:3390
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4608aa
Code: b8 a6 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 ad 89 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 8a 89 fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007fb93b411a88 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fb93b411b20 RCX: 00000000004608aa
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007fb93b411ae0
RBP: 00007fb93b411ae0 R08: 00007fb93b411b20 R09: 0000000020000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000020000000
R13: 0000000020000100 R14: 0000000020000200 R15: 0000000020000080
The buggy address belongs to the page:
page:00000000729425a0 refcount:2 mapcount:0 mapping:00000000be8e086b index:0x1fc8 pfn:0x54500
aops:def_blk_aops ino:0
flags: 0xfffe0000002032(referenced|lru|active|private)
raw: 00fffe0000002032 ffffea0001513c48 ffffea00015143c8 ffff8880892e3c80
raw: 0000000000001fc8 ffff8880585b43a0 00000002ffffffff ffff8880a9578000
page dumped because: kasan: bad access detected
page->mem_cgroup:ffff8880a9578000
Memory state around the buggy address:
ffff888054500e80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff888054500f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff888054500f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
ffff888054501000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff888054501080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
Tested on:
commit: bbf5c979 Linux 5.9
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=1360d784500000
kernel config:
https://syzkaller.appspot.com/x/.config?x=3d8333c88fe898d7
dashboard link:
https://syzkaller.appspot.com/bug?extid=83b6f7cf9922cae5c4d7
compiler: gcc (GCC) 10.1.0-syz 20200507