[syzbot] BUG: unable to handle kernel NULL pointer dereference in reiserfs_find_entry

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 55be6084c8e0 Merge tag 'timers-core-2022-10-05' of git://g..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14e8a2c2880000
kernel config: https://syzkaller.appspot.com/x/.config?x=c29b6436e994d72e
dashboard link: https://syzkaller.appspot.com/bug?extid=4654552e088ed458b10d
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/c8f5131ab57d/disk-55be6084.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/77167f226f35/vmlinux-55be6084.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+465455...@syzkaller.appspotmail.com

BUG: kernel NULL pointer dereference, address: 0000000000000000
#PF: supervisor instruction fetch in kernel mode
#PF: error_code(0x0010) - not-present page
PGD 793df067 P4D 793df067 PUD 7601a067 PMD 0
Oops: 0010 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 25700 Comm: syz-executor.4 Not tainted 6.0.0-syzkaller-09589-g55be6084c8e0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
RIP: 0010:0x0
Code: Unable to access opcode bytes at 0xffffffffffffffd6.
RSP: 0018:ffffc90003c0f158 EFLAGS: 00010246
RAX: 1ffff11010973c1b RBX: ffff888084b9e0d8 RCX: 0000000000040000
RDX: ffffc9000c01a000 RSI: 0000000000000005 RDI: ffff88801f59f098
RBP: ffffc90003c0f2f0 R08: 0000000000000005 R09: ffffffff8222326d
R10: 0000000000000003 R11: ffff888023308000 R12: ffff888083088678
R13: dffffc0000000000 R14: ffff888037621c10 R15: 0000000000000005
FS: 00007feebdc43700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 0000000036ec7000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
get_third_component fs/reiserfs/namei.c:196 [inline]
reiserfs_find_entry+0x253/0x1a10 fs/reiserfs/namei.c:317
reiserfs_lookup+0x1e3/0x4a0 fs/reiserfs/namei.c:368
__lookup_slow+0x286/0x3e0 fs/namei.c:1685
lookup_slow fs/namei.c:1702 [inline]
lookup_one_unlocked+0x3f8/0x670 fs/namei.c:2772
ovl_lookup_positive_unlocked fs/overlayfs/namei.c:207 [inline]
ovl_lookup_single+0x11f/0xa60 fs/overlayfs/namei.c:233
ovl_lookup_layer+0x44e/0x540 fs/overlayfs/namei.c:320
ovl_lookup+0xb09/0x2470 fs/overlayfs/namei.c:923
__lookup_hash+0x115/0x240 fs/namei.c:1601
do_renameat2+0x58b/0x1400 fs/namei.c:4850
__do_sys_rename fs/namei.c:4953 [inline]
__se_sys_rename fs/namei.c:4951 [inline]
__x64_sys_rename+0x82/0x90 fs/namei.c:4951
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7feebca8b5a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007feebdc43168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007feebcbabf80 RCX: 00007feebca8b5a9
RDX: 0000000000000000 RSI: 0000000020000800 RDI: 00000000200007c0
RBP: 00007feebcae6580 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff2dc3b58f R14: 00007feebdc43300 R15: 0000000000022000
</TASK>
Modules linked in:
CR2: 0000000000000000
---[ end trace 0000000000000000 ]---
RIP: 0010:0x0
Code: Unable to access opcode bytes at 0xffffffffffffffd6.
RSP: 0018:ffffc90003c0f158 EFLAGS: 00010246
RAX: 1ffff11010973c1b RBX: ffff888084b9e0d8 RCX: 0000000000040000
RDX: ffffc9000c01a000 RSI: 0000000000000005 RDI: ffff88801f59f098
RBP: ffffc90003c0f2f0 R08: 0000000000000005 R09: ffffffff8222326d
R10: 0000000000000003 R11: ffff888023308000 R12: ffff888083088678
R13: dffffc0000000000 R14: ffff888037621c10 R15: 0000000000000005
FS: 00007feebdc43700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 0000000036ec7000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: ceaa837f96ad Linux 6.2-rc8
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=121b8ac7480000
kernel config: https://syzkaller.appspot.com/x/.config?x=42ba4da8e1e6af9f
dashboard link: https://syzkaller.appspot.com/bug?extid=4654552e088ed458b10d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15852a00c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10146167480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/88042f9b5fc8/disk-ceaa837f.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9945b57ec9ee/vmlinux-ceaa837f.xz
kernel image: https://storage.googleapis.com/syzbot-assets/72ff118ed96b/bzImage-ceaa837f.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/804b18b8485e/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+465455...@syzkaller.appspotmail.com

REISERFS warning: read_super_block: reiserfs filesystem is deprecated and scheduled to be removed from the kernel in 2025
REISERFS (device loop0): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using r5 hash to sort names
==================================================================
BUG: KASAN: use-after-free in strlen+0x58/0x70 lib/string.c:418
Read of size 1 at addr ffff8880727180c4 by task syz-executor942/5076

CPU: 0 PID: 5076 Comm: syz-executor942 Not tainted 6.2.0-rc8-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:306 [inline]
print_report+0x163/0x4f0 mm/kasan/report.c:417
kasan_report+0x13a/0x170 mm/kasan/report.c:517
strlen+0x58/0x70 lib/string.c:418
set_de_name_and_namelen fs/reiserfs/namei.c:82 [inline]
linear_search_in_dir_item fs/reiserfs/namei.c:262 [inline]
reiserfs_find_entry+0x982/0x19b0 fs/reiserfs/namei.c:331
reiserfs_lookup+0x1ea/0x4b0 fs/reiserfs/namei.c:368
__lookup_slow+0x282/0x3e0 fs/namei.c:1685
lookup_one_len+0x18b/0x2d0 fs/namei.c:2711
reiserfs_lookup_privroot+0x89/0x1e0 fs/reiserfs/xattr.c:973
reiserfs_fill_super+0x195b/0x2620 fs/reiserfs/super.c:2192
mount_bdev+0x271/0x3a0 fs/super.c:1359
legacy_get_tree+0xef/0x190 fs/fs_context.c:610
vfs_get_tree+0x8c/0x270 fs/super.c:1489
do_new_mount+0x28f/0xae0 fs/namespace.c:3145
do_mount fs/namespace.c:3488 [inline]
__do_sys_mount fs/namespace.c:3697 [inline]
__se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3674
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f0deea57d0a
Code: 48 c7 c2 c0 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 a8 00 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe5e115c98 EFLAGS: 00000286 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 000055555718e2c0 RCX: 00007f0deea57d0a
RDX: 00000000200000c0 RSI: 0000000020000040 RDI: 00007ffe5e115ce0
RBP: 0000000000000000 R08: 00007ffe5e115d20 R09: 000000000000111a
R10: 0000000000008001 R11: 0000000000000286 R12: 0000000000000004
R13: 00007ffe5e115d20 R14: 0000000000000003 R15: 00007ffe5e115ce0
</TASK>

The buggy address belongs to the physical page:
page:ffffea0001c9c600 refcount:0 mapcount:0 mapping:0000000000000000 index:0x1 pfn:0x72718
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 ffffea0001c9bec8 ffff8880b9841e20 0000000000000000
raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 0, migratetype Movable, gfp_mask 0x140cca(GFP_HIGHUSER_MOVABLE|__GFP_COMP), pid 5074, tgid 5074 (syz-executor942), ts 68154639328, free_ts 68338552355
prep_new_page mm/page_alloc.c:2531 [inline]
get_page_from_freelist+0x3449/0x35c0 mm/page_alloc.c:4283
__alloc_pages+0x291/0x7e0 mm/page_alloc.c:5549
__folio_alloc+0x13/0x30 mm/page_alloc.c:5581
vma_alloc_folio+0x48a/0x9a0 mm/mempolicy.c:2248
shmem_alloc_folio mm/shmem.c:1569 [inline]
shmem_alloc_and_acct_folio+0x596/0xd40 mm/shmem.c:1593
shmem_get_folio_gfp+0x1408/0x34a0 mm/shmem.c:1920
shmem_get_folio mm/shmem.c:2051 [inline]
shmem_write_begin+0x172/0x4f0 mm/shmem.c:2543
generic_perform_write+0x300/0x5e0 mm/filemap.c:3772
__generic_file_write_iter+0x17a/0x400 mm/filemap.c:3900
generic_file_write_iter+0xaf/0x310 mm/filemap.c:3932
call_write_iter include/linux/fs.h:2189 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x7b2/0xbb0 fs/read_write.c:584
ksys_write+0x1a0/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1446 [inline]
free_pcp_prepare mm/page_alloc.c:1496 [inline]
free_unref_page_prepare+0xf3a/0x1040 mm/page_alloc.c:3369
free_unref_page_list+0x6b1/0x950 mm/page_alloc.c:3510
release_pages+0x219e/0x2470 mm/swap.c:1076
__pagevec_release+0x84/0x100 mm/swap.c:1096
pagevec_release include/linux/pagevec.h:71 [inline]
folio_batch_release include/linux/pagevec.h:135 [inline]
shmem_undo_range+0x6b6/0x1dd0 mm/shmem.c:947
shmem_truncate_range mm/shmem.c:1042 [inline]
shmem_evict_inode+0x258/0x9f0 mm/shmem.c:1151
evict+0x2a4/0x620 fs/inode.c:664
__dentry_kill+0x436/0x650 fs/dcache.c:607
dentry_kill+0xbb/0x290
dput+0x1d8/0x3f0 fs/dcache.c:913
__fput+0x5e4/0x890 fs/file_table.c:328
task_work_run+0x24a/0x300 kernel/task_work.c:179
ptrace_notify+0x2a2/0x350 kernel/signal.c:2354
ptrace_report_syscall include/linux/ptrace.h:411 [inline]
ptrace_report_syscall_exit include/linux/ptrace.h:473 [inline]
syscall_exit_work kernel/entry/common.c:251 [inline]
syscall_exit_to_user_mode_prepare kernel/entry/common.c:278 [inline]
__syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline]
syscall_exit_to_user_mode+0x171/0x2e0 kernel/entry/common.c:296
do_syscall_64+0x4d/0xc0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
ffff888072717f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff888072718000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff888072718080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff888072718100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff888072718180: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <ja...@suse.cz>
Date: Wed Nov 1 17:43:10 2023 +0000

fs: Block writes to mounted block devices

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17e6fb5be80000
start commit: 51f269a6ecc7 Merge tag 'probes-fixes-6.4-rc4' of git://git..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=162cf2103e4a7453
dashboard link: https://syzkaller.appspot.com/bug?extid=4654552e088ed458b10d
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1177c895280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17f4b2a5280000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: Block writes to mounted block devices

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Jan Kara]

On Wed 31-01-24 08:52:05, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 6f861765464f43a71462d52026fbddfc858239a5
> Author: Jan Kara <ja...@suse.cz>
> Date: Wed Nov 1 17:43:10 2023 +0000
>
> fs: Block writes to mounted block devices
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17e6fb5be80000
> start commit: 51f269a6ecc7 Merge tag 'probes-fixes-6.4-rc4' of git://git..
> git tree: upstream
> kernel config: https://syzkaller.appspot.com/x/.config?x=162cf2103e4a7453
> dashboard link: https://syzkaller.appspot.com/bug?extid=4654552e088ed458b10d
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1177c895280000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17f4b2a5280000
>
> If the result looks correct, please mark the issue as fixed by replying with:

Makes sense:

#syz fix: fs: Block writes to mounted block devices

Honza
--
Jan Kara <ja...@suse.com>
SUSE Labs, CR