KASAN: use-after-free Read in link_path_walk

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit: ef78e5ec9214 ia64: export node_distance function
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10bc2415400000
kernel config: https://syzkaller.appspot.com/x/.config?x=c94f9f0c0363db4b
dashboard link: https://syzkaller.appspot.com/bug?extid=fb731ca573367b7f6564
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11116225400000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+fb731c...@syzkaller.appspotmail.com

8021q: adding VLAN 0 to HW filter on device team0
8021q: adding VLAN 0 to HW filter on device team0
audit: type=1400 audit(1543395345.166:38): avc: denied { associate } for
pid=6244 comm="syz-executor3" name="syz3"
scontext=unconfined_u:object_r:unlabeled_t:s0
tcontext=system_u:object_r:unlabeled_t:s0 tclass=filesystem permissive=1
==================================================================
BUG: KASAN: use-after-free in link_path_walk.part.40+0x12e6/0x1530
fs/namei.c:2091
Read of size 1 at addr ffff8881cca65d40 by task syz-executor2/10223

CPU: 1 PID: 10223 Comm: syz-executor2 Not tainted 4.20.0-rc4+ #132
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x244/0x39d lib/dump_stack.c:113
print_address_description.cold.7+0x9/0x1ff mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report.cold.8+0x242/0x309 mm/kasan/report.c:412
__asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:430
link_path_walk.part.40+0x12e6/0x1530 fs/namei.c:2091
link_path_walk fs/namei.c:2269 [inline]
path_lookupat.isra.43+0xf7/0xc00 fs/namei.c:2317
filename_lookup+0x26a/0x520 fs/namei.c:2348
user_path_at_empty+0x40/0x50 fs/namei.c:2608
user_path include/linux/namei.h:62 [inline]
do_mount+0x177/0x31f0 fs/namespace.c:2741
ksys_mount+0x12d/0x140 fs/namespace.c:3017
__do_sys_mount fs/namespace.c:3031 [inline]
__se_sys_mount fs/namespace.c:3028 [inline]
__x64_sys_mount+0xbe/0x150 fs/namespace.c:3028
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x457569
Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fb6416b0c78 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 0000000000457569
RDX: 0000000020000040 RSI: 0000000020000000 RDI: 0000000000000000
RBP: 000000000072bf00 R08: 0000000020000340 R09: 0000000000000000
R10: 0000000000200000 R11: 0000000000000246 R12: 00007fb6416b16d4
R13: 00000000004c2c24 R14: 00000000004d4990 R15: 00000000ffffffff

Allocated by task 10228:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553
__do_kmalloc mm/slab.c:3722 [inline]
__kmalloc_track_caller+0x157/0x760 mm/slab.c:3737
kstrdup+0x39/0x70 mm/util.c:49
bpf_symlink+0x26/0x140 kernel/bpf/inode.c:356
vfs_symlink+0x37a/0x5d0 fs/namei.c:4127
do_symlinkat+0x242/0x2d0 fs/namei.c:4154
__do_sys_symlink fs/namei.c:4173 [inline]
__se_sys_symlink fs/namei.c:4171 [inline]
__x64_sys_symlink+0x59/0x80 fs/namei.c:4171
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 10235:
save_stack+0x43/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3498 [inline]
kfree+0xcf/0x230 mm/slab.c:3817
bpf_evict_inode+0x11f/0x150 kernel/bpf/inode.c:565
evict+0x4b9/0x980 fs/inode.c:558
iput_final fs/inode.c:1550 [inline]
iput+0x679/0xa90 fs/inode.c:1576
do_unlinkat+0x733/0xa30 fs/namei.c:4069
__do_sys_unlink fs/namei.c:4110 [inline]
__se_sys_unlink fs/namei.c:4108 [inline]
__x64_sys_unlink+0x42/0x50 fs/namei.c:4108
do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8881cca65d40
which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes inside of
32-byte region [ffff8881cca65d40, ffff8881cca65d60)
The buggy address belongs to the page:
page:ffffea0007329940 count:1 mapcount:0 mapping:ffff8881da8001c0
index:0xffff8881cca65fc1
flags: 0x2fffc0000000200(slab)
raw: 02fffc0000000200 ffffea000730d6c8 ffffea00075efa48 ffff8881da8001c0
raw: ffff8881cca65fc1 ffff8881cca65000 000000010000003f 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8881cca65c00: fb fb fb fb fc fc fc fc 05 fc fc fc fc fc fc fc
ffff8881cca65c80: fb fb fb fb fc fc fc fc 05 fc fc fc fc fc fc fc
> ffff8881cca65d00: 00 00 01 fc fc fc fc fc fb fb fb fb fc fc fc fc
^
ffff8881cca65d80: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
ffff8881cca65e00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with
syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

syzbot has bisected this bug to:

commit 0f98621bef5d2b7ad41f6595899660af344f5016
Author: Daniel Borkmann <dan...@iogearbox.net>
Date: Sat Oct 29 00:30:46 2016 +0000

bpf, inode: add support for symlinks and fix mtime/ctime

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13c347a3200000
start commit: ef78e5ec ia64: export node_distance function
git tree: upstream
final crash: https://syzkaller.appspot.com/x/report.txt?x=102347a3200000
console output: https://syzkaller.appspot.com/x/log.txt?x=17c347a3200000

kernel config: https://syzkaller.appspot.com/x/.config?x=c94f9f0c0363db4b
dashboard link: https://syzkaller.appspot.com/bug?extid=fb731ca573367b7f6564

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11116225400000

Reported-by: syzbot+fb731c...@syzkaller.appspotmail.com
Fixes: 0f98621bef5d ("bpf, inode: add support for symlinks and fix
mtime/ctime")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger
crash:

Reported-and-tested-by:
syzbot+fb731c...@syzkaller.appspotmail.com

Tested on:

commit: e9879de3 bpf: fix use after free in bpf symlink handling
git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git bpf-fs-fix
kernel config: https://syzkaller.appspot.com/x/.config?x=da4ec73ead779924
compiler: gcc (GCC) 9.0.0 20190115 (experimental)

Note: testing is done by a robot and is best-effort only.