[syzbot] [net?] [virt?] BUG: stack guard page was hit in vsock_bpf_recvmsg

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: eb3ab13d997a net: ti: icssg_prueth: populate netdev of_node
git tree: net-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=16bc9dbd980000
kernel config: https://syzkaller.appspot.com/x/.config?x=e8a2eef9745ade09
dashboard link: https://syzkaller.appspot.com/bug?extid=bdb4bd87b5e22058e2a4
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11d4f4f5980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17522ec5980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/451ec795f57e/disk-eb3ab13d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e6f090c32577/vmlinux-eb3ab13d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ac63cb5127b1/bzImage-eb3ab13d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bdb4bd...@syzkaller.appspotmail.com

BUG: TASK stack guard page was hit at ffffc9000358ff58 (stack is ffffc90003590000..ffffc90003598000)
Oops: stack guard page: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 0 UID: 0 PID: 5231 Comm: syz-executor149 Not tainted 6.11.0-rc2-syzkaller-00271-geb3ab13d997a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024
RIP: 0010:validate_chain+0x1f/0x5900 kernel/locking/lockdep.c:3824
Code: 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 55 48 89 e5 41 57 41 56 41 55 41 54 53 48 83 e4 e0 48 81 ec c0 02 00 00 49 89 ce <89> 54 24 58 48 89 bc 24 80 00 00 00 65 48 8b 04 25 28 00 00 00 48
RSP: 0018:ffffc9000358ff60 EFLAGS: 00010086
RAX: 1ffffffff268c780 RBX: ffffffff93463c00 RCX: 7195f92be3ffb448
RDX: 0000000000000001 RSI: ffff88807cc6c6e0 RDI: ffff88807cc6bc00
RBP: ffffc90003590260 R08: ffffffff9372e8cf R09: 1ffffffff26e5d19
R10: dffffc0000000000 R11: fffffbfff26e5d1a R12: 0000000000000001
R13: ffff88807cc6c6d8 R14: 7195f92be3ffb448 R15: ffff88807cc6c700
FS: 000055556f04f380(0000) GS:ffff8880b9200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffc9000358ff58 CR3: 0000000023e1e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<#DF>
</#DF>
<TASK>
__lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
reacquire_held_locks+0x3eb/0x690 kernel/locking/lockdep.c:5284
__lock_release kernel/locking/lockdep.c:5473 [inline]
lock_release+0x396/0xa30 kernel/locking/lockdep.c:5780
sock_release_ownership include/net/sock.h:1722 [inline]
release_sock+0x12f/0x1f0 net/core/sock.c:3564
vsock_bpf_recvmsg+0x60f/0x1090 net/vmw_vsock/vsock_bpf.c:88
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
vsock_bpf_recvmsg+0xcf5/0x1090
sock_recvmsg_nosec net/socket.c:1046 [inline]
sock_recvmsg+0x22f/0x280 net/socket.c:1068
____sys_recvmsg+0x1db/0x470 net/socket.c:2816
___sys_recvmsg net/socket.c:2858 [inline]
__sys_recvmsg+0x2f0/0x3e0 net/socket.c:2888
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f66591e2c79
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe616028d8 EFLAGS: 00000246 ORIG_RAX: 000000000000002f
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f66591e2c79
RDX: 0000000000010042 RSI: 00000000200003c0 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000000006 R09: 0000000000000006
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 431bde82d7b634db R14: 0000000000000001 R15: 0000000000000001
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:validate_chain+0x1f/0x5900 kernel/locking/lockdep.c:3824
Code: 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 55 48 89 e5 41 57 41 56 41 55 41 54 53 48 83 e4 e0 48 81 ec c0 02 00 00 49 89 ce <89> 54 24 58 48 89 bc 24 80 00 00 00 65 48 8b 04 25 28 00 00 00 48
RSP: 0018:ffffc9000358ff60 EFLAGS: 00010086
RAX: 1ffffffff268c780 RBX: ffffffff93463c00 RCX: 7195f92be3ffb448
RDX: 0000000000000001 RSI: ffff88807cc6c6e0 RDI: ffff88807cc6bc00
RBP: ffffc90003590260 R08: ffffffff9372e8cf R09: 1ffffffff26e5d19
R10: dffffc0000000000 R11: fffffbfff26e5d1a R12: 0000000000000001
R13: ffff88807cc6c6d8 R14: 7195f92be3ffb448 R15: ffff88807cc6c700
FS: 000055556f04f380(0000) GS:ffff8880b9200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffc9000358ff58 CR3: 0000000023e1e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: 90 nop
1: 90 nop
2: 90 nop
3: 90 nop
4: 90 nop
5: 90 nop
6: 90 nop
7: 90 nop
8: 90 nop
9: 90 nop
a: 90 nop
b: f3 0f 1e fa endbr64
f: 55 push %rbp
10: 48 89 e5 mov %rsp,%rbp
13: 41 57 push %r15
15: 41 56 push %r14
17: 41 55 push %r13
19: 41 54 push %r12
1b: 53 push %rbx
1c: 48 83 e4 e0 and $0xffffffffffffffe0,%rsp
20: 48 81 ec c0 02 00 00 sub $0x2c0,%rsp
27: 49 89 ce mov %rcx,%r14
* 2a: 89 54 24 58 mov %edx,0x58(%rsp) <-- trapping instruction
2e: 48 89 bc 24 80 00 00 mov %rdi,0x80(%rsp)
35: 00
36: 65 48 8b 04 25 28 00 mov %gs:0x28,%rax
3d: 00 00
3f: 48 rex.W


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has bisected this issue to:

commit 634f1a7110b439c65fd8a809171c1d2d28bcea6f
Author: Bobby Eshleman <bobby.e...@bytedance.com>
Date: Mon Mar 27 19:11:51 2023 +0000

vsock: support sockmap

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13d3c97d980000
start commit: eb3ab13d997a net: ti: icssg_prueth: populate netdev of_node
git tree: net-next
final oops: https://syzkaller.appspot.com/x/report.txt?x=1033c97d980000
console output: https://syzkaller.appspot.com/x/log.txt?x=17d3c97d980000

kernel config: https://syzkaller.appspot.com/x/.config?x=e8a2eef9745ade09
dashboard link: https://syzkaller.appspot.com/bug?extid=bdb4bd87b5e22058e2a4

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a1b97d980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17e7b2f3980000

Reported-by: syzbot+bdb4bd...@syzkaller.appspotmail.com
Fixes: 634f1a7110b4 ("vsock: support sockmap")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Hillf Danton]

On Fri, 09 Aug 2024 10:42:21 -0700

> syzbot found the following issue on:
>
> HEAD commit: eb3ab13d997a net: ti: icssg_prueth: populate netdev of_node
> git tree: net-next

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17522ec5980000

#syz test net-next eb3ab13d997a

--- x/net/vmw_vsock/vsock_bpf.c
+++ y/net/vmw_vsock/vsock_bpf.c
@@ -77,37 +77,29 @@ static int vsock_bpf_recvmsg(struct sock
size_t len, int flags, int *addr_len)
{
struct sk_psock *psock;
- int copied;
+ int copied = -EAGAIN;

psock = sk_psock_get(sk);
if (unlikely(!psock))
- return __vsock_recvmsg(sk, msg, len, flags);
+ return -EAGAIN;

lock_sock(sk);
- if (vsock_has_data(sk, psock) && sk_psock_queue_empty(psock)) {
- release_sock(sk);
- sk_psock_put(sk, psock);
- return __vsock_recvmsg(sk, msg, len, flags);
- }
+ if (vsock_has_data(sk, psock) && sk_psock_queue_empty(psock))
+ goto out;

copied = sk_msg_recvmsg(sk, psock, msg, len, flags);
while (copied == 0) {
long timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);

- if (!vsock_msg_wait_data(sk, psock, timeo)) {
- copied = -EAGAIN;
+ copied = -EAGAIN;
+ if (!vsock_msg_wait_data(sk, psock, timeo))
+ break;
+ if (sk_psock_queue_empty(psock))
break;
- }
-
- if (sk_psock_queue_empty(psock)) {
- release_sock(sk);
- sk_psock_put(sk, psock);
- return __vsock_recvmsg(sk, msg, len, flags);
- }
-
copied = sk_msg_recvmsg(sk, psock, msg, len, flags);
}

+out:
release_sock(sk);
sk_psock_put(sk, psock);

--

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+bdb4bd...@syzkaller.appspotmail.com
Tested-by: syzbot+bdb4bd...@syzkaller.appspotmail.com

Tested on:

commit: eb3ab13d net: ti: icssg_prueth: populate netdev of_node
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
console output: https://syzkaller.appspot.com/x/log.txt?x=116b1113980000

kernel config: https://syzkaller.appspot.com/x/.config?x=e8a2eef9745ade09
dashboard link: https://syzkaller.appspot.com/bug?extid=bdb4bd87b5e22058e2a4

compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=10c70dd9980000

Note: testing is done by a robot and is best-effort only.

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject: BUG: stack guard page was hit in vsock_bpf_recvmsg
Author: xiyou.w...@gmail.com

#syz test

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in release_sock

------------[ cut here ]------------
WARNING: CPU: 1 PID: 6092 at include/net/sock.h:1718 sock_release_ownership include/net/sock.h:1718 [inline]
WARNING: CPU: 1 PID: 6092 at include/net/sock.h:1718 release_sock+0x194/0x1f0 net/core/sock.c:3564
Modules linked in:
CPU: 1 UID: 0 PID: 6092 Comm: syz.0.15 Not tainted 6.11.0-rc2-syzkaller-00325-gc4e82c025b3f-dirty #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024

RIP: 0010:sock_release_ownership include/net/sock.h:1718 [inline]
RIP: 0010:release_sock+0x194/0x1f0 net/core/sock.c:3564
Code: 01 00 00 00 31 c9 e8 7b 73 f2 f7 eb 05 e8 04 0a 19 f8 4c 89 f7 5b 41 5c 41 5d 41 5e 41 5f 5d e9 32 b9 45 02 e8 ed 09 19 f8 90 <0f> 0b 90 e9 67 ff ff ff e8 df 09 19 f8 4c 89 e7 49 89 db 41 ff d3
RSP: 0018:ffffc9000366fa80 EFLAGS: 00010293
RAX: ffffffff897a6d93 RBX: 0000000000000000 RCX: ffff88801cb81e00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 1ffff11005538250 R08: ffffffff897a6cf6 R09: fffff520006cdf40
R10: dffffc0000000000 R11: fffff520006cdf40 R12: ffff88802a9c1080
R13: dffffc0000000000 R14: ffff88802a9c1240 R15: ffff88802a9c1280
FS: 00007f2597b966c0(0000) GS:ffff8880b9300000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000020000040 CR3: 00000000229fe000 CR4: 00000000003506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:

<TASK>
vsock_connectible_recvmsg+0x7f/0xf0 net/vmw_vsock/af_vsock.c:2308

sock_recvmsg_nosec net/socket.c:1046 [inline]
sock_recvmsg+0x22f/0x280 net/socket.c:1068
____sys_recvmsg+0x1db/0x470 net/socket.c:2816
___sys_recvmsg net/socket.c:2858 [inline]
__sys_recvmsg+0x2f0/0x3e0 net/socket.c:2888
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

RIP: 0033:0x7f2596d779f9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2597b96038 EFLAGS: 00000246 ORIG_RAX: 000000000000002f
RAX: ffffffffffffffda RBX: 00007f2596f05f80 RCX: 00007f2596d779f9

RDX: 0000000000010042 RSI: 00000000200003c0 RDI: 0000000000000005

RBP: 00007f2596de58ee R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000

R13: 0000000000000000 R14: 00007f2596f05f80 R15: 00007fff84f29b48
</TASK>


Tested on:

commit: c4e82c02 net: dsa: microchip: ksz9477: split half-dupl..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=166ef55d980000

kernel config: https://syzkaller.appspot.com/x/.config?x=e8a2eef9745ade09
dashboard link: https://syzkaller.appspot.com/bug?extid=bdb4bd87b5e22058e2a4
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=131902ed980000

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject: Re: [syzbot] [net?] [virt?] BUG: stack guard page was hit in vsock_bpf_recvmsg
Author: xiyou.w...@gmail.com

#syz test

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+bdb4bd...@syzkaller.appspotmail.com
Tested-by: syzbot+bdb4bd...@syzkaller.appspotmail.com

Tested on:

commit: c4e82c02 net: dsa: microchip: ksz9477: split half-dupl..
git tree: net-next

console output: https://syzkaller.appspot.com/x/log.txt?x=108d3f23980000

kernel config: https://syzkaller.appspot.com/x/.config?x=e8a2eef9745ade09
dashboard link: https://syzkaller.appspot.com/bug?extid=bdb4bd87b5e22058e2a4
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=1792e95d980000