[syzbot] [ext4?] possible deadlock in jbd2_log_wait_commit

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1306a9acc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2a637f17a777/disk-e492250d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a9bfdbca6f2d/vmlinux-e492250d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/dc120ec8d398/bzImage-e492250d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9d16c3...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-12944-ge492250d5252 #0 Not tainted
------------------------------------------------------
syz-executor.5/13484 is trying to acquire lock:
ffff88814c5be990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x153/0x4a0 fs/jbd2/journal.c:692

but task is already holding lock:
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline]
ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}:
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689
inode_lock_nested include/linux/fs.h:793 [inline]
ext4_rename fs/ext4/namei.c:3879 [inline]
ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (jbd2_handle){++++}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692
jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133
ext4_rename fs/ext4/namei.c:4014 [inline]
ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);

*** DEADLOCK ***

3 locks held by syz-executor.5/13484:
#0: ffff88814c5ba460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:394
#1: ffff8880764b5440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x186/0x1a0
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline]
#2: ffff888032243628 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193

stack backtrace:
CPU: 0 PID: 13484 Comm: syz-executor.5 Not tainted 6.2.0-syzkaller-12944-ge492250d5252 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669
jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692
jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133
ext4_rename fs/ext4/namei.c:4014 [inline]
ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193
vfs_rename+0xb1b/0xfa0 fs/namei.c:4772
do_renameat2+0xb9b/0x13c0 fs/namei.c:4923
__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]
__x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd61e08c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd61ee4f168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007fd61e1abf80 RCX: 00007fd61e08c0f9
RDX: 0000000000000003 RSI: 0000000020005780 RDI: 0000000000000004
RBP: 00007fd61e0e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000200016c0 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fffc899a5ef R14: 00007fd61ee4f300 R15: 0000000000022000
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
git tree: upstream

console+strace: https://syzkaller.appspot.com/x/log.txt?x=13eff33cc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=ff98a3b3c1aed3ab
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12317df8c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=150109acc80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/50a19d2021d0/disk-e492250d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/eb6e11bcecdf/vmlinux-e492250d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6946b530d74f/bzImage-e492250d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9d16c3...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
6.2.0-syzkaller-12944-ge492250d5252 #0 Not tainted
------------------------------------------------------

syz-executor109/5071 is trying to acquire lock:
ffff88814afd4990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x146/0x430 fs/jbd2/journal.c:689

but task is already holding lock:

ffff888070a4f780 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
ffff888070a4f780 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}:

down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689
inode_lock_nested include/linux/fs.h:793 [inline]
ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879
ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193
vfs_rename+0xef6/0x17a0 fs/namei.c:4772
do_renameat2+0xb62/0xc90 fs/namei.c:4923

__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]

__x64_sys_renameat2+0xe8/0x120 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (jbd2_handle){++++}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]

validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
lock_acquire kernel/locking/lockdep.c:5669 [inline]
lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
jbd2_log_wait_commit+0x17b/0x430 fs/jbd2/journal.c:692
jbd2_journal_stop+0x5f5/0xfd0 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xe2/0x1f0 fs/ext4/ext4_jbd2.c:133
ext4_rename+0x1470/0x26d0 fs/ext4/namei.c:4011
ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193
vfs_rename+0xef6/0x17a0 fs/namei.c:4772
do_renameat2+0xb62/0xc90 fs/namei.c:4923

__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]

__x64_sys_renameat2+0xe8/0x120 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);
lock(&type->i_mutex_dir_key#3/4);
lock(jbd2_handle);

*** DEADLOCK ***

5 locks held by syz-executor109/5071:
#0: ffff88814afd0460 (sb_writers#5){.+.+}-{0:0}, at: do_renameat2+0x37f/0xc90 fs/namei.c:4859
#1: ffff88814afd0748 (&type->s_vfs_rename_key#2){+.+.}-{3:3}, at: lock_rename+0x58/0x280 fs/namei.c:2995
#2: ffff888070a4b680 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#2: ffff888070a4b680 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x136/0x280 fs/namei.c:3006
#3: ffff888070a4e740 (&type->i_mutex_dir_key#3/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#3: ffff888070a4e740 (&type->i_mutex_dir_key#3/2){+.+.}-{3:3}, at: lock_rename+0x16a/0x280 fs/namei.c:3007
#4: ffff888070a4f780 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#4: ffff888070a4f780 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename+0x1924/0x26d0 fs/ext4/namei.c:3879

stack backtrace:
CPU: 0 PID: 5071 Comm: syz-executor109 Not tainted 6.2.0-syzkaller-12944-ge492250d5252 #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]

dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178

check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]

validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
lock_acquire kernel/locking/lockdep.c:5669 [inline]
lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634
jbd2_log_wait_commit+0x17b/0x430 fs/jbd2/journal.c:692
jbd2_journal_stop+0x5f5/0xfd0 fs/jbd2/transaction.c:1959
__ext4_journal_stop+0xe2/0x1f0 fs/ext4/ext4_jbd2.c:133
ext4_rename+0x1470/0x26d0 fs/ext4/namei.c:4011
ext4_rename2+0x1c7/0x270 fs/ext4/namei.c:4193
vfs_rename+0xef6/0x17a0 fs/namei.c:4772
do_renameat2+0xb62/0xc90 fs/namei.c:4923

__do_sys_renameat2 fs/namei.c:4956 [inline]
__se_sys_renameat2 fs/namei.c:4953 [inline]

__x64_sys_renameat2+0xe8/0x120 fs/namei.c:4953
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd5477525c9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe53888c48 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007fd5477960af RCX: 00007fd5477525c9
RDX: 0000000000000004 RSI: 0000000020000140 RDI: 0000000000000004
RBP: 0000000000000000 R08: 0000000000000004 R09: 00007ffe53888c70
R10: 00000000200002c0 R11: 0000000000000246 R12: 00007ffe53888c6c
R13: 00007ffe53888ca0 R14: 00007ffe53888c80 R15: 0000000000000001
</TASK>

[Hillf Danton]

On Tue, 28 Feb 2023 17:46:41 -0800

> HEAD commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
> git tree: upstream

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=150109acc80000

Stop journal without dir inode held.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e492250d5252

--- x/fs/ext4/namei.c
+++ y/fs/ext4/namei.c
@@ -3780,6 +3780,7 @@ static int ext4_rename(struct mnt_idmap
};
int force_reread;
int retval;
+ int old_locked = 0;
struct inode *whiteout = NULL;
int credits;
u8 old_file_type;
@@ -3882,6 +3883,7 @@ static int ext4_rename(struct mnt_idmap
inode_unlock(old.inode);
goto end_rename;
}
+ old_locked = 1;
}
/*
* If we're renaming a file within an inline_data dir and adding or
@@ -4008,13 +4010,11 @@ end_rename:
ext4_orphan_add(handle, whiteout);
}
unlock_new_inode(whiteout);
- ext4_journal_stop(handle);
- iput(whiteout);
- } else {
- ext4_journal_stop(handle);
}
- if (old.dir_bh)
+ if (old_locked)
inode_unlock(old.inode);
+ ext4_journal_stop(handle);
+ iput(whiteout);
release_bh:
brelse(old.dir_bh);
brelse(old.bh);
--

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+9d16c3...@syzkaller.appspotmail.com

Tested on:

commit: e492250d Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=10692674c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
patch: https://syzkaller.appspot.com/x/patch.diff?x=140fceb0c80000

Note: testing is done by a robot and is best-effort only.

[syzbot]

syzbot has bisected this issue to:

commit 0813299c586b175d7edb25f56412c54b812d0379
Author: Jan Kara <ja...@suse.cz>
Date: Thu Jan 26 11:22:21 2023 +0000

ext4: Fix possible corruption when moving a directory

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14845d50c80000
start commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
git tree: upstream
final oops: https://syzkaller.appspot.com/x/report.txt?x=16845d50c80000
console output: https://syzkaller.appspot.com/x/log.txt?x=12845d50c80000

kernel config: https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11d96208c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=176d917f480000

Reported-by: syzbot+9d16c3...@syzkaller.appspotmail.com
Fixes: 0813299c586b ("ext4: Fix possible corruption when moving a directory")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Jan Kara]

Drat, yeah, lockdep is actually right. We should not be grabbing i_rwsem
while having transaction started in ext4_rename(). I'm somewhat surprised
we didn't hit this lockdep warning earlier during the testing. So we need
to move the locking earlier in ext4_rename(). I'll send a patch...

Honza

--
Jan Kara <ja...@suse.com>
SUSE Labs, CR

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

m: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/usb/serial/usbserial.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/usb/serial/ftdi_sio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/bluetooth/hci_uart.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/bluetooth/btqca.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/bluetooth/btsdio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/drivers/bluetooth/btbcm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ppp_generic.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nfc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/can-bcm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/usbserial.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/can-gw.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_dest.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/mac802154.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/cdc-acm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_hop.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/6lowpan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/can-raw.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/rfcomm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/cfg80211.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ieee802154_socket.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_ipv6.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/l2tp_ppp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/diag.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/rfkill.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/slcan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ppp_deflate.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/tipc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/vcan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/slhc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/bluetooth.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ppp_mppe.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/hci_uart.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ieee802154_6lowpan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_mobility.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/mac80211.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/l2tp_core.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/bsd_comp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/hidp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_routing.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/btqca.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/can.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_fragment.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ieee802154.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/pptp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/pppox.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/can-dev.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/libarc4.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/zsmalloc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/btsdio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/ftdi_sio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/8021q.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/nhc_udp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/btbcm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/unstripped/zram.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/diag.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/rfkill.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/slcan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/ppp_deflate.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/tipc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/vcan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/slhc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/bluetooth.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/ppp_mppe.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/hci_uart.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/ieee802154_6lowpan.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/nhc_mobility.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/mac80211.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/l2tp_core.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/lib/crypto/libarc4.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/bsd_comp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/hidp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/nhc_routing.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/btqca.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/can.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/nhc_fragment.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/ieee802154.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/pptp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/pppox.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/can-dev.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/libarc4.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/zsmalloc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/btsdio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/ftdi_sio.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/mm/zsmalloc.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/8021q.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/nhc_udp.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/btbcm.ko': Permission denied
rm: cannot remove './out/bazel/output_user_root/c186719396625f4bf74deeea0ad5a464/execroot/__main__/bazel-out/k8-fastbuild/bin/common/kernel_x86_64/zram.ko': Permission denied
make: *** [Makefile:2030: clean] Error 123


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=153fa6d4c80000


Tested on:

commit: e3645d72 ext4: fix incorrect options show of original ..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git origin

dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler:

patch: https://syzkaller.appspot.com/x/patch.diff?x=1091adbcc80000

[Theodore Ts'o]

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test

[syzbot]

https://syzkaller.appspot.com/x/error.txt?x=11639908c80000


Tested on:

commit: 3c92792d ext4: Fix deadlock during directory rename
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test

dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
compiler:

Note: no patches were applied.

[Aleksandr Nogikh]

Let's try now:

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test

> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bug...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/000000000000833edf05f65a9ab2%40google.com.

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+9d16c3...@syzkaller.appspotmail.com

Tested on:

commit: 3c92792d ext4: Fix deadlock during directory rename
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test

console output: https://syzkaller.appspot.com/x/log.txt?x=14ed8468c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=978f25ae1dab6ba3
dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.