[syzbot] [bcachefs?] kernel BUG in gc_bucket

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 0e1980c40b6e Add linux-next specific files for 20240531
git tree: linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10e91664980000
kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
dashboard link: https://syzkaller.appspot.com/bug?extid=246b47da27f8e7e7d6fb
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11ca95fc980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12a49ef2980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/44fb1d8b5978/disk-0e1980c4.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a66ce5caf0b2/vmlinux-0e1980c4.xz
kernel image: https://storage.googleapis.com/syzbot-assets/8992fc8fe046/bzImage-0e1980c4.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/a886eb704246/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+246b47...@syzkaller.appspotmail.com

bcachefs (loop0): recovering from clean shutdown, journal seq 7
bcachefs (loop0): Doing compatible version upgrade from 1.7: mi_btree_bitmap to 1.9: disk_accounting_v2
running recovery passes: check_allocations
bcachefs (loop0): accounting_read... done
bcachefs (loop0): alloc_read... done
bcachefs (loop0): stripes_read... done
bcachefs (loop0): snapshots_read... done
bcachefs (loop0): check_allocations...
------------[ cut here ]------------
kernel BUG at fs/bcachefs/buckets.h:96!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 1 PID: 5093 Comm: syz-executor366 Not tainted 6.10.0-rc1-next-20240531-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
RIP: 0010:gc_bucket+0x250/0x260 fs/bcachefs/buckets.h:96
Code: 8c e8 34 e1 62 fd e9 29 ff ff ff 89 f9 80 e1 07 fe c1 38 c1 0f 8c 36 ff ff ff e8 9b 71 ec fd e9 2c ff ff ff e8 71 84 86 fd 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 90 90 90 90 90 90
RSP: 0018:ffffc900035be208 EFLAGS: 00010293
RAX: ffffffff840ff77f RBX: 000000000001007c RCX: ffff88807cc70000
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 000000000001007c
RBP: ffff888021e84000 R08: ffffffff840ff6e1 R09: 0000000000000000
R10: ffffc900035befd0 R11: fffff520006b7dfc R12: ffff888053ddd130
R13: ffff888053ddd118 R14: 000000000001007c R15: 0000000000000080
FS: 0000555563627380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055cce0302c88 CR3: 000000007a7f6000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
bch2_gc_alloc_start fs/bcachefs/btree_gc.c:899 [inline]
bch2_check_allocations+0xc63/0xb9d0 fs/bcachefs/btree_gc.c:1109
bch2_run_recovery_pass+0xf0/0x1e0 fs/bcachefs/recovery_passes.c:183
bch2_run_recovery_passes+0x19e/0x820 fs/bcachefs/recovery_passes.c:226
bch2_fs_recovery+0x238b/0x3730 fs/bcachefs/recovery.c:846
bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1017
bch2_fs_open+0xa8d/0xdf0 fs/bcachefs/super.c:2113
bch2_mount fs/bcachefs/fs.c:1908 [inline]
bch2_fs_get_tree+0x75e/0x14d0 fs/bcachefs/fs.c:2069
vfs_get_tree+0x90/0x2a0 fs/super.c:1780
do_new_mount+0x2be/0xb40 fs/namespace.c:3352
do_mount fs/namespace.c:3692 [inline]
__do_sys_mount fs/namespace.c:3898 [inline]
__se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa6effe7dea
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 5e 04 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc6f97a5d8 EFLAGS: 00000282 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffc6f97a5f0 RCX: 00007fa6effe7dea
RDX: 0000000020005d80 RSI: 0000000020005dc0 RDI: 00007ffc6f97a5f0
RBP: 0000000000000004 R08: 00007ffc6f97a630 R09: 0000000000005dff
R10: 0000000000000400 R11: 0000000000000282 R12: 0000000000000400
R13: 00007ffc6f97a630 R14: 0000000000000003 R15: 0000000001000000
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:gc_bucket+0x250/0x260 fs/bcachefs/buckets.h:96
Code: 8c e8 34 e1 62 fd e9 29 ff ff ff 89 f9 80 e1 07 fe c1 38 c1 0f 8c 36 ff ff ff e8 9b 71 ec fd e9 2c ff ff ff e8 71 84 86 fd 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 90 90 90 90 90 90
RSP: 0018:ffffc900035be208 EFLAGS: 00010293
RAX: ffffffff840ff77f RBX: 000000000001007c RCX: ffff88807cc70000
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 000000000001007c
RBP: ffff888021e84000 R08: ffffffff840ff6e1 R09: 0000000000000000
R10: ffffc900035befd0 R11: fffff520006b7dfc R12: ffff888053ddd130
R13: ffff888053ddd118 R14: 000000000001007c R15: 0000000000000080
FS: 0000555563627380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055cce0302c88 CR3: 000000007a7f6000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has bisected this issue to:

commit 228e1c91ae5ec44f38aa8852aa3953005badce82
Author: Kent Overstreet <kent.ov...@linux.dev>
Date: Wed Dec 27 23:31:46 2023 +0000

bcachefs: KEY_TYPE_accounting

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16a17f16980000
start commit: 0e1980c40b6e Add linux-next specific files for 20240531
git tree: linux-next
final oops: https://syzkaller.appspot.com/x/report.txt?x=15a17f16980000
console output: https://syzkaller.appspot.com/x/log.txt?x=11a17f16980000

kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88
dashboard link: https://syzkaller.appspot.com/bug?extid=246b47da27f8e7e7d6fb

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11ca95fc980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12a49ef2980000

Reported-by: syzbot+246b47...@syzkaller.appspotmail.com
Fixes: 228e1c91ae5e ("bcachefs: KEY_TYPE_accounting")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection