[syzbot] [kernel?] WARNING in input_unregister_device (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: e7d3b9f28654 usb: yurex: Fix inconsistent locking bug in y..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=1766e845e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=1dd225f9d04a5286
dashboard link: https://syzkaller.appspot.com/bug?extid=617f4ccb03b9869f6494
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/5bf2bb53c85f/disk-e7d3b9f2.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5f6e5a287ee7/vmlinux-e7d3b9f2.xz
kernel image: https://storage.googleapis.com/syzbot-assets/8259e694a7e3/bzImage-e7d3b9f2.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+617f4c...@syzkaller.appspotmail.com

------------[ cut here ]------------
add_uevent_var: buffer size too small
WARNING: CPU: 0 PID: 2442 at lib/kobject_uevent.c:671 add_uevent_var+0x32d/0x390 lib/kobject_uevent.c:671
Modules linked in:
CPU: 0 PID: 2442 Comm: kworker/0:6 Not tainted 6.7.0-rc5-syzkaller-ge7d3b9f28654 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Workqueue: usb_hub_wq hub_event
RIP: 0010:add_uevent_var+0x32d/0x390 lib/kobject_uevent.c:671
Code: fb 48 c7 c7 c0 7c 4e 87 e8 50 63 d9 fa 0f 0b bb f4 ff ff ff e9 57 ff ff ff e8 0f 24 10 fb 48 c7 c7 60 7d 4e 87 e8 33 63 d9 fa <0f> 0b eb e1 4c 89 ee 48 c7 c7 a0 f5 22 89 e8 b0 d0 12 fc e9 b4 fe
RSP: 0018:ffffc90001daf2b8 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff888108b08000 RCX: ffffc9000c6ad000
RDX: 0000000000040000 RSI: ffffffff811733c6 RDI: 0000000000000001
RBP: ffffc90001daf3a8 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 00000000006559c8 R12: 1ffff920003b5e5a
R13: 00000000000007f5 R14: ffff888108b08218 R15: 00000000000007f5
FS: 0000000000000000(0000) GS:ffff8881f6600000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb1ddf92c98 CR3: 0000000104e44000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
kobject_uevent_env+0x995/0x1800 lib/kobject_uevent.c:588
device_del+0x642/0xa50 drivers/base/core.c:3832
input_unregister_device+0xb9/0x100 drivers/input/input.c:2440
hidinput_disconnect+0x160/0x3e0 drivers/hid/hid-input.c:2388
hid_disconnect+0x143/0x1b0 drivers/hid/hid-core.c:2280
hid_hw_stop+0x16/0x70 drivers/hid/hid-core.c:2329
ms_remove+0x16/0xa0 drivers/hid/hid-microsoft.c:409
hid_device_remove+0xce/0x250 drivers/hid/hid-core.c:2689
device_remove+0xc8/0x170 drivers/base/dd.c:567
__device_release_driver drivers/base/dd.c:1272 [inline]
device_release_driver_internal+0x44a/0x610 drivers/base/dd.c:1295
bus_remove_device+0x22c/0x420 drivers/base/bus.c:574
device_del+0x39a/0xa50 drivers/base/core.c:3814
hid_remove_device drivers/hid/hid-core.c:2867 [inline]
hid_destroy_device+0xe5/0x150 drivers/hid/hid-core.c:2887
usbhid_disconnect+0xa0/0xe0 drivers/hid/usbhid/hid-core.c:1456
usb_unbind_interface+0x1dd/0x8d0 drivers/usb/core/driver.c:461
device_remove drivers/base/dd.c:569 [inline]
device_remove+0x11f/0x170 drivers/base/dd.c:561
__device_release_driver drivers/base/dd.c:1272 [inline]
device_release_driver_internal+0x44a/0x610 drivers/base/dd.c:1295
bus_remove_device+0x22c/0x420 drivers/base/bus.c:574
device_del+0x39a/0xa50 drivers/base/core.c:3814
usb_disable_device+0x36c/0x7f0 drivers/usb/core/message.c:1416
usb_disconnect+0x2e1/0x910 drivers/usb/core/hub.c:2257
hub_port_connect drivers/usb/core/hub.c:5305 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5605 [inline]
port_event drivers/usb/core/hub.c:5765 [inline]
hub_event+0x1be0/0x4f40 drivers/usb/core/hub.c:5847
process_one_work+0x884/0x15c0 kernel/workqueue.c:2627
process_scheduled_works kernel/workqueue.c:2700 [inline]
worker_thread+0x8b9/0x1290 kernel/workqueue.c:2781
kthread+0x33c/0x440 kernel/kthread.c:388
ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: c1ca10ceffbb Merge tag 'scsi-fixes' of git://git.kernel.or..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15159df0180000
kernel config: https://syzkaller.appspot.com/x/.config?x=1d7c92dd8d5c7a1e
dashboard link: https://syzkaller.appspot.com/bug?extid=617f4ccb03b9869f6494
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11f415fc180000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17ecf362180000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/842b77f831b0/disk-c1ca10ce.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/057da06d8a4b/vmlinux-c1ca10ce.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d4382274a169/bzImage-c1ca10ce.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+617f4c...@syzkaller.appspotmail.com

input: HID 045e:07da as /devices/platform/dummy_hcd.0/usb1/1-1/1-1:0.0/0003:045E:07DA.0060/input/input100
microsoft 0003:045E:07DA.0060: input,hidraw0: USB HID v0.00 Device [HID 045e:07da] on usb-dummy_hcd.0-1/input0
usb 1-1: USB disconnect, device number 97

------------[ cut here ]------------
add_uevent_var: buffer size too small

WARNING: CPU: 0 PID: 782 at lib/kobject_uevent.c:671 add_uevent_var+0x2d5/0x450 lib/kobject_uevent.c:671
Modules linked in:
CPU: 0 PID: 782 Comm: kworker/0:2 Not tainted 6.8.0-rc4-syzkaller-00331-gc1ca10ceffbb #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Workqueue: usb_hub_wq hub_event
RIP: 0010:add_uevent_var+0x2d5/0x450 lib/kobject_uevent.c:671
Code: 0f b6 04 27 84 c0 0f 85 28 01 00 00 48 8b 44 24 18 01 18 31 c0 eb 2b e8 09 07 39 f6 90 48 c7 c7 60 e3 c5 8c e8 0c 12 fd f5 90 <0f> 0b 90 90 b8 f4 ff ff ff 49 bc 00 00 00 00 00 fc ff df 4c 8b 6c
RSP: 0018:ffffc90003d3ef20 EFLAGS: 00010246
RAX: 7e434c7b33a2b100 RBX: 00000000000007f5 RCX: ffff88801fd91dc0
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90003d3f050 R08: ffffffff81577992 R09: 1ffff920007a7d84
R10: dffffc0000000000 R11: fffff520007a7d85 R12: 000000000000000b
R13: 000000000000000b R14: 1ffff1100fc77443 R15: 1ffff1100fc77543
FS: 0000000000000000(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007fc10ead20f0 CR3: 000000002db96000 CR4: 00000000003506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

kobject_uevent_env+0x520/0x8f0 lib/kobject_uevent.c:588
device_del+0x812/0xa30 drivers/base/core.c:3832
input_unregister_device+0xa3/0x100 drivers/input/input.c:2440
hidinput_disconnect+0x26c/0x300 drivers/hid/hid-input.c:2388
hid_disconnect drivers/hid/hid-core.c:2280 [inline]
hid_hw_stop+0x75/0x1e0 drivers/hid/hid-core.c:2329
ms_remove+0x23/0xa0 drivers/hid/hid-microsoft.c:409
hid_device_remove+0x225/0x370
device_remove drivers/base/dd.c:567 [inline]
__device_release_driver drivers/base/dd.c:1272 [inline]
device_release_driver_internal+0x4a9/0x7c0 drivers/base/dd.c:1295
bus_remove_device+0x34f/0x420 drivers/base/bus.c:574
device_del+0x580/0xa30 drivers/base/core.c:3814
hid_remove_device drivers/hid/hid-core.c:2867 [inline]
hid_destroy_device+0x68/0x100 drivers/hid/hid-core.c:2887
usbhid_disconnect+0x9e/0xc0 drivers/hid/usbhid/hid-core.c:1456
usb_unbind_interface+0x1d4/0x850 drivers/usb/core/driver.c:461
device_remove drivers/base/dd.c:569 [inline]
__device_release_driver drivers/base/dd.c:1272 [inline]
device_release_driver_internal+0x503/0x7c0 drivers/base/dd.c:1295
bus_remove_device+0x34f/0x420 drivers/base/bus.c:574
device_del+0x580/0xa30 drivers/base/core.c:3814
usb_disable_device+0x3bf/0x850 drivers/usb/core/message.c:1416
usb_disconnect+0x340/0x950 drivers/usb/core/hub.c:2267
hub_port_connect drivers/usb/core/hub.c:5323 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5623 [inline]
port_event drivers/usb/core/hub.c:5783 [inline]
hub_event+0x1e62/0x50f0 drivers/usb/core/hub.c:5865
process_one_work kernel/workqueue.c:2633 [inline]
process_scheduled_works+0x913/0x1420 kernel/workqueue.c:2706
worker_thread+0xa5f/0x1000 kernel/workqueue.c:2787
kthread+0x2ef/0x390 kernel/kthread.c:388
ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1b/0x30 arch/x86/entry/entry_64.S:242
</TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[Edward Adam Davis]

please test oob

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index c30affcc43b4..74b37b6459cd 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -30,7 +30,7 @@

#define UEVENT_HELPER_PATH_LEN 256
#define UEVENT_NUM_ENVP 64 /* number of env pointers */
-#define UEVENT_BUFFER_SIZE 2048 /* buffer for the variables */
+#define UEVENT_BUFFER_SIZE 2304 /* buffer for the variables */

#ifdef CONFIG_UEVENT_HELPER
/* path to the userspace helper executed on an event */

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+617f4c...@syzkaller.appspotmail.com

Tested on:

commit: 603c04e2 Merge tag 'parisc-for-6.8-rc6' of git://git.k..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=16ded6e2180000
kernel config: https://syzkaller.appspot.com/x/.config?x=eff9f3183d0a20dd

dashboard link: https://syzkaller.appspot.com/bug?extid=617f4ccb03b9869f6494
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=14e60122180000

Note: testing is done by a robot and is best-effort only.