Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: use-after-free Read in display_close
==================================================================
BUG: KASAN: use-after-free in __mutex_lock_common+0x11b/0x26e0 kernel/locking/mutex.c:579
Read of size 8 at addr ffff88806ec3c080 by task syz-executor.4/5279
CPU: 1 PID: 5279 Comm: syz-executor.4 Not tainted 5.18.0-rc4-syzkaller-00006-gd615b5416f8a-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_address_description+0x65/0x4b0 mm/kasan/report.c:313
print_report+0xf4/0x210 mm/kasan/report.c:429
kasan_report+0xfb/0x130 mm/kasan/report.c:491
__mutex_lock_common+0x11b/0x26e0 kernel/locking/mutex.c:579
__mutex_lock kernel/locking/mutex.c:733 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:785
display_close+0x53/0x1d0 drivers/media/rc/imon.c:550
__fput+0x3b9/0x820 fs/file_table.c:317
task_work_run+0x146/0x1c0 kernel/task_work.c:164
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0x134/0x160 kernel/entry/common.c:169
exit_to_user_mode_prepare+0xad/0x110 kernel/entry/common.c:201
__syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline]
syscall_exit_to_user_mode+0x2e/0x70 kernel/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7eff0683bd2b
Code: 0f 05 48 3d 00 f0 ff ff 77 45 c3 0f 1f 40 00 48 83 ec 18 89 7c 24 0c e8 63 fc ff ff 8b 7c 24 0c 41 89 c0 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 89 44 24 0c e8 a1 fc ff ff 8b 44
RSP: 002b:00007ffc4436ecd0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000005 RCX: 00007eff0683bd2b
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000004
RBP: 00007eff0699d960 R08: 0000000000000000 R09: 00007eff069a01c0
R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000031ea9
R13: 00007ffc4436edd0 R14: 00007eff0699c030 R15: 0000000000000032
</TASK>
Allocated by task 14:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track mm/kasan/common.c:45 [inline]
set_alloc_info mm/kasan/common.c:436 [inline]
____kasan_kmalloc+0xdc/0x110 mm/kasan/common.c:515
kasan_kmalloc include/linux/kasan.h:234 [inline]
kmem_cache_alloc_trace+0x94/0x310 mm/slub.c:3258
kmalloc include/linux/slab.h:581 [inline]
kzalloc include/linux/slab.h:714 [inline]
imon_init_intf0 drivers/media/rc/imon.c:2209 [inline]
imon_probe+0x1af/0x2ef0 drivers/media/rc/imon.c:2421
usb_probe_interface+0x66e/0xb60 drivers/usb/core/driver.c:396
call_driver_probe+0x96/0x250
really_probe+0x222/0x8e0 drivers/base/dd.c:621
__driver_probe_device+0x1f4/0x3f0 drivers/base/dd.c:752
driver_probe_device+0x50/0x240 drivers/base/dd.c:782
__device_attach_driver+0x254/0x3a0 drivers/base/dd.c:899
bus_for_each_drv+0x18a/0x210 drivers/base/bus.c:427
__device_attach+0x32e/0x570 drivers/base/dd.c:970
bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:487
device_add+0xb20/0xf90 drivers/base/core.c:3405
usb_set_configuration+0x1a5f/0x20e0 drivers/usb/core/message.c:2170
usb_generic_driver_probe+0x83/0x140 drivers/usb/core/generic.c:238
usb_probe_device+0x131/0x260 drivers/usb/core/driver.c:293
call_driver_probe+0x96/0x250
really_probe+0x222/0x8e0 drivers/base/dd.c:621
__driver_probe_device+0x1f4/0x3f0 drivers/base/dd.c:752
driver_probe_device+0x50/0x240 drivers/base/dd.c:782
__device_attach_driver+0x254/0x3a0 drivers/base/dd.c:899
bus_for_each_drv+0x18a/0x210 drivers/base/bus.c:427
__device_attach+0x32e/0x570 drivers/base/dd.c:970
bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:487
device_add+0xb20/0xf90 drivers/base/core.c:3405
usb_new_device+0xbfc/0x18a0 drivers/usb/core/hub.c:2566
hub_port_connect+0x106b/0x2930 drivers/usb/core/hub.c:5363
hub_port_connect_change+0x619/0xbe0 drivers/usb/core/hub.c:5507
port_event+0xe72/0x13a0 drivers/usb/core/hub.c:5665
hub_event+0x5be/0xd70 drivers/usb/core/hub.c:5747
process_one_work+0x81c/0xd10 kernel/workqueue.c:2289
worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
kthread+0x266/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30
Freed by task 14:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track+0x4c/0x70 mm/kasan/common.c:45
kasan_set_free_info+0x1f/0x40 mm/kasan/generic.c:370
____kasan_slab_free+0xd8/0x110 mm/kasan/common.c:366
kasan_slab_free include/linux/kasan.h:200 [inline]
slab_free_hook mm/slub.c:1728 [inline]
slab_free_freelist_hook+0x12e/0x1a0 mm/slub.c:1754
slab_free mm/slub.c:3510 [inline]
kfree+0xc6/0x210 mm/slub.c:4552
free_imon_context drivers/media/rc/imon.c:483 [inline]
imon_disconnect+0x473/0x5d0 drivers/media/rc/imon.c:2527
usb_unbind_interface+0x1f2/0x860 drivers/usb/core/driver.c:458
device_remove drivers/base/dd.c:532 [inline]
__device_release_driver drivers/base/dd.c:1200 [inline]
device_release_driver_internal+0x56b/0x820 drivers/base/dd.c:1223
bus_remove_device+0x2fd/0x410 drivers/base/bus.c:529
device_del+0x6ec/0xbe0 drivers/base/core.c:3592
usb_disable_device+0x3dd/0x820 drivers/usb/core/message.c:1419
usb_disconnect+0x346/0x890 drivers/usb/core/hub.c:2228
hub_port_connect+0x2a2/0x2930 drivers/usb/core/hub.c:5207
hub_port_connect_change+0x619/0xbe0 drivers/usb/core/hub.c:5507
port_event+0xe72/0x13a0 drivers/usb/core/hub.c:5665
hub_event+0x5be/0xd70 drivers/usb/core/hub.c:5747
process_one_work+0x81c/0xd10 kernel/workqueue.c:2289
worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
kthread+0x266/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30
Last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:38
__kasan_record_aux_stack+0xaf/0xc0 mm/kasan/generic.c:348
call_rcu+0x163/0x9c0 kernel/rcu/tree.c:3074
in6_dev_put include/net/addrconf.h:380 [inline]
addrconf_ifdown+0x1799/0x1a00 net/ipv6/addrconf.c:3888
addrconf_notify+0x403/0xf80
notifier_call_chain kernel/notifier.c:84 [inline]
raw_notifier_call_chain+0xe7/0x170 kernel/notifier.c:392
call_netdevice_notifiers_info net/core/dev.c:1938 [inline]
call_netdevice_notifiers_extack net/core/dev.c:1976 [inline]
call_netdevice_notifiers net/core/dev.c:1990 [inline]
unregister_netdevice_many+0xeee/0x1950 net/core/dev.c:10751
unregister_netdevice_queue+0x2e6/0x350 net/core/dev.c:10683
unregister_netdevice include/linux/netdevice.h:2954 [inline]
nsim_destroy+0x44/0x140 drivers/net/netdevsim/netdev.c:382
__nsim_dev_port_del+0x152/0x1b0 drivers/net/netdevsim/dev.c:1427
nsim_dev_port_del_all drivers/net/netdevsim/dev.c:1440 [inline]
nsim_dev_reload_destroy+0x2c2/0x4d0 drivers/net/netdevsim/dev.c:1659
nsim_dev_reload_down+0xfb/0x150 drivers/net/netdevsim/dev.c:962
devlink_reload+0x200/0x6c0 net/core/devlink.c:4070
devlink_pernet_pre_exit+0x1ab/0x350 net/core/devlink.c:11476
ops_pre_exit_list net/core/net_namespace.c:152 [inline]
cleanup_net+0x608/0xc50 net/core/net_namespace.c:582
process_one_work+0x81c/0xd10 kernel/workqueue.c:2289
worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
kthread+0x266/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30
Second to last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:38
__kasan_record_aux_stack+0xaf/0xc0 mm/kasan/generic.c:348
insert_work+0x54/0x3e0 kernel/workqueue.c:1358
__queue_work+0x969/0xc20 kernel/workqueue.c:1517
call_timer_fn+0xf5/0x210 kernel/time/timer.c:1421
expire_timers kernel/time/timer.c:1461 [inline]
__run_timers+0x7a2/0x980 kernel/time/timer.c:1737
run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1750
__do_softirq+0x382/0x793 kernel/softirq.c:558
The buggy address belongs to the object at ffff88806ec3c000
which belongs to the cache kmalloc-2k of size 2048
The buggy address is located 128 bytes inside of
2048-byte region [ffff88806ec3c000, ffff88806ec3c800)
The buggy address belongs to the physical page:
page:ffffea0001bb0e00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x6ec38
head:ffffea0001bb0e00 order:3 compound_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 dead000000000100 dead000000000122 ffff888011042000
raw: 0000000000000000 0000000000080008 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 3597, tgid 3597 (syz-executor.0), ts 50108796928, free_ts 11730170768
prep_new_page mm/page_alloc.c:2441 [inline]
get_page_from_freelist+0x72e/0x7a0 mm/page_alloc.c:4182
__alloc_pages+0x26c/0x5f0 mm/page_alloc.c:5408
alloc_slab_page+0x70/0xf0 mm/slub.c:1799
allocate_slab+0x5e/0x560 mm/slub.c:1944
new_slab mm/slub.c:2004 [inline]
___slab_alloc+0x41e/0xcd0 mm/slub.c:3005
__slab_alloc mm/slub.c:3092 [inline]
slab_alloc_node mm/slub.c:3183 [inline]
slab_alloc mm/slub.c:3225 [inline]
__kmalloc+0x2ba/0x370 mm/slub.c:4410
kmalloc include/linux/slab.h:586 [inline]
kzalloc include/linux/slab.h:714 [inline]
__register_sysctl_table+0xdd/0x1380 fs/proc/proc_sysctl.c:1335
__addrconf_sysctl_register+0x26e/0x3c0 net/ipv6/addrconf.c:7052
addrconf_sysctl_register+0x128/0x180 net/ipv6/addrconf.c:7099
ipv6_add_dev+0xda5/0x12c0 net/ipv6/addrconf.c:450
addrconf_notify+0x629/0xf80 net/ipv6/addrconf.c:3521
notifier_call_chain kernel/notifier.c:84 [inline]
raw_notifier_call_chain+0xe7/0x170 kernel/notifier.c:392
call_netdevice_notifiers_info net/core/dev.c:1938 [inline]
call_netdevice_notifiers_extack net/core/dev.c:1976 [inline]
call_netdevice_notifiers+0x14e/0x1d0 net/core/dev.c:1990
register_netdevice+0x158f/0x19a0 net/core/dev.c:9994
nsim_init_netdevsim drivers/net/netdevsim/netdev.c:317 [inline]
nsim_create+0x349/0x3f0 drivers/net/netdevsim/netdev.c:365
__nsim_dev_port_add+0x6c2/0xb30 drivers/net/netdevsim/dev.c:1390
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1356 [inline]
free_pcp_prepare+0x812/0x900 mm/page_alloc.c:1406
free_unref_page_prepare mm/page_alloc.c:3328 [inline]
free_unref_page+0x7d/0x390 mm/page_alloc.c:3423
free_contig_range+0xa3/0x160 mm/page_alloc.c:9418
destroy_args+0xfe/0x971 mm/debug_vm_pgtable.c:1018
debug_vm_pgtable+0x44c/0x4a5 mm/debug_vm_pgtable.c:1332
do_one_initcall+0xbd/0x2b0 init/main.c:1298
do_initcall_level+0x168/0x218 init/main.c:1371
do_initcalls+0x4b/0x8c init/main.c:1387
kernel_init_freeable+0x43a/0x5c3 init/main.c:1613
kernel_init+0x19/0x2b0 init/main.c:1502
ret_from_fork+0x1f/0x30
Memory state around the buggy address:
ffff88806ec3bf80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88806ec3c000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88806ec3c080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88806ec3c100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88806ec3c180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
Tested on:
commit: d615b541 Merge tag 'f2fs-fix-5.18' of git://git.kernel..
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=1232f89f700000
kernel config:
https://syzkaller.appspot.com/x/.config?x=a935ec57fc0fd0ed
dashboard link:
https://syzkaller.appspot.com/bug?extid=c558267ad910fc494497
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
patch:
https://syzkaller.appspot.com/x/patch.diff?x=13f74658f00000