[syzbot] BUG: unable to handle kernel paging request in take_dentry_name_snapshot

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: b7b275e60bcd Linux 6.1-rc7
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=102c68d5880000
kernel config: https://syzkaller.appspot.com/x/.config?x=cc4b2e0a8e8a8366
dashboard link: https://syzkaller.appspot.com/bug?extid=90392eaed540afcc8fc3
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: i386

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+90392e...@syzkaller.appspotmail.com

REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
overlayfs: upper fs needs to support d_type.
overlayfs: upper fs does not support tmpfile.
BUG: unable to handle page fault for address: fffffffffff8161d
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD c28f067 P4D c28f067 PUD c291067 PMD 0
Oops: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 5330 Comm: syz-executor.1 Not tainted 6.1.0-rc7-syzkaller #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
RIP: 0010:__lock_acquire+0xd8d/0x56d0 kernel/locking/lockdep.c:4925
Code: c8 00 00 00 89 05 73 07 19 0f e9 bd 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 89 f2 48 c1 ea 03 80 3c 02 00 0f 85 4e 31 00 00 <49> 81 3e 60 b5 d2 8f 0f 84 4c f3 ff ff 41 83 fc 01 0f 87 54 f3 ff
RSP: 0018:ffffc9002212f7c8 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: 1ffff92004425f29 RCX: 0000000000000000
RDX: 1fffffffffff02c3 RSI: 0000000000000000 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: fffffbfff1ca3442 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88801c779d40 R14: fffffffffff8161d R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff88802c700000(0063) knlGS:00000000f7f15b40
CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033
CR2: fffffffffff8161d CR3: 000000001b613000 CR4: 0000000000150ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
take_dentry_name_snapshot+0x2b/0x170 fs/dcache.c:315
ovl_check_rename_whiteout fs/overlayfs/super.c:1297 [inline]
ovl_make_workdir fs/overlayfs/super.c:1419 [inline]
ovl_get_workdir fs/overlayfs/super.c:1534 [inline]
ovl_fill_super+0x1ddd/0x6400 fs/overlayfs/super.c:2090
mount_nodev+0x64/0x120 fs/super.c:1447
legacy_get_tree+0x109/0x220 fs/fs_context.c:610
vfs_get_tree+0x8d/0x2f0 fs/super.c:1531
do_new_mount fs/namespace.c:3040 [inline]
path_mount+0x132a/0x1e20 fs/namespace.c:3370
do_mount fs/namespace.c:3383 [inline]
__do_sys_mount fs/namespace.c:3591 [inline]
__se_sys_mount fs/namespace.c:3568 [inline]
__ia32_sys_mount+0x282/0x300 fs/namespace.c:3568
do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
__do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178
do_fast_syscall_32+0x33/0x70 arch/x86/entry/common.c:203
entry_SYSENTER_compat_after_hwframe+0x70/0x82
RIP: 0023:0xf7f1a549
Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00
RSP: 002b:00000000f7f155cc EFLAGS: 00000296 ORIG_RAX: 0000000000000015
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000200000c0
RDX: 0000000020000080 RSI: 0000000000000000 RDI: 0000000020000480
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000296 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
</TASK>
Modules linked in:
CR2: fffffffffff8161d
---[ end trace 0000000000000000 ]---
RIP: 0010:__lock_acquire+0xd8d/0x56d0 kernel/locking/lockdep.c:4925
Code: c8 00 00 00 89 05 73 07 19 0f e9 bd 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 89 f2 48 c1 ea 03 80 3c 02 00 0f 85 4e 31 00 00 <49> 81 3e 60 b5 d2 8f 0f 84 4c f3 ff ff 41 83 fc 01 0f 87 54 f3 ff
RSP: 0018:ffffc9002212f7c8 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: 1ffff92004425f29 RCX: 0000000000000000
RDX: 1fffffffffff02c3 RSI: 0000000000000000 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: fffffbfff1ca3442 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88801c779d40 R14: fffffffffff8161d R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff88802c700000(0063) knlGS:00000000f7f15b40
CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033
CR2: fffffffffff8161d CR3: 000000001b613000 CR4: 0000000000150ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: c8 00 00 00 enterq $0x0,$0x0
4: 89 05 73 07 19 0f mov %eax,0xf190773(%rip) # 0xf19077d
a: e9 bd 00 00 00 jmpq 0xcc
f: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax
16: fc ff df
19: 4c 89 f2 mov %r14,%rdx
1c: 48 c1 ea 03 shr $0x3,%rdx
20: 80 3c 02 00 cmpb $0x0,(%rdx,%rax,1)
24: 0f 85 4e 31 00 00 jne 0x3178
* 2a: 49 81 3e 60 b5 d2 8f cmpq $0xffffffff8fd2b560,(%r14) <-- trapping instruction
31: 0f 84 4c f3 ff ff je 0xfffff383
37: 41 83 fc 01 cmp $0x1,%r12d
3b: 0f .byte 0xf
3c: 87 54 f3 ff xchg %edx,-0x1(%rbx,%rsi,8)


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 8395ae05cb5a Merge tag 'scsi-misc' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1310a5f8480000
kernel config: https://syzkaller.appspot.com/x/.config?x=85327a149d5f50f

dashboard link: https://syzkaller.appspot.com/bug?extid=90392eaed540afcc8fc3
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16199460480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1797f274480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/71f6a8070e91/disk-8395ae05.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/0f742b65488c/vmlinux-8395ae05.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6e5588eaf267/bzImage-8395ae05.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/4673a4f9cbbb/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+90392e...@syzkaller.appspotmail.com

BUG: unable to handle page fault for address: fffffffffff81629

#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page

PGD c48f067 P4D c48f067 PUD c491067 PMD 0

Oops: 0000 [#1] PREEMPT SMP KASAN

CPU: 0 PID: 5251 Comm: syz-executor130 Not tainted 6.1.0-syzkaller-14446-g8395ae05cb5a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022

RIP: 0010:__lock_acquire+0xd8d/0x56d0 kernel/locking/lockdep.c:4925

Code: c8 00 00 00 89 05 83 4e 3c 0f e9 bd 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 89 f2 48 c1 ea 03 80 3c 02 00 0f 85 4e 31 00 00 <49> 81 3e e0 e5 f6 8f 0f 84 4c f3 ff ff 41 83 fc 01 0f 87 54 f3 ff
RSP: 0018:ffffc90004e0f7e8 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: 1ffff920009c1f2d RCX: 0000000000000000
RDX: 1fffffffffff02c5 RSI: 0000000000000000 RDI: 0000000000000001

RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000

R10: fffffbfff1ce5ada R11: 0000000000000000 R12: 0000000000000000
R13: ffff88802c3a1d40 R14: fffffffffff81629 R15: 0000000000000000
FS: 00007fab0371d700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffffffff81629 CR3: 000000006e8d9000 CR4: 0000000000350ef0

Call Trace:
<TASK>
lock_acquire kernel/locking/lockdep.c:5668 [inline]
lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
take_dentry_name_snapshot+0x2b/0x170 fs/dcache.c:315

ovl_check_rename_whiteout fs/overlayfs/super.c:1207 [inline]
ovl_make_workdir fs/overlayfs/super.c:1329 [inline]
ovl_get_workdir fs/overlayfs/super.c:1444 [inline]
ovl_fill_super+0x1dd2/0x6330 fs/overlayfs/super.c:2000
mount_nodev+0x64/0x120 fs/super.c:1405
legacy_get_tree+0x109/0x220 fs/fs_context.c:610
vfs_get_tree+0x8d/0x2f0 fs/super.c:1489
do_new_mount fs/namespace.c:3145 [inline]
path_mount+0x132a/0x1e20 fs/namespace.c:3475
do_mount fs/namespace.c:3488 [inline]
__do_sys_mount fs/namespace.c:3697 [inline]
__se_sys_mount fs/namespace.c:3674 [inline]
__x64_sys_mount+0x283/0x300 fs/namespace.c:3674
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fab03f80209
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 31 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fab0371d208 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fab04005528 RCX: 00007fab03f80209
RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000
RBP: 00007fab04005520 R08: 0000000020000480 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fab0400552c
R13: 00007ffcd399fc6f R14: 00007fab0371d300 R15: 0000000000022000
</TASK>
Modules linked in:
CR2: fffffffffff81629

---[ end trace 0000000000000000 ]---
RIP: 0010:__lock_acquire+0xd8d/0x56d0 kernel/locking/lockdep.c:4925

Code: c8 00 00 00 89 05 83 4e 3c 0f e9 bd 00 00 00 48 b8 00 00 00 00 00 fc ff df 4c 89 f2 48 c1 ea 03 80 3c 02 00 0f 85 4e 31 00 00 <49> 81 3e e0 e5 f6 8f 0f 84 4c f3 ff ff 41 83 fc 01 0f 87 54 f3 ff
RSP: 0018:ffffc90004e0f7e8 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: 1ffff920009c1f2d RCX: 0000000000000000
RDX: 1fffffffffff02c5 RSI: 0000000000000000 RDI: 0000000000000001

RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000

R10: fffffbfff1ce5ada R11: 0000000000000000 R12: 0000000000000000
R13: ffff88802c3a1d40 R14: fffffffffff81629 R15: 0000000000000000
FS: 00007fab0371d700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffffffff81629 CR3: 000000006e8d9000 CR4: 0000000000350ef0

----------------
Code disassembly (best guess):
0: c8 00 00 00 enterq $0x0,$0x0

4: 89 05 83 4e 3c 0f mov %eax,0xf3c4e83(%rip) # 0xf3c4e8d

a: e9 bd 00 00 00 jmpq 0xcc
f: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax
16: fc ff df
19: 4c 89 f2 mov %r14,%rdx
1c: 48 c1 ea 03 shr $0x3,%rdx
20: 80 3c 02 00 cmpb $0x0,(%rdx,%rax,1)
24: 0f 85 4e 31 00 00 jne 0x3178

* 2a: 49 81 3e e0 e5 f6 8f cmpq $0xffffffff8ff6e5e0,(%r14) <-- trapping instruction

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 1784fbc2ed9c888ea4e895f30a53207ed7ee8208
Author: Christian Brauner <bra...@kernel.org>
Date: Fri Jun 16 12:53:58 2023 +0000

ovl: port to new mount api

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12561bd9a80000
start commit: 8395ae05cb5a Merge tag 'scsi-misc' of git://git.kernel.org..
git tree: upstream

kernel config: https://syzkaller.appspot.com/x/.config?x=85327a149d5f50f
dashboard link: https://syzkaller.appspot.com/bug?extid=90392eaed540afcc8fc3

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16199460480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1797f274480000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: ovl: port to new mount api

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Amir Goldstein]

#syz dup: WARNING: locking bug in take_dentry_name_snapshot