[syzbot] kernel BUG in __tlb_remove_page_size (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 4fafd96910ad Add linux-next specific files for 20230203
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15c95b9d480000
kernel config: https://syzkaller.appspot.com/x/.config?x=1d2fba7d42502ca4
dashboard link: https://syzkaller.appspot.com/bug?extid=d87dd8e018fd2cc2528b
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16597573480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=175ecd73480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/348cc2da441a/disk-4fafd969.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e2dedc500f12/vmlinux-4fafd969.xz
kernel image: https://storage.googleapis.com/syzbot-assets/fae710d9ebd8/bzImage-4fafd969.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+d87dd8...@syzkaller.appspotmail.com

destroy_args+0x6c4/0x920 mm/debug_vm_pgtable.c:1023
debug_vm_pgtable+0x242a/0x4640 mm/debug_vm_pgtable.c:1403
do_one_initcall+0x141/0x7d0 init/main.c:1306
do_initcall_level init/main.c:1379 [inline]
do_initcalls init/main.c:1395 [inline]
do_basic_setup init/main.c:1414 [inline]
kernel_init_freeable+0x5ec/0x900 init/main.c:1634
kernel_init+0x1e/0x2c0 init/main.c:1522
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
------------[ cut here ]------------
kernel BUG at mm/mmu_gather.c:139!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 6456 Comm: syz-executor168 Not tainted 6.2.0-rc6-next-20230203-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023
RIP: 0010:__tlb_remove_page_size+0x24c/0x480 mm/mmu_gather.c:139
Code: 01 00 00 8b 6d 0c e9 e1 fe ff ff e8 ae 63 c1 ff 0f 0b e8 a7 63 c1 ff 4c 89 f7 48 c7 c6 c0 77 58 8a 48 83 e7 fc e8 64 0b fa ff <0f> 0b e8 8d 63 c1 ff 4c 8d 6b 24 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffffc9000632f7f0 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffffc9000632fac0 RCX: 0000000000000000
RDX: ffff8880267d9d40 RSI: ffffffff81c3070c RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8e751757
R10: fffffbfff1cea2ea R11: 0000000000000001 R12: 0000000000000000
R13: 0000000000000001 R14: ffffea0001ca6a80 R15: ffffc9000632fae8
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffd97f9a298 CR3: 000000007a9d4000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
tlb_remove_page_size include/asm-generic/tlb.h:466 [inline]
tlb_remove_page+0x12/0x30 include/asm-generic/tlb.h:481
paravirt_tlb_remove_table arch/x86/include/asm/paravirt.h:92 [inline]
___pte_free_tlb+0x123/0x1a0 arch/x86/mm/pgtable.c:57
__pte_free_tlb arch/x86/include/asm/pgalloc.h:61 [inline]
free_pte_range mm/memory.c:179 [inline]
free_pmd_range mm/memory.c:197 [inline]
free_pud_range mm/memory.c:231 [inline]
free_p4d_range mm/memory.c:265 [inline]
free_pgd_range+0x497/0xbf0 mm/memory.c:345
free_pgtables+0x2d6/0x420 mm/memory.c:386
exit_mmap+0x1f3/0x7d0 mm/mmap.c:3045
__mmput+0x128/0x4c0 kernel/fork.c:1209
mmput+0x60/0x70 kernel/fork.c:1231
exit_mm kernel/exit.c:563 [inline]
do_exit+0x9d7/0x2b60 kernel/exit.c:856
do_group_exit+0xd4/0x2a0 kernel/exit.c:1019
get_signal+0x2321/0x25b0 kernel/signal.c:2859
arch_do_signal_or_restart+0x79/0x5c0 arch/x86/kernel/signal.c:306
exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
exit_to_user_mode_prepare+0x11f/0x240 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x1d/0x50 kernel/entry/common.c:297
do_syscall_64+0x46/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f778bef7bb9
Code: Unable to access opcode bytes at 0x7f778bef7b8f.
RSP: 002b:00007f778bea9318 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: fffffffffffffe00 RBX: 00007f778bf7f428 RCX: 00007f778bef7bb9
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00007f778bf7f428
RBP: 00007f778bf7f420 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f778bf4d074
R13: 00007ffd97f9a23f R14: 00007f778bea9400 R15: 0000000000022000
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__tlb_remove_page_size+0x24c/0x480 mm/mmu_gather.c:139
Code: 01 00 00 8b 6d 0c e9 e1 fe ff ff e8 ae 63 c1 ff 0f 0b e8 a7 63 c1 ff 4c 89 f7 48 c7 c6 c0 77 58 8a 48 83 e7 fc e8 64 0b fa ff <0f> 0b e8 8d 63 c1 ff 4c 8d 6b 24 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffffc9000632f7f0 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffffc9000632fac0 RCX: 0000000000000000
RDX: ffff8880267d9d40 RSI: ffffffff81c3070c RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8e751757
R10: fffffbfff1cea2ea R11: 0000000000000001 R12: 0000000000000000
R13: 0000000000000001 R14: ffffea0001ca6a80 R15: ffffc9000632fae8
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f778be88718 CR3: 00000000729f0000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[Hillf Danton]

On Sat, 04 Feb 2023 05:36:39 -0800

> syzbot found the following issue on:
>
> HEAD commit: 4fafd96910ad Add linux-next specific files for 20230203
> git tree: linux-next

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=175ecd73480000

check and flush tlb.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 4fafd96910ad

--- x/mm/mmu_gather.c
+++ y/mm/mmu_gather.c
@@ -135,6 +135,8 @@ bool __tlb_remove_page_size(struct mmu_g
if (!tlb_next_batch(tlb))
return true;
batch = tlb->active;
+ if (batch->nr == batch->max)
+ return true;
}
VM_BUG_ON_PAGE(batch->nr > batch->max, encoded_page_ptr(page));

--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel BUG in __tlb_remove_page_size

do_page_cache_ra mm/readahead.c:300 [inline]
page_cache_ra_order+0x6ec/0xa00 mm/readahead.c:560
ondemand_readahead+0x6b3/0x1080 mm/readahead.c:682
page_cache_async_ra mm/readahead.c:731 [inline]
page_cache_async_ra+0x117/0x150 mm/readahead.c:713
filemap_readahead mm/filemap.c:2572 [inline]
filemap_get_pages+0x6c5/0x16b0 mm/filemap.c:2612
filemap_read+0x315/0xc00 mm/filemap.c:2690
generic_file_read_iter+0x3ad/0x5b0 mm/filemap.c:2836
ext4_file_read_iter+0x1d9/0x690 fs/ext4/file.c:147
__kernel_read+0x2ca/0x830 fs/read_write.c:428
integrity_kernel_read+0x7f/0xb0 security/integrity/iint.c:199
ima_calc_file_hash_tfm+0x2aa/0x3b0 security/integrity/ima/ima_crypto.c:485
page_owner free stack trace missing
------------[ cut here ]------------
kernel BUG at mm/mmu_gather.c:141!

invalid opcode: 0000 [#1] PREEMPT SMP KASAN

CPU: 0 PID: 6123 Comm: rm Not tainted 6.2.0-rc6-next-20230203-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023

RIP: 0010:__tlb_remove_page_size+0x25e/0x490 mm/mmu_gather.c:141
Code: 0f 85 d3 fe ff ff e9 4b ff ff ff e8 9c 63 c1 ff 0f 0b e8 95 63 c1 ff 4c 89 f7 48 c7 c6 c0 77 58 8a 48 83 e7 fc e8 52 0b fa ff <0f> 0b e8 7b 63 c1 ff 4c 8d 6b 24 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffffc9000acef8d8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffffc9000acefcd8 RCX: 0000000000000000
RDX: ffff88807fa50000 RSI: ffffffff81c3071e RDI: 0000000000000000

RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8e751757

R10: fffffbfff1cea2ea R11: 0000000000000000 R12: 0000000000000001
R13: 0000000000000000 R14: ffffea0004ffbec0 R15: ffffc9000acefd00

FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007fa85e158300 CR3: 0000000027f28000 CR4: 00000000003506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

__tlb_remove_page include/asm-generic/tlb.h:472 [inline]
zap_pte_range mm/memory.c:1416 [inline]
zap_pmd_range mm/memory.c:1536 [inline]
zap_pud_range mm/memory.c:1565 [inline]
zap_p4d_range mm/memory.c:1586 [inline]
unmap_page_range+0x1226/0x3ce0 mm/memory.c:1607
unmap_single_vma+0x194/0x2a0 mm/memory.c:1653
unmap_vmas+0x234/0x380 mm/memory.c:1692
exit_mmap+0x190/0x7d0 mm/mmap.c:3036

__mmput+0x128/0x4c0 kernel/fork.c:1209
mmput+0x60/0x70 kernel/fork.c:1231
exit_mm kernel/exit.c:563 [inline]
do_exit+0x9d7/0x2b60 kernel/exit.c:856
do_group_exit+0xd4/0x2a0 kernel/exit.c:1019

__do_sys_exit_group kernel/exit.c:1030 [inline]
__se_sys_exit_group kernel/exit.c:1028 [inline]
__x64_sys_exit_group+0x3e/0x50 kernel/exit.c:1028
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fa85e236309
Code: Unable to access opcode bytes at 0x7fa85e2362df.
RSP: 002b:00007ffca8049e88 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007fa85e324780 RCX: 00007fa85e236309
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffffffffff88 R09: 0000000000000001
R10: 0000000000000005 R11: 0000000000000246 R12: 00007fa85e324780
R13: 0000000000000001 R14: 00007fa85e329c88 R15: 0000000000000000

</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---

RIP: 0010:__tlb_remove_page_size+0x25e/0x490 mm/mmu_gather.c:141
Code: 0f 85 d3 fe ff ff e9 4b ff ff ff e8 9c 63 c1 ff 0f 0b e8 95 63 c1 ff 4c 89 f7 48 c7 c6 c0 77 58 8a 48 83 e7 fc e8 52 0b fa ff <0f> 0b e8 7b 63 c1 ff 4c 8d 6b 24 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffffc9000acef8d8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffffc9000acefcd8 RCX: 0000000000000000
RDX: ffff88807fa50000 RSI: ffffffff81c3071e RDI: 0000000000000000

RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8e751757

R10: fffffbfff1cea2ea R11: 0000000000000000 R12: 0000000000000001
R13: 0000000000000000 R14: ffffea0004ffbec0 R15: ffffc9000acefd00

FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007fa85e158300 CR3: 000000000c56f000 CR4: 00000000003506f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Tested on:

commit: 4fafd969 Add linux-next specific files for 20230203
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
console output: https://syzkaller.appspot.com/x/log.txt?x=10a6ec5d480000

kernel config: https://syzkaller.appspot.com/x/.config?x=1d2fba7d42502ca4
dashboard link: https://syzkaller.appspot.com/bug?extid=d87dd8e018fd2cc2528b
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=1060626b480000

[Hillf Danton]

On Sat, 04 Feb 2023 05:36:39 -0800

> syzbot found the following issue on:
>
> HEAD commit: 4fafd96910ad Add linux-next specific files for 20230203
> git tree: linux-next

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=175ecd73480000

check and flush tlb.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 4fafd96910ad

--- x/mm/mmu_gather.c
+++ y/mm/mmu_gather.c

@@ -26,7 +26,11 @@ static bool tlb_next_batch(struct mmu_ga
batch = tlb->active;
if (batch->next) {
tlb->active = batch->next;
- return true;
+ batch = tlb->active;
+ if (batch->nr < batch->max)
+ return true;
+ else
+ return false;
}

if (tlb->batch_count == MAX_GATHER_BATCH_COUNT)
--

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:

BUG: Bad rss-counter state

BUG: Bad rss-counter state mm:ffff88802bf00900 type:MM_SHMEMPAGES val:1
BUG: non-zero pgtables_bytes on freeing mm: 8192

Tested on:

commit: 4fafd969 Add linux-next specific files for 20230203
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

console output: https://syzkaller.appspot.com/x/log.txt?x=1413c073480000

kernel config: https://syzkaller.appspot.com/x/.config?x=1d2fba7d42502ca4
dashboard link: https://syzkaller.appspot.com/bug?extid=d87dd8e018fd2cc2528b
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=15a4779d480000

[Hillf Danton]

On Sat, 04 Feb 2023 05:36:39 -0800

> syzbot found the following issue on:
>
> HEAD commit: 4fafd96910ad Add linux-next specific files for 20230203
> git tree: linux-next

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=175ecd73480000

Check and flush tlb.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:

INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5557 } 2669 jiffies s: 2801 root: 0x0/T
rcu: blocking rcu_node structures (internal RCU debug):


Tested on:

commit: 837c07cf Merge tag 'powerpc-6.2-4' of git://git.kernel..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=154a4f45480000
kernel config: https://syzkaller.appspot.com/x/.config?x=5ea620bd01d9130d

dashboard link: https://syzkaller.appspot.com/bug?extid=d87dd8e018fd2cc2528b
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=116a0487480000

[David Howells]

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/ iov-fixes

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5549 } 2638 jiffies s: 2817 root: 0x0/T

rcu: blocking rcu_node structures (internal RCU debug):


Tested on:

commit: fab9eebf iov_iter: Kill ITER_PIPE
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/ iov-fixes
console output: https://syzkaller.appspot.com/x/log.txt?x=14e2c6f3480000
kernel config: https://syzkaller.appspot.com/x/.config?x=facc234423e66dc6

dashboard link: https://syzkaller.appspot.com/bug?extid=d87dd8e018fd2cc2528b
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.