[syzbot] WARNING in io_sync_cancel

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 77856d911a8c Merge tag 'arm64-fixes' of git://git.kernel.o..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=102b57e0480000
kernel config: https://syzkaller.appspot.com/x/.config?x=334a10f27a9ee2e0
dashboard link: https://syzkaller.appspot.com/bug?extid=7df055631cd1be4586fd
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14ac9ee7880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=142b36b7880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/84863f051feb/disk-77856d91.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/87614e2a8a26/vmlinux-77856d91.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cb76bad63a90/bzImage-77856d91.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7df055...@syzkaller.appspotmail.com

------------[ cut here ]------------
do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81607e7c>] prepare_to_wait+0x7c/0x380 kernel/sched/wait.c:272
WARNING: CPU: 1 PID: 5096 at kernel/sched/core.c:9908 __might_sleep+0x109/0x160 kernel/sched/core.c:9908
Modules linked in:
CPU: 1 PID: 5096 Comm: syz-executor144 Not tainted 6.1.0-syzkaller-13031-g77856d911a8c #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:__might_sleep+0x109/0x160 kernel/sched/core.c:9908
Code: ac 03 00 48 8d bb b8 16 00 00 48 89 fa 48 c1 ea 03 80 3c 02 00 75 34 48 8b 93 b8 16 00 00 48 c7 c7 80 d6 2b 8a e8 74 f6 5b 08 <0f> 0b e9 75 ff ff ff e8 7b 78 78 00 e9 26 ff ff ff 89 34 24 e8 8e
RSP: 0018:ffffc90003dffad0 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff888022358000 RCX: 0000000000000000
RDX: ffff888022358000 RSI: ffffffff8166707c RDI: fffff520007bff4c
RBP: ffffffff8a2c3500 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000000 R12: 0000000000000244
R13: dffffc0000000000 R14: 00000000fffffffc R15: ffffc90003dffd28
FS: 00007fe7d4cb4700(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fe7d4c93718 CR3: 000000007bdf1000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__mutex_lock_common kernel/locking/mutex.c:580 [inline]
__mutex_lock+0x9f/0x1360 kernel/locking/mutex.c:747
io_sync_cancel+0x590/0x630 io_uring/cancel.c:297
__io_uring_register io_uring/io_uring.c:4130 [inline]
__do_sys_io_uring_register+0x1006/0x1440 io_uring/io_uring.c:4164
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fe7d4d44f09
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe7d4cb41f8 EFLAGS: 00000246 ORIG_RAX: 00000000000001ab
RAX: ffffffffffffffda RBX: 00007fe7d4dcd408 RCX: 00007fe7d4d44f09
RDX: 0000000020000080 RSI: 0000000000000018 RDI: 0000000000000003
RBP: 00007fe7d4dcd400 R08: 00007fe7d4cb4700 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000246 R12: 00007fe7d4dcd40c
R13: 00007ffc08404dcf R14: 00007fe7d4cb4300 R15: 0000000000022000
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[Hillf Danton]

On 20 Dec 2022 22:03:37 -0800

> syzbot found the following issue on:
>
> HEAD commit: 77856d911a8c Merge tag 'arm64-fixes' of git://git.kernel.o..
> git tree: upstream

> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=142b36b7880000

Restore RUNNING before acquiring mutex.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

--- x/io_uring/cancel.c
+++ y/io_uring/cancel.c
@@ -294,6 +294,7 @@ int io_sync_cancel(struct io_ring_ctx *c
mutex_unlock(&ctx->uring_lock);
ret = io_run_task_work_sig(ctx);
if (ret < 0) {
+ finish_wait(&ctx->cq_wait, &wait);
mutex_lock(&ctx->uring_lock);
break;
}
--

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+7df055...@syzkaller.appspotmail.com

Tested on:

commit: b6bb9676 Merge tag 'm68knommu-for-v6.2' of git://git.k..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=12e09a08480000
kernel config: https://syzkaller.appspot.com/x/.config?x=8ca07260bb631fb4

dashboard link: https://syzkaller.appspot.com/bug?extid=7df055631cd1be4586fd
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=17a06d8b880000

Note: testing is done by a robot and is best-effort only.

[Jens Axboe]

On 12/20/22 11:03 PM, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 77856d911a8c Merge tag 'arm64-fixes' of git://git.kernel.o..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=102b57e0480000
> kernel config: https://syzkaller.appspot.com/x/.config?x=334a10f27a9ee2e0
> dashboard link: https://syzkaller.appspot.com/bug?extid=7df055631cd1be4586fd
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14ac9ee7880000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=142b36b7880000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/84863f051feb/disk-77856d91.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/87614e2a8a26/vmlinux-77856d91.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/cb76bad63a90/bzImage-77856d91.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+7df055...@syzkaller.appspotmail.com

#syz test: git://git.kernel.dk/linux.git io_uring-6.2

--
Jens Axboe

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5788 } 2646 jiffies s: 2841 root: 0x0/T
rcu: blocking rcu_node structures (internal RCU debug):


Tested on:

commit: d1f53b3e io_uring/cancel: mark task running before re-..
git tree: git://git.kernel.dk/linux.git io_uring-6.2
console output: https://syzkaller.appspot.com/x/log.txt?x=13634a0f880000
kernel config: https://syzkaller.appspot.com/x/.config?x=2edd87fe5cbdf43f

dashboard link: https://syzkaller.appspot.com/bug?extid=7df055631cd1be4586fd
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.

[Jens Axboe]

On 12/21/22 8:17 AM, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> INFO: rcu detected stall in corrupted
>
> rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5788 } 2646 jiffies s: 2841 root: 0x0/T
> rcu: blocking rcu_node structures (internal RCU debug):

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5778 } 2634 jiffies s: 2893 root: 0x0/T

rcu: blocking rcu_node structures (internal RCU debug):

Tested on:

commit: 071531e9 io_uring/cancel: mark task running before re-..

git tree: git://git.kernel.dk/linux.git io_uring-6.2

console output: https://syzkaller.appspot.com/x/log.txt?x=13042ae8480000

[Jens Axboe]

On 12/21/22 9:10 AM, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> INFO: rcu detected stall in corrupted
>
> rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5778 } 2634 jiffies s: 2893 root: 0x0/T
> rcu: blocking rcu_node structures (internal RCU debug):

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
INFO: rcu detected stall in corrupted

rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5772 } 2680 jiffies s: 2845 root: 0x0/T

rcu: blocking rcu_node structures (internal RCU debug):

Tested on:

commit: 23fffb2f io_uring/cancel: re-grab ctx mutex after fini..

git tree: git://git.kernel.dk/linux.git io_uring-6.2

console output: https://syzkaller.appspot.com/x/log.txt?x=15bf7bf0480000

[Jens Axboe]

On 12/21/22 10:52 PM, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> INFO: rcu detected stall in corrupted
>
> rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { P5772 } 2680 jiffies s: 2845 root: 0x0/T
> rcu: blocking rcu_node structures (internal RCU debug):

Wish there was more of a trace here, but I don't think this is
related to the original issue.

--
Jens Axboe