[syzbot] [netfilter?] net-next test error: WARNING: suspicious RCU usage in _destroy_all_sets

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 5f703ce5c981 net: hsr: Send supervisory frames to HSR netw..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1313bb36980000
kernel config: https://syzkaller.appspot.com/x/.config?x=7266aeba025a54a4
dashboard link: https://syzkaller.appspot.com/bug?extid=cfbe1da5fdfc39efc293
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/739147e76c4b/disk-5f703ce5.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4a1004e7b8ba/vmlinux-5f703ce5.xz
kernel image: https://storage.googleapis.com/syzbot-assets/544a55547eb9/bzImage-5f703ce5.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cfbe1d...@syzkaller.appspotmail.com

=============================
WARNING: suspicious RCU usage
6.10.0-rc3-syzkaller-00655-g5f703ce5c981 #0 Not tainted
-----------------------------
net/netfilter/ipset/ip_set_core.c:1200 suspicious rcu_dereference_protected() usage!

other info that might help us debug this:


rcu_scheduler_active = 2, debug_locks = 1
3 locks held by kworker/u8:8/3913:
#0: ffff888015edd948 ((wq_completion)netns){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3206 [inline]
#0: ffff888015edd948 ((wq_completion)netns){+.+.}-{0:0}, at: process_scheduled_works+0x90a/0x1830 kernel/workqueue.c:3312
#1: ffffc9000c4bfd00 (net_cleanup_work){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3207 [inline]
#1: ffffc9000c4bfd00 (net_cleanup_work){+.+.}-{0:0}, at: process_scheduled_works+0x945/0x1830 kernel/workqueue.c:3312
#2: ffffffff8f5db390 (pernet_ops_rwsem){++++}-{3:3}, at: cleanup_net+0x16a/0xcc0 net/core/net_namespace.c:594

stack backtrace:
CPU: 0 PID: 3913 Comm: kworker/u8:8 Not tainted 6.10.0-rc3-syzkaller-00655-g5f703ce5c981 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024
Workqueue: netns cleanup_net
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
lockdep_rcu_suspicious+0x221/0x340 kernel/locking/lockdep.c:6712
_destroy_all_sets+0x232/0x5f0 net/netfilter/ipset/ip_set_core.c:1200
ip_set_net_exit+0x20/0x50 net/netfilter/ipset/ip_set_core.c:2396
ops_exit_list net/core/net_namespace.c:173 [inline]
cleanup_net+0x802/0xcc0 net/core/net_namespace.c:640
process_one_work kernel/workqueue.c:3231 [inline]
process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312
worker_thread+0x86d/0xd70 kernel/workqueue.c:3393
kthread+0x2f0/0x390 kernel/kthread.c:389
ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject: #syz test: git://blackhole.kfki.hu/nf main
Author: kad...@netfilter.org

#syz test: git://blackhole.kfki.hu/nf main


--
E-mail : kad...@blackhole.kfki.hu, kadlecsi...@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

failed to checkout kernel repo git://blackhole.kfki.hu/nf/main: failed to run ["git" "fetch" "--force" "e800a3db89c700d4929431441d645bfd641d2d3c" "main"]: exit status 128
fatal: unable to look up blackhole.kfki.hu (port 9418) (No address associated with hostname)



Tested on:

commit: [unknown
git tree: git://blackhole.kfki.hu/nf main

kernel config: https://syzkaller.appspot.com/x/.config?x=7266aeba025a54a4
dashboard link: https://syzkaller.appspot.com/bug?extid=cfbe1da5fdfc39efc293
compiler:

Note: no patches were applied.

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject: #syz test: git://blackhole.szhk.kfki.hu/nf main
Author: kad...@netfilter.org

#syz test: git://blackhole.szhk.kfki.hu/nf main

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

net/netfilter/ipset/ip_set_core.c:60:4: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
net/netfilter/ipset/ip_set_core.c:60:9: error: expected ';' after top level declarator
net/netfilter/ipset/ip_set_core.c:235:2: error: call to undeclared function 'ip_set_type_lock'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
net/netfilter/ipset/ip_set_core.c:236:7: error: call to undeclared function 'find_set_type'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
net/netfilter/ipset/ip_set_core.c:240:3: error: call to undeclared function 'ip_set_type_unlock'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
net/netfilter/ipset/ip_set_core.c:246:2: error: call to undeclared function 'ip_set_type_unlock'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
net/netfilter/ipset/ip_set_core.c:905:8: error: unterminated function-like macro invocation
net/netfilter/ipset/ip_set_core.c:2453:69: error: expected expression
net/netfilter/ipset/ip_set_core.c:2453:69: error: expected '}'


Tested on:

commit: 0e728dae netfilter: ipset: Fix suspicious rcu_derefere..
git tree: git://blackhole.szhk.kfki.hu/nf main

kernel config: https://syzkaller.appspot.com/x/.config?x=7266aeba025a54a4
dashboard link: https://syzkaller.appspot.com/bug?extid=cfbe1da5fdfc39efc293

compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

[syzbot]

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+cfbe1d...@syzkaller.appspotmail.com

Tested on:

commit: 0eb94209 netfilter: ipset: Fix suspicious rcu_derefere..

git tree: git://blackhole.szhk.kfki.hu/nf main

kernel config: https://syzkaller.appspot.com/x/.config?x=33d942c3f3616a8f

dashboard link: https://syzkaller.appspot.com/bug?extid=cfbe1da5fdfc39efc293
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

Note: testing is done by a robot and is best-effort only.