general protection fault in qca_setup

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit: d13937116f1e Linux 5.0-rc6
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=143d98a7400000
kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1
dashboard link: https://syzkaller.appspot.com/bug?extid=8c0dbf8843bb75efaa05
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=130894af400000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10799004c00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+8c0dbf...@syzkaller.appspotmail.com

audit: type=1800 audit(1549875669.720:29): pid=7626 uid=0 auid=4294967295
ses=4294967295 subj=_ op=collect_data cause=failed(directio)
comm="startpar" name="rc.local" dev="sda1" ino=2432 res=0
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 1170 Comm: kworker/u5:0 Not tainted 5.0.0-rc6 #67
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: hci0 hci_power_on
RIP: 0010:serdev_device_get_drvdata include/linux/serdev.h:125 [inline]
RIP: 0010:qca_setup+0x134/0x1550 drivers/bluetooth/hci_qca.c:1180
Code: c1 ea 03 80 3c 02 00 0f 85 08 12 00 00 48 b8 00 00 00 00 00 fc ff df
4c 8b 63 08 49 8d bc 24 f8 00 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f
85 d7 11 00 00 4d 8b ac 24 f8 00 00 00 49 8d 85 f0
RSP: 0018:ffff8880a793fa00 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff8880a5f60040 RCX: ffffffff84ecfa52
RDX: 000000000000001f RSI: ffffffff84ee0c01 RDI: 00000000000000f8
RBP: ffff8880a793fb50 R08: ffff8880a79402c0 R09: 0000000000000004
R10: ffffed1011a8306d R11: ffff88808d41836f R12: 0000000000000000
R13: ffff8880906bd400 R14: ffff8880a793fb28 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2a8ce9c000 CR3: 0000000097f45000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
hci_uart_setup+0x1c4/0x490 drivers/bluetooth/hci_ldisc.c:418
hci_dev_do_open+0x67e/0x14b0 net/bluetooth/hci_core.c:1423
hci_power_on+0x10d/0x580 net/bluetooth/hci_core.c:2130
process_one_work+0x98e/0x1790 kernel/workqueue.c:2173
worker_thread+0x98/0xe40 kernel/workqueue.c:2319
kthread+0x357/0x430 kernel/kthread.c:246
ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace fc288de046e877c8 ]---
RIP: 0010:serdev_device_get_drvdata include/linux/serdev.h:125 [inline]
RIP: 0010:qca_setup+0x134/0x1550 drivers/bluetooth/hci_qca.c:1180
Code: c1 ea 03 80 3c 02 00 0f 85 08 12 00 00 48 b8 00 00 00 00 00 fc ff df
4c 8b 63 08 49 8d bc 24 f8 00 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f
85 d7 11 00 00 4d 8b ac 24 f8 00 00 00 49 8d 85 f0
RSP: 0018:ffff8880a793fa00 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff8880a5f60040 RCX: ffffffff84ecfa52
RDX: 000000000000001f RSI: ffffffff84ee0c01 RDI: 00000000000000f8
RBP: ffff8880a793fb50 R08: ffff8880a79402c0 R09: 0000000000000004
R10: ffffed1011a8306d R11: ffff88808d41836f R12: 0000000000000000
R13: ffff8880906bd400 R14: ffff8880a793fb28 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2a8ce9c000 CR3: 0000000097f45000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with
syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

syzbot has bisected this bug to:

commit 0ff252c1976da5d80db1377eb39b551931e61826
Author: Ben Young Tae Kim <yt...@qca.qualcomm.com>
Date: Mon Aug 10 21:24:17 2015 +0000

Bluetooth: hciuart: Add support QCA chipset for UART

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=106c36d7200000
start commit: 0ff252c1 Bluetooth: hciuart: Add support QCA chipset for U..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=146c36d7200000

kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1
dashboard link: https://syzkaller.appspot.com/bug?extid=8c0dbf8843bb75efaa05

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=130894af400000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10799004c00000

Reported-by: syzbot+8c0dbf...@syzkaller.appspotmail.com
Fixes: 0ff252c1 ("Bluetooth: hciuart: Add support QCA chipset for UART")

[syzbot]

syzbot suspects this bug was fixed by commit:

commit b36a1552d7319bbfd5cf7f08726c23c5c66d4f73
Author: Vladis Dronov <vdr...@redhat.com>
Date: Tue Jul 30 09:33:45 2019 +0000

Bluetooth: hci_uart: check for missing tty operations

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1436b32c600000
start commit: d1393711 Linux 5.0-rc6
git tree: upstream

kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1
dashboard link: https://syzkaller.appspot.com/bug?extid=8c0dbf8843bb75efaa05

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=130894af400000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10799004c00000

If the result looks correct, please mark the bug fixed by replying with:

#syz fix: Bluetooth: hci_uart: check for missing tty operations

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Vladis Dronov]

#syz fix: Bluetooth: hci_uart: check for missing tty operations

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer