[syzbot] kernel BUG in rxrpc_put_call

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 60ea6f00c57d net: ipa: correct IPA v4.7 IMEM offset
git tree: net
console+strace: https://syzkaller.appspot.com/x/log.txt?x=160bb222480000
kernel config: https://syzkaller.appspot.com/x/.config?x=46221e8203c7aca6
dashboard link: https://syzkaller.appspot.com/bug?extid=4bb6356bb29d6299360e
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=141826f6480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15a8642c480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2b709f657c2d/disk-60ea6f00.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c5daf24c2f8f/vmlinux-60ea6f00.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0af656112648/bzImage-60ea6f00.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4bb635...@syzkaller.appspotmail.com

rxrpc: Assertion failed - 1(0x1) == 11(0xb) is false
------------[ cut here ]------------
kernel BUG at net/rxrpc/call_object.c:645!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 5073 Comm: syz-executor233 Not tainted 6.2.0-rc2-syzkaller-00227-g60ea6f00c57d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:rxrpc_put_call.cold+0x3c/0x3e net/rxrpc/call_object.c:645
Code: 0b e8 82 51 7e f7 89 de 41 b9 0b 00 00 00 41 b8 0b 00 00 00 48 c7 c1 20 45 76 8b 48 89 f2 48 c7 c7 60 45 76 8b e8 35 06 bd ff <0f> 0b e8 57 51 7e f7 48 c7 c7 80 4f 76 8b e8 22 06 bd ff 0f 0b e8
RSP: 0018:ffffc90003c4f9e8 EFLAGS: 00010282
RAX: 0000000000000034 RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff8880209657c0 RSI: ffffffff8166721c RDI: fffff52000789f2f
RBP: ffff8880760576c0 R08: 0000000000000034 R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000000 R12: 0000000000000012
R13: 0000000000000026 R14: ffff888076057a10 R15: ffff888027b18000
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2cf9db1840 CR3: 000000002b803000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
rxrpc_release_calls_on_socket+0x217/0x2f0 net/rxrpc/call_object.c:624
rxrpc_release_sock net/rxrpc/af_rxrpc.c:886 [inline]
rxrpc_release+0x1ca/0x560 net/rxrpc/af_rxrpc.c:917
__sock_release+0xcd/0x280 net/socket.c:650
sock_close+0x1c/0x20 net/socket.c:1365
__fput+0x27c/0xa90 fs/file_table.c:320
task_work_run+0x16f/0x270 kernel/task_work.c:179
exit_task_work include/linux/task_work.h:38 [inline]
do_exit+0xaa8/0x2950 kernel/exit.c:867
do_group_exit+0xd4/0x2a0 kernel/exit.c:1012
get_signal+0x21c3/0x2450 kernel/signal.c:2859
arch_do_signal_or_restart+0x79/0x5c0 arch/x86/kernel/signal.c:306
exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
exit_to_user_mode_prepare+0x15f/0x250 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x1d/0x50 kernel/entry/common.c:296
do_syscall_64+0x46/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f2cf9d57149
Code: Unable to access opcode bytes at 0x7f2cf9d5711f.
RSP: 002b:00007ffc2b195818 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: fffffffffffffe00 RBX: 0000000000000002 RCX: 00007f2cf9d57149
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000000000003
RBP: 00007ffc2b195830 R08: 0000000000000002 R09: 0000000000000001
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:rxrpc_put_call.cold+0x3c/0x3e net/rxrpc/call_object.c:645
Code: 0b e8 82 51 7e f7 89 de 41 b9 0b 00 00 00 41 b8 0b 00 00 00 48 c7 c1 20 45 76 8b 48 89 f2 48 c7 c7 60 45 76 8b e8 35 06 bd ff <0f> 0b e8 57 51 7e f7 48 c7 c7 80 4f 76 8b e8 22 06 bd ff 0f 0b e8
RSP: 0018:ffffc90003c4f9e8 EFLAGS: 00010282
RAX: 0000000000000034 RBX: 0000000000000001 RCX: 0000000000000000
RDX: ffff8880209657c0 RSI: ffffffff8166721c RDI: fffff52000789f2f
RBP: ffff8880760576c0 R08: 0000000000000034 R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000000 R12: 0000000000000012
R13: 0000000000000026 R14: ffff888076057a10 R15: ffff888027b18000
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2cf9db1840 CR3: 000000002b803000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

syzbot has bisected this issue to:

commit a275da62e8c111b897b9cb73eb91df2f4e475ca5
Author: David Howells <dhow...@redhat.com>
Date: Mon Oct 10 07:45:20 2022 +0000

rxrpc: Create a per-local endpoint receive queue and I/O thread

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12ba382c480000
start commit: 60ea6f00c57d net: ipa: correct IPA v4.7 IMEM offset
git tree: net
final oops: https://syzkaller.appspot.com/x/report.txt?x=11ba382c480000
console output: https://syzkaller.appspot.com/x/log.txt?x=16ba382c480000

kernel config: https://syzkaller.appspot.com/x/.config?x=46221e8203c7aca6
dashboard link: https://syzkaller.appspot.com/bug?extid=4bb6356bb29d6299360e

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=141826f6480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15a8642c480000

Reported-by: syzbot+4bb635...@syzkaller.appspotmail.com
Fixes: a275da62e8c1 ("rxrpc: Create a per-local endpoint receive queue and I/O thread")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[David Howells]

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git

diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c
index 3ded5a24627c..f3c9f0201c15 100644
--- a/net/rxrpc/call_object.c
+++ b/net/rxrpc/call_object.c
@@ -294,7 +294,7 @@ static void rxrpc_put_call_slot(struct rxrpc_call *call)
static int rxrpc_connect_call(struct rxrpc_call *call, gfp_t gfp)
{
struct rxrpc_local *local = call->local;
- int ret = 0;
+ int ret = -ENOMEM;

_enter("{%d,%lx},", call->debug_id, call->user_call_ID);

[syzbot]

> #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git

want 2 args (repo, branch), got 5

[David Howells]

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git master

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+4bb635...@syzkaller.appspotmail.com

Tested on:

commit: 8fed7565 Merge tag 'mlx5-fixes-2023-01-09' of git://gi..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=13b40d1c480000

kernel config: https://syzkaller.appspot.com/x/.config?x=46221e8203c7aca6
dashboard link: https://syzkaller.appspot.com/bug?extid=4bb6356bb29d6299360e

compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=11834e5a480000

Note: testing is done by a robot and is best-effort only.