[syzbot] general protection fault in gfs2_dump_glock

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 6f38be8f2ccd Merge tag 'docs-5.17' of git://git.lwn.net/li..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16707bbfb00000
kernel config: https://syzkaller.appspot.com/x/.config?x=b584f9cb7739d39
dashboard link: https://syzkaller.appspot.com/bug?extid=c6fd14145e2f62ca0784
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c6fd14...@syzkaller.appspotmail.com

gfs2: fsid=syz:syz.0: fatal: filesystem consistency error
RG = 20
function = compute_bitstructs, file = fs/gfs2/rgrp.c, line = 828
general protection fault, probably for non-canonical address 0xdffffc0000000012: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000090-0x0000000000000097]
CPU: 2 PID: 6932 Comm: syz-executor.0 Not tainted 5.16.0-syzkaller #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
RIP: 0010:gfs2_dump_glock+0xaa/0x1b00 fs/gfs2/glock.c:2392
Code: f3 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 a8 02 00 00 31 c0 e8 a4 58 10 fe 49 8d bf 90 00 00 00 48 89 f8 48 c1 e8 03 <80> 3c 28 00 0f 85 0c 18 00 00 49 8b 87 90 00 00 00 49 8d 7f 10 48
RSP: 0018:ffffc900040c7178 EFLAGS: 00010206
RAX: 0000000000000012 RBX: 0000000000000001 RCX: ffffc9000ba89000
RDX: 0000000000040000 RSI: ffffffff83666e0c RDI: 0000000000000090
RBP: dffffc0000000000 R08: 0000000000000086 R09: 0000000000000000
R10: ffffffff815db79e R11: 0000000000000000 R12: ffffffff89f76b60
R13: ffffffff89f75ec0 R14: 000000000000033c R15: 0000000000000000
FS: 00007f524eebd700(0000) GS:ffff88802cc00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005555569e5708 CR3: 000000004a185000 CR4: 0000000000150ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
gfs2_consist_rgrpd_i+0x134/0x1b0 fs/gfs2/util.c:479
compute_bitstructs fs/gfs2/rgrp.c:828 [inline]
read_rindex_entry+0xe8c/0x12f0 fs/gfs2/rgrp.c:925
gfs2_ri_update+0x73/0x570 fs/gfs2/rgrp.c:999
gfs2_rindex_update+0x41c/0x4a0 fs/gfs2/rgrp.c:1049
init_inodes+0x1ed6/0x2720 fs/gfs2/ops_fstype.c:914
gfs2_fill_super+0x1b49/0x28a0 fs/gfs2/ops_fstype.c:1244
get_tree_bdev+0x440/0x760 fs/super.c:1295
gfs2_get_tree+0x4a/0x270 fs/gfs2/ops_fstype.c:1327
vfs_get_tree+0x89/0x2f0 fs/super.c:1500
do_new_mount fs/namespace.c:2988 [inline]
path_mount+0x1320/0x1fa0 fs/namespace.c:3318
do_mount fs/namespace.c:3331 [inline]
__do_sys_mount fs/namespace.c:3539 [inline]
__se_sys_mount fs/namespace.c:3516 [inline]
__x64_sys_mount+0x27f/0x300 fs/namespace.c:3516
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f52505493ea
Code: 48 c7 c2 bc ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f524eebcf88 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000020000200 RCX: 00007f52505493ea
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007f524eebcfe0
RBP: 00007f524eebd020 R08: 00007f524eebd020 R09: 0000000020000000
R10: 0000000000000000 R11: 0000000000000206 R12: 0000000020000000
R13: 0000000020000100 R14: 00007f524eebcfe0 R15: 00000000200001c0
</TASK>
Modules linked in:
---[ end trace 9fee23b764ba8831 ]---
RIP: 0010:gfs2_dump_glock+0xaa/0x1b00 fs/gfs2/glock.c:2392
Code: f3 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 a8 02 00 00 31 c0 e8 a4 58 10 fe 49 8d bf 90 00 00 00 48 89 f8 48 c1 e8 03 <80> 3c 28 00 0f 85 0c 18 00 00 49 8b 87 90 00 00 00 49 8d 7f 10 48
RSP: 0018:ffffc900040c7178 EFLAGS: 00010206
RAX: 0000000000000012 RBX: 0000000000000001 RCX: ffffc9000ba89000
RDX: 0000000000040000 RSI: ffffffff83666e0c RDI: 0000000000000090
RBP: dffffc0000000000 R08: 0000000000000086 R09: 0000000000000000
R10: ffffffff815db79e R11: 0000000000000000 R12: ffffffff89f76b60
R13: ffffffff89f75ec0 R14: 000000000000033c R15: 0000000000000000
FS: 00007f524eebd700(0000) GS:ffff88802cc00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005555569e5708 CR3: 000000004a185000 CR4: 0000000000150ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: f3 f3 f3 f3 65 48 8b repz repz repz repz mov %gs:0x28,%rax
7: 04 25 28 00 00 00
d: 48 89 84 24 a8 02 00 mov %rax,0x2a8(%rsp)
14: 00
15: 31 c0 xor %eax,%eax
17: e8 a4 58 10 fe callq 0xfe1058c0
1c: 49 8d bf 90 00 00 00 lea 0x90(%r15),%rdi
23: 48 89 f8 mov %rdi,%rax
26: 48 c1 e8 03 shr $0x3,%rax
* 2a: 80 3c 28 00 cmpb $0x0,(%rax,%rbp,1) <-- trapping instruction
2e: 0f 85 0c 18 00 00 jne 0x1840
34: 49 8b 87 90 00 00 00 mov 0x90(%r15),%rax
3b: 49 8d 7f 10 lea 0x10(%r15),%rdi
3f: 48 rex.W


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: faf68e3523c2 Merge tag 'kbuild-fixes-v6.1-4' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16c3fb9b880000
kernel config: https://syzkaller.appspot.com/x/.config?x=8d01b6e3197974dd
dashboard link: https://syzkaller.appspot.com/bug?extid=c6fd14145e2f62ca0784
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10fa1ce3880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1092ed73880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3bfa6577f378/disk-faf68e35.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/7bf0af58cde3/vmlinux-faf68e35.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3e15d7d640b0/bzImage-faf68e35.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/e69d0b505238/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c6fd14...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: stack-out-of-bounds in gfs2_dump_glock+0x1537/0x1b60
Read of size 8 at addr ffffc9000493fcc0 by task syz-executor301/4070

CPU: 0 PID: 4070 Comm: syz-executor301 Not tainted 6.1.0-rc6-syzkaller-00315-gfaf68e3523c2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
print_address_description+0x74/0x340 mm/kasan/report.c:284
print_report+0x107/0x1f0 mm/kasan/report.c:395
kasan_report+0xcd/0x100 mm/kasan/report.c:495
gfs2_dump_glock+0x1537/0x1b60
gfs2_consist_inode_i+0xf3/0x110 fs/gfs2/util.c:465
gfs2_dirent_scan+0x535/0x650 fs/gfs2/dir.c:602
gfs2_dirent_search+0x2ea/0xb10 fs/gfs2/dir.c:850
gfs2_dir_search+0x8c/0x2a0 fs/gfs2/dir.c:1650
gfs2_lookupi+0x465/0x650 fs/gfs2/inode.c:323
__gfs2_lookup+0x8c/0x260 fs/gfs2/inode.c:870
__lookup_slow+0x266/0x3a0 fs/namei.c:1685
lookup_slow+0x53/0x70 fs/namei.c:1702
walk_component+0x2e1/0x410 fs/namei.c:1993
lookup_last fs/namei.c:2450 [inline]
path_lookupat+0x17d/0x450 fs/namei.c:2474
filename_lookup+0x274/0x650 fs/namei.c:2503
user_path_at_empty+0x40/0x1a0 fs/namei.c:2876
do_readlinkat+0x10c/0x3d0 fs/stat.c:468
__do_sys_readlink fs/stat.c:501 [inline]
__se_sys_readlink fs/stat.c:498 [inline]
__x64_sys_readlink+0x7b/0x90 fs/stat.c:498
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fc648229e99
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 31 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fc648189208 EFLAGS: 00000246 ORIG_RAX: 0000000000000059
RAX: ffffffffffffffda RBX: 00007fc6482c0568 RCX: 00007fc648229e99
RDX: 0000000000000047 RSI: 0000000020000140 RDI: 0000000020000000
RBP: 00007fc6482c0560 R08: 00007fc648189700 R09: 0000000000000000
R10: 00007fc648189700 R11: 0000000000000246 R12: 00007fc6482c056c
R13: 00007ffc15b2f1ff R14: 00007fc648189300 R15: 0000000000022000
</TASK>

The buggy address belongs to the virtual mapping at
[ffffc90004938000, ffffc90004941000) created by:
dup_task_struct+0x8b/0x490 kernel/fork.c:974

The buggy address belongs to the physical page:
page:ffffea000073ed00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1cfb4
memcg:ffff8881481da382
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 0000000000000000 dead000000000122 0000000000000000
raw: 0000000000000000 0000000000000000 00000001ffffffff ffff8881481da382
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x102dc2(GFP_HIGHUSER|__GFP_NOWARN|__GFP_ZERO), pid 4055, tgid 4055 (syz-executor301), ts 493360110858, free_ts 493203659028
prep_new_page mm/page_alloc.c:2539 [inline]
get_page_from_freelist+0x742/0x7c0 mm/page_alloc.c:4291
__alloc_pages+0x259/0x560 mm/page_alloc.c:5558
vm_area_alloc_pages mm/vmalloc.c:2975 [inline]
__vmalloc_area_node mm/vmalloc.c:3043 [inline]
__vmalloc_node_range+0x8f4/0x1290 mm/vmalloc.c:3213
alloc_thread_stack_node+0x307/0x500 kernel/fork.c:311
dup_task_struct+0x8b/0x490 kernel/fork.c:974
copy_process+0x637/0x4000 kernel/fork.c:2084
kernel_clone+0x21b/0x620 kernel/fork.c:2671
__do_sys_clone kernel/fork.c:2812 [inline]
__se_sys_clone kernel/fork.c:2796 [inline]
__x64_sys_clone+0x228/0x290 kernel/fork.c:2796
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1459 [inline]
free_pcp_prepare+0x80c/0x8f0 mm/page_alloc.c:1509
free_unref_page_prepare mm/page_alloc.c:3387 [inline]
free_unref_page_list+0xb4/0x7b0 mm/page_alloc.c:3529
release_pages+0x232a/0x25c0 mm/swap.c:1055
__pagevec_release+0x7d/0xf0 mm/swap.c:1075
pagevec_release include/linux/pagevec.h:71 [inline]
folio_batch_release include/linux/pagevec.h:135 [inline]
truncate_inode_pages_range+0x472/0x17f0 mm/truncate.c:373
kill_bdev block/bdev.c:76 [inline]
blkdev_flush_mapping+0x153/0x2c0 block/bdev.c:662
blkdev_put_whole block/bdev.c:693 [inline]
blkdev_put+0x4a5/0x730 block/bdev.c:953
deactivate_locked_super+0xa7/0xf0 fs/super.c:332
cleanup_mnt+0x494/0x520 fs/namespace.c:1186
task_work_run+0x243/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0x124/0x150 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb2/0x140 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x26/0x60 kernel/entry/common.c:296
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
ffffc9000493fb80: 00 00 00 00 f1 f1 f1 f1 00 00 00 00 00 00 00 00
ffffc9000493fc00: 00 f2 f2 f2 f2 f2 00 f2 f2 f2 00 00 00 00 00 00
>ffffc9000493fc80: 00 00 00 00 00 00 00 00 f3 f3 f3 f3 00 00 00 00
^
ffffc9000493fd00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffffc9000493fd80: f1 f1 f1 f1 04 f3 f3 f3 00 00 00 00 00 00 00 00
==================================================================