[syzbot] WARNING in component_del

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: a33f5c380c4b Merge tag 'xfs-5.17-merge-3' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17c4eb7fb00000
kernel config: https://syzkaller.appspot.com/x/.config?x=dc846445c1d2060e
dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
compiler: Debian clang version 11.0.1-2, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+60df06...@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 11050 at drivers/base/component.c:767 component_del+0xe2/0x480 drivers/base/component.c:765
Modules linked in:
CPU: 1 PID: 11050 Comm: syz-executor.5 Not tainted 5.16.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:component_del+0xe2/0x480 drivers/base/component.c:767
Code: 03 fd 48 8b 6d 00 4c 39 ed 74 07 e8 88 bc b7 fc eb 86 e8 81 bc b7 fc eb 05 e8 7a bc b7 fc 48 c7 c7 20 16 29 8d e8 be b5 47 05 <0f> 0b 31 ed 48 89 ef 48 83 c4 20 5b 41 5c 41 5d 41 5e 41 5f 5d e9
RSP: 0018:ffffc90004a97550 EFLAGS: 00010246
RAX: c095017d97055900 RBX: ffff888023b8b6b0 RCX: ffffffff8d291620
RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffffc90004a974c0
RBP: ffffffff8d291720 R08: dffffc0000000000 R09: fffff52000952e99
R10: fffff52000952e99 R11: 0000000000000000 R12: dffffc0000000000
R13: ffffffff8d291720 R14: ffffffff8b27aea0 R15: ffff88807ac5a008
FS: 00007f5f620ee700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2eb22000 CR3: 000000007da2d000 CR4: 00000000003526e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
usb_hub_remove_port_device+0x1bf/0x2d0 drivers/usb/core/port.c:653
hub_disconnect+0x171/0x480 drivers/usb/core/hub.c:1737
usb_unbind_interface+0x1f2/0x860 drivers/usb/core/driver.c:458
__device_release_driver drivers/base/dd.c:1206 [inline]
device_release_driver_internal+0x523/0x7b0 drivers/base/dd.c:1237
proc_ioctl+0x53c/0x640 drivers/usb/core/devio.c:2332
proc_ioctl_default drivers/usb/core/devio.c:2375 [inline]
usbdev_do_ioctl drivers/usb/core/devio.c:2731 [inline]
usbdev_ioctl+0x3f4a/0x6d00 drivers/usb/core/devio.c:2791
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xfb/0x170 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f5f637dbfe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5f620ee168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f5f638ef1d0 RCX: 00007f5f637dbfe9
RDX: 0000000020000380 RSI: 00000000c0105512 RDI: 0000000000000005
RBP: 00007f5f6383608d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffef2b2329f R14: 00007f5f620ee300 R15: 0000000000022000
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=130a0c2c700000
kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+60df06...@syzkaller.appspotmail.com

------------[ cut here ]------------

WARNING: CPU: 0 PID: 3598 at drivers/base/component.c:767 component_del+0x40c/0x540 drivers/base/component.c:765
Modules linked in:
CPU: 0 PID: 3598 Comm: syz-executor255 Not tainted 5.17.0-rc3-syzkaller-00020-g555f3d7be91a #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

RIP: 0010:component_del+0x40c/0x540 drivers/base/component.c:767
Code: 00 48 39 6b 20 75 82 e8 72 b1 07 fd 48 c7 43 20 00 00 00 00 e9 70 ff ff ff e8 60 b1 07 fd 48 c7 c7 20 aa 67 8c e8 84 d4 db 04 <0f> 0b 31 ed e8 4b b1 07 fd 48 89 ef 5b 5d 41 5c 41 5d 41 5e 41 5f
RSP: 0018:ffffc90001aafa68 EFLAGS: 00010286
RAX: 0000000000000000 RBX: dffffc0000000000 RCX: ffff8880745c8000
RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffc90001aaf9b0
RBP: ffffffff8c67a9e0 R08: 0000000000000001 R09: ffffc90001aaf9b7
R10: fffff52000355f36 R11: 0000000000000001 R12: ffff88801dce5008
R13: ffffffff8a4c0dc0 R14: ffff88801dce5008 R15: ffff88801dce5000
FS: 0000555556461300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007fb3739a5130 CR3: 000000001996f000 CR4: 0000000000350ef0
Call Trace:
<TASK>
usb_hub_remove_port_device+0x272/0x370 drivers/usb/core/port.c:653
hub_disconnect+0x171/0x510 drivers/usb/core/hub.c:1737
usb_unbind_interface+0x1d8/0x8e0 drivers/usb/core/driver.c:458
__device_release_driver+0x5d7/0x700 drivers/base/dd.c:1206
device_release_driver_internal drivers/base/dd.c:1237 [inline]
device_release_driver+0x26/0x40 drivers/base/dd.c:1260
usb_driver_release_interface+0x102/0x180 drivers/usb/core/driver.c:627
proc_ioctl.part.0+0x4d6/0x560 drivers/usb/core/devio.c:2332
proc_ioctl drivers/usb/core/devio.c:170 [inline]

proc_ioctl_default drivers/usb/core/devio.c:2375 [inline]
usbdev_do_ioctl drivers/usb/core/devio.c:2731 [inline]

usbdev_ioctl+0x2b29/0x36c0 drivers/usb/core/devio.c:2791

vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]

__se_sys_ioctl fs/ioctl.c:860 [inline]
__x64_sys_ioctl+0x193/0x200 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7fb3739346f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff3db9d808 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fb373978194 RCX: 00007fb3739346f9
RDX: 0000000020000380 RSI: 00000000c0105512 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007fff3db9d280 R09: 0000000000000001
R10: 000000000000ffff R11: 0000000000000246 R12: 00007fff3db9d81c
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
</TASK>

[syzbot]

syzbot has bisected this issue to:

commit 8c67d06f3fd9639c44d8147483fb1c132d71388f
Author: Heikki Krogerus <heikki....@linux.intel.com>
Date: Thu Dec 23 08:23:49 2021 +0000

usb: Link the ports to the connectors they are attached to

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14063168700000
start commit: 555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
git tree: upstream
final oops: https://syzkaller.appspot.com/x/report.txt?x=16063168700000
console output: https://syzkaller.appspot.com/x/log.txt?x=12063168700000

kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000

Reported-by: syzbot+60df06...@syzkaller.appspotmail.com
Fixes: 8c67d06f3fd9 ("usb: Link the ports to the connectors they are attached to")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Daniel Vetter]

On Mon, Feb 07, 2022 at 11:51:29PM -0800, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=130a0c2c700000
> kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
> dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+60df06...@syzkaller.appspotmail.com

From a quick grep usb seems to have indeed gained some component code, and
I'm not aware of any drm usb drivers using component. So I think this is
an usb issue, not a drm one.

Greg, thoughts?
-Daniel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[Pavel Skripkin]

Hi Daniel,

On 2/8/22 15:30, Daniel Vetter wrote:
> On Mon, Feb 07, 2022 at 11:51:29PM -0800, syzbot wrote:
>> syzbot has found a reproducer for the following issue on:
>>
>> HEAD commit: 555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
>> git tree: upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=130a0c2c700000

(*)

>> kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
>> dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+60df06...@syzkaller.appspotmail.com
>
> From a quick grep usb seems to have indeed gained some component code, and
> I'm not aware of any drm usb drivers using component. So I think this is
> an usb issue, not a drm one.
>

It looks like missing error handling. syzbot injected allocation failure
inside component_add(), but usb_hub_create_port_device() just prints
warn message in case of component_add() failure (see log (*))

And then calling component_del() on non-added item causes WARN_ON()

Can't prove my thoughts, since there is no repro :(




With regards,
Pavel Skripkin

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+60df06...@syzkaller.appspotmail.com

Tested on:

commit: 555f3d7b Merge tag '5.17-rc3-ksmbd-server-fixes' of gi..
git tree: upstream

kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45
dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

patch: https://syzkaller.appspot.com/x/patch.diff?x=111f7428700000

Note: testing is done by a robot and is best-effort only.

[Heikki Krogerus]

I'm guessing the component_add() is failing in this case. So I guess
we need to consider the component_add() failures fatal in
drivers/usb/core/port.c, which is a bit of a bummer. I'll send the
fix.

--
heikki

[Pavel Skripkin]

Hi Heikki,

Seems something similar to your approach is already posted

https://lore.kernel.org/linux-usb/20220208170048.247...@gmail.com/




With regards,
Pavel Skripkin

[Heikki Krogerus]

Ah, thanks! That one seems to leave the peer links, so it's broken...

Br,

--
heikki