[Android 5.10] KASAN: use-after-free Read in binder_release_work

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 6a01908517df Merge branch 'android13-5.10' into android13-..
git tree: android13-5.10-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=165f335f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=4b4a7b8638c3099
dashboard link: https://syzkaller.appspot.com/bug?extid=daf1be78da58d8269198
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=114bfea7980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15840ce8580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9100b9d1982e/disk-6a019085.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8d9180196ec0/vmlinux-6a019085.xz
kernel image: https://storage.googleapis.com/syzbot-assets/42120346c50b/bzImage-6a019085.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+daf1be...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: use-after-free in __list_del_entry_valid+0x2f/0x120 lib/list_debug.c:46
Read of size 8 at addr ffff88810c9f9488 by task kworker/1:1/25

CPU: 1 PID: 25 Comm: kworker/1:1 Not tainted 5.10.226-syzkaller-00001-g6a01908517df #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Workqueue: events binder_deferred_func
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack_lvl+0x1e2/0x24b lib/dump_stack.c:118
print_address_description+0x81/0x3b0 mm/kasan/report.c:248
__kasan_report mm/kasan/report.c:435 [inline]
kasan_report+0x179/0x1c0 mm/kasan/report.c:452
__asan_report_load8_noabort+0x14/0x20 mm/kasan/report_generic.c:309
__list_del_entry_valid+0x2f/0x120 lib/list_debug.c:46
__list_del_entry include/linux/list.h:132 [inline]
list_del_init include/linux/list.h:204 [inline]
binder_dequeue_work_head_ilocked drivers/android/binder.c:515 [inline]
binder_release_work+0xcd/0x680 drivers/android/binder.c:5126
binder_deferred_release drivers/android/binder.c:6278 [inline]
binder_deferred_func+0x1847/0x1bc0 drivers/android/binder.c:6313
process_one_work+0x6dc/0xbd0 kernel/workqueue.c:2301
worker_thread+0xaea/0x1510 kernel/workqueue.c:2447
kthread+0x34b/0x3d0 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

Allocated by task 290:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track mm/kasan/common.c:45 [inline]
set_alloc_info mm/kasan/common.c:430 [inline]
____kasan_kmalloc+0xdb/0x110 mm/kasan/common.c:509
__kasan_kmalloc+0x9/0x10 mm/kasan/common.c:518
kasan_kmalloc include/linux/kasan.h:254 [inline]
kmem_cache_alloc_trace+0x18a/0x2e0 mm/slub.c:2974
kmalloc include/linux/slab.h:552 [inline]
kzalloc include/linux/slab.h:664 [inline]
binder_request_freeze_notification drivers/android/binder.c:3867 [inline]
binder_thread_write+0x9ce/0x6c70 drivers/android/binder.c:4495
binder_ioctl_write_read+0x216/0x6a80 drivers/android/binder.c:5411
binder_ioctl+0x314/0x1e00 drivers/android/binder.c:5727
vfs_ioctl fs/ioctl.c:48 [inline]
__do_sys_ioctl fs/ioctl.c:753 [inline]
__se_sys_ioctl+0x114/0x190 fs/ioctl.c:739
__x64_sys_ioctl+0x7b/0x90 fs/ioctl.c:739
do_syscall_64+0x34/0x70
entry_SYSCALL_64_after_hwframe+0x61/0xcb

Freed by task 25:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:45
kasan_set_free_info+0x23/0x40 mm/kasan/generic.c:370
____kasan_slab_free+0x121/0x160 mm/kasan/common.c:362
__kasan_slab_free+0x11/0x20 mm/kasan/common.c:370
kasan_slab_free include/linux/kasan.h:220 [inline]
slab_free_hook mm/slub.c:1595 [inline]
slab_free_freelist_hook+0xc0/0x190 mm/slub.c:1621
slab_free mm/slub.c:3203 [inline]
kfree+0xc3/0x270 mm/slub.c:4191
binder_free_ref+0x128/0x260 drivers/android/binder.c:1453
binder_deferred_release drivers/android/binder.c:6273 [inline]
binder_deferred_func+0x171c/0x1bc0 drivers/android/binder.c:6313
process_one_work+0x6dc/0xbd0 kernel/workqueue.c:2301
worker_thread+0xaea/0x1510 kernel/workqueue.c:2447
kthread+0x34b/0x3d0 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

The buggy address belongs to the object at ffff88810c9f9480
which belongs to the cache kmalloc-64 of size 64
The buggy address is located 8 bytes inside of
64-byte region [ffff88810c9f9480, ffff88810c9f94c0)
The buggy address belongs to the page:
page:ffffea0004327e40 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x10c9f9
flags: 0x4000000000000200(slab)
raw: 4000000000000200 ffffea000430a300 0000001300000013 ffff888100043800
raw: 0000000000000000 0000000080200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY), pid 67, ts 3719652083, free_ts 3706482158
set_page_owner include/linux/page_owner.h:35 [inline]
post_alloc_hook mm/page_alloc.c:2456 [inline]
prep_new_page+0x166/0x180 mm/page_alloc.c:2462
get_page_from_freelist+0x2d8c/0x2f30 mm/page_alloc.c:4254
__alloc_pages_nodemask+0x435/0xaf0 mm/page_alloc.c:5348
allocate_slab mm/slub.c:1808 [inline]
new_slab+0x80/0x400 mm/slub.c:1869
new_slab_objects mm/slub.c:2627 [inline]
___slab_alloc+0x302/0x4b0 mm/slub.c:2791
__slab_alloc+0x63/0xa0 mm/slub.c:2831
slab_alloc_node mm/slub.c:2913 [inline]
slab_alloc mm/slub.c:2955 [inline]
kmem_cache_alloc_trace+0x1bd/0x2e0 mm/slub.c:2972
kmalloc include/linux/slab.h:552 [inline]
load_elf_binary+0x1ac5/0x2750 fs/binfmt_elf.c:910
search_binary_handler fs/exec.c:1728 [inline]
exec_binprm fs/exec.c:1769 [inline]
bprm_execve+0x81b/0x1600 fs/exec.c:1845
do_execveat_common+0x959/0xac0 fs/exec.c:1956
do_execve fs/exec.c:2026 [inline]
__do_sys_execve fs/exec.c:2102 [inline]
__se_sys_execve fs/exec.c:2097 [inline]
__x64_sys_execve+0x92/0xb0 fs/exec.c:2097
do_syscall_64+0x34/0x70
entry_SYSCALL_64_after_hwframe+0x61/0xcb
page last free stack trace:
reset_page_owner include/linux/page_owner.h:28 [inline]
free_pages_prepare mm/page_alloc.c:1349 [inline]
free_pcp_prepare mm/page_alloc.c:1421 [inline]
free_unref_page_prepare+0x2ae/0x2d0 mm/page_alloc.c:3336
free_unref_page mm/page_alloc.c:3391 [inline]
free_the_page+0x9e/0x370 mm/page_alloc.c:5407
__free_pages+0x67/0xc0 mm/page_alloc.c:5418
__vunmap+0x7bc/0x8f0 mm/vmalloc.c:2301
free_work+0x5b/0x80 mm/vmalloc.c:69
process_one_work+0x6dc/0xbd0 kernel/workqueue.c:2301
worker_thread+0xaea/0x1510 kernel/workqueue.c:2447
kthread+0x34b/0x3d0 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

Memory state around the buggy address:
ffff88810c9f9380: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff88810c9f9400: 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc fc
>ffff88810c9f9480: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
^
ffff88810c9f9500: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff88810c9f9580: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
==================================================================
general protection fault, probably for non-canonical address 0xfefffc1e80000003: 0000 [#1] PREEMPT SMP KASAN
KASAN: maybe wild-memory-access in range [0xf80000f400000018-0xf80000f40000001f]
CPU: 1 PID: 25 Comm: kworker/1:1 Tainted: G B 5.10.226-syzkaller-00001-g6a01908517df #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Workqueue: events binder_deferred_func
RIP: 0010:__list_del_entry_valid+0x75/0x120 lib/list_debug.c:59
Code: 1e 48 85 db 74 68 4d 85 ff 74 74 48 ba 00 01 00 00 00 00 ad de 48 39 d3 74 76 48 83 c2 22 49 39 d7 74 7e 4c 89 f8 48 c1 e8 03 <42> 80 3c 20 00 74 08 4c 89 ff e8 9c 9a 51 ff 49 8b 17 4c 39 f2 75
RSP: 0018:ffffc900001afc20 EFLAGS: 00010a06
RAX: 1f00001e80000003 RBX: ffff88810c140500 RCX: ffffffff8256ad19
RDX: dead000000000122 RSI: 0000000000000286 RDI: ffff88810c9f9480
RBP: ffffc900001afc40 R08: ffffffff813e2a7b R09: 0000000000000003
R10: fffffbfff0e10e48 R11: dffffc0000000001 R12: dffffc0000000000
R13: ffff88810c9f9480 R14: ffff88810c9f9480 R15: f80000f400000019
FS: 0000000000000000(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fab952ba0d0 CR3: 000000010d1ce000 CR4: 00000000003506a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
__list_del_entry include/linux/list.h:132 [inline]
list_del_init include/linux/list.h:204 [inline]
binder_dequeue_work_head_ilocked drivers/android/binder.c:515 [inline]
binder_release_work+0xcd/0x680 drivers/android/binder.c:5126
binder_deferred_release drivers/android/binder.c:6278 [inline]
binder_deferred_func+0x1847/0x1bc0 drivers/android/binder.c:6313
process_one_work+0x6dc/0xbd0 kernel/workqueue.c:2301
worker_thread+0xaea/0x1510 kernel/workqueue.c:2447
kthread+0x34b/0x3d0 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
Modules linked in:
---[ end trace 18b1bc2e15668d4d ]---
RIP: 0010:__list_del_entry_valid+0x75/0x120 lib/list_debug.c:59
Code: 1e 48 85 db 74 68 4d 85 ff 74 74 48 ba 00 01 00 00 00 00 ad de 48 39 d3 74 76 48 83 c2 22 49 39 d7 74 7e 4c 89 f8 48 c1 e8 03 <42> 80 3c 20 00 74 08 4c 89 ff e8 9c 9a 51 ff 49 8b 17 4c 39 f2 75
RSP: 0018:ffffc900001afc20 EFLAGS: 00010a06
RAX: 1f00001e80000003 RBX: ffff88810c140500 RCX: ffffffff8256ad19
RDX: dead000000000122 RSI: 0000000000000286 RDI: ffff88810c9f9480
RBP: ffffc900001afc40 R08: ffffffff813e2a7b R09: 0000000000000003
R10: fffffbfff0e10e48 R11: dffffc0000000001 R12: dffffc0000000000
R13: ffff88810c9f9480 R14: ffff88810c9f9480 R15: f80000f400000019
FS: 0000000000000000(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fab952ba0d0 CR3: 000000000660f000 CR4: 00000000003506a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess), 1 bytes skipped:
0: 48 85 db test %rbx,%rbx
3: 74 68 je 0x6d
5: 4d 85 ff test %r15,%r15
8: 74 74 je 0x7e
a: 48 ba 00 01 00 00 00 movabs $0xdead000000000100,%rdx
11: 00 ad de
14: 48 39 d3 cmp %rdx,%rbx
17: 74 76 je 0x8f
19: 48 83 c2 22 add $0x22,%rdx
1d: 49 39 d7 cmp %rdx,%r15
20: 74 7e je 0xa0
22: 4c 89 f8 mov %r15,%rax
25: 48 c1 e8 03 shr $0x3,%rax
* 29: 42 80 3c 20 00 cmpb $0x0,(%rax,%r12,1) <-- trapping instruction
2e: 74 08 je 0x38
30: 4c 89 ff mov %r15,%rdi
33: e8 9c 9a 51 ff call 0xff519ad4
38: 49 8b 17 mov (%r15),%rdx
3b: 4c 39 f2 cmp %r14,%rdx
3e: 75 .byte 0x75


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.