[Android 5.10] general protection fault in vfs_rename

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: a27512601c2d Merge 5.10.194 into android13-5.10-lts
git tree: android13-5.10-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=117c3bc5680000
kernel config: https://syzkaller.appspot.com/x/.config?x=c1c2ce51f851d2f6
dashboard link: https://syzkaller.appspot.com/bug?extid=09b752dc0e5d19163145
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14718e91680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=168876b1680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/da4c10f4a7cd/disk-a2751260.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4d65589a1227/vmlinux-a2751260.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a8c5b14df758/bzImage-a2751260.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+09b752...@syzkaller.appspotmail.com

general protection fault, probably for non-canonical address 0xdffffc0000000008: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000040-0x0000000000000047]
CPU: 1 PID: 310 Comm: syz-executor384 Not tainted 5.10.194-syzkaller-00508-ga27512601c2d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
RIP: 0010:vfs_rename+0x103/0xda0 fs/namei.c:4376
Code: c1 e8 03 42 80 3c 20 00 74 08 48 89 df e8 e5 09 f4 ff 48 8b 03 48 89 44 24 48 4c 89 74 24 20 4d 8d 7e 30 4d 89 fe 49 c1 ee 03 <43> 80 3c 26 00 74 08 4c 89 ff e8 be 09 f4 ff 49 8b 07 48 89 44 24
RSP: 0018:ffffc90000b57ba0 EFLAGS: 00010202
RAX: ffff88811c4dc000 RBX: ffff88811c49a360 RCX: ffff88811e70e2c0
RDX: ffff88811e70e2c0 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc90000b57cf0 R08: ffffffff81b3eaac R09: 0000000000000000
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: ffff88811c4de880 R14: 0000000000000008 R15: 0000000000000040
FS: 00007fb5681616c0(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb56811fd58 CR3: 000000011e256000 CR4: 00000000003506a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
do_renameat2+0x88d/0x1130 fs/namei.c:4605
__do_sys_rename fs/namei.c:4656 [inline]
__se_sys_rename fs/namei.c:4654 [inline]
__x64_sys_rename+0x86/0x90 fs/namei.c:4654
do_syscall_64+0x34/0x70
entry_SYSCALL_64_after_hwframe+0x61/0xc6
RIP: 0033:0x7fb5681a1069
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb568161218 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007fb568231408 RCX: 00007fb5681a1069
RDX: 00007fb5681a1069 RSI: 0000000020000140 RDI: 0000000020000100
RBP: 00007fb568231400 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fb5681fe114
R13: 0030656c69662f2e R14: 00007fb5681f8045 R15: 00007fb5681fc110
Modules linked in:
---[ end trace b8aeb2cba33e1144 ]---
RIP: 0010:vfs_rename+0x103/0xda0 fs/namei.c:4376
Code: c1 e8 03 42 80 3c 20 00 74 08 48 89 df e8 e5 09 f4 ff 48 8b 03 48 89 44 24 48 4c 89 74 24 20 4d 8d 7e 30 4d 89 fe 49 c1 ee 03 <43> 80 3c 26 00 74 08 4c 89 ff e8 be 09 f4 ff 49 8b 07 48 89 44 24
RSP: 0018:ffffc90000b57ba0 EFLAGS: 00010202
RAX: ffff88811c4dc000 RBX: ffff88811c49a360 RCX: ffff88811e70e2c0
RDX: ffff88811e70e2c0 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc90000b57cf0 R08: ffffffff81b3eaac R09: 0000000000000000
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: ffff88811c4de880 R14: 0000000000000008 R15: 0000000000000040
FS: 00007fb5681616c0(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb56811fd58 CR3: 000000011e256000 CR4: 00000000003506a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: c1 e8 03 shr $0x3,%eax
3: 42 80 3c 20 00 cmpb $0x0,(%rax,%r12,1)
8: 74 08 je 0x12
a: 48 89 df mov %rbx,%rdi
d: e8 e5 09 f4 ff call 0xfff409f7
12: 48 8b 03 mov (%rbx),%rax
15: 48 89 44 24 48 mov %rax,0x48(%rsp)
1a: 4c 89 74 24 20 mov %r14,0x20(%rsp)
1f: 4d 8d 7e 30 lea 0x30(%r14),%r15
23: 4d 89 fe mov %r15,%r14
26: 49 c1 ee 03 shr $0x3,%r14
* 2a: 43 80 3c 26 00 cmpb $0x0,(%r14,%r12,1) <-- trapping instruction
2f: 74 08 je 0x39
31: 4c 89 ff mov %r15,%rdi
34: e8 be 09 f4 ff call 0xfff409f7
39: 49 8b 07 mov (%r15),%rax
3c: 48 rex.W
3d: 89 .byte 0x89
3e: 44 rex.R
3f: 24 .byte 0x24


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 754f8cc9b7de Revert "pwm: atmel-tcb: Convert to platform r..
git tree: android13-5.15-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=17efbc4d680000
kernel config: https://syzkaller.appspot.com/x/.config?x=74b073db7711271
dashboard link: https://syzkaller.appspot.com/bug?extid=a80f1dcaba9e162cda54

compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1042adc5680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12d34abd680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/fa49d5af9e3e/disk-754f8cc9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e7e7d31e194f/vmlinux-754f8cc9.xz
kernel image: https://storage.googleapis.com/syzbot-assets/97f9d18aca48/bzImage-754f8cc9.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+a80f1d...@syzkaller.appspotmail.com

general protection fault, probably for non-canonical address 0xdffffc0000000008: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000040-0x0000000000000047]

CPU: 1 PID: 294 Comm: syz-executor104 Not tainted 5.15.132-syzkaller-01173-g754f8cc9b7de #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023

RIP: 0010:vfs_rename+0x1a8/0xf90 fs/namei.c:4649
Code: c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 e0 3f f4 ff 48 8b 03 48 89 44 24 58 4c 89 6c 24 18 4d 8d 75 30 4d 89 f5 49 c1 ed 03 <43> 80 7c 3d 00 00 74 08 4c 89 f7 e8 b8 3f f4 ff 49 8b 06 48 89 44
RSP: 0018:ffffc900007afae0 EFLAGS: 00010202
RAX: ffff88811bc9f300 RBX: ffff88811bd4f9c0 RCX: ffffc900007afe80
RDX: ffff88811997cf00 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc900007afc30 R08: ffffffff81bda0a1 R09: ffffed10237a9f1c
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff88811bc9e200
R13: 0000000000000008 R14: 0000000000000040 R15: dffffc0000000000
FS: 00007f8d77b396c0(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000020007000 CR3: 00000001105e5000 CR4: 00000000003506a0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:

<TASK>
do_renameat2+0xac8/0x1480 fs/namei.c:4892
__do_sys_rename fs/namei.c:4938 [inline]
__se_sys_rename fs/namei.c:4936 [inline]
__x64_sys_rename+0x86/0x90 fs/namei.c:4936
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f8d77b81f89
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 a1 1a 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8d77b39168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f8d77c0b408 RCX: 00007f8d77b81f89
RDX: 00007f8d77b81f89 RSI: 0000000020000140 RDI: 0000000020000100
RBP: 00007f8d77c0b400 R08: 00007f8d77b396c0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f8d77c0b40c
R13: 0000000000000000 R14: 00007ffee5891130 R15: 00007ffee5891218
</TASK>
Modules linked in:
---[ end trace c3b148c9310e320c ]---
RIP: 0010:vfs_rename+0x1a8/0xf90 fs/namei.c:4649
Code: c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 e0 3f f4 ff 48 8b 03 48 89 44 24 58 4c 89 6c 24 18 4d 8d 75 30 4d 89 f5 49 c1 ed 03 <43> 80 7c 3d 00 00 74 08 4c 89 f7 e8 b8 3f f4 ff 49 8b 06 48 89 44
RSP: 0018:ffffc900007afae0 EFLAGS: 00010202
RAX: ffff88811bc9f300 RBX: ffff88811bd4f9c0 RCX: ffffc900007afe80
RDX: ffff88811997cf00 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc900007afc30 R08: ffffffff81bda0a1 R09: ffffed10237a9f1c
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff88811bc9e200
R13: 0000000000000008 R14: 0000000000000040 R15: dffffc0000000000
FS: 00007f8d77b396c0(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000020007000 CR3: 00000001105e5000 CR4: 00000000003506a0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: c1 e8 03 shr $0x3,%eax

3: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1)

8: 74 08 je 0x12
a: 48 89 df mov %rbx,%rdi

d: e8 e0 3f f4 ff call 0xfff43ff2

12: 48 8b 03 mov (%rbx),%rax

15: 48 89 44 24 58 mov %rax,0x58(%rsp)
1a: 4c 89 6c 24 18 mov %r13,0x18(%rsp)
1f: 4d 8d 75 30 lea 0x30(%r13),%r14
23: 4d 89 f5 mov %r14,%r13
26: 49 c1 ed 03 shr $0x3,%r13
* 2a: 43 80 7c 3d 00 00 cmpb $0x0,0x0(%r13,%r15,1) <-- trapping instruction
30: 74 08 je 0x3a
32: 4c 89 f7 mov %r14,%rdi
35: e8 b8 3f f4 ff call 0xfff43ff2
3a: 49 8b 06 mov (%r14),%rax
3d: 48 rex.W
3e: 89 .byte 0x89
3f: 44 rex.R

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 53771c1826da ANDROID: Update the ABI symbol list
git tree: android14-6.1
console+strace: https://syzkaller.appspot.com/x/log.txt?x=109e3851680000
kernel config: https://syzkaller.appspot.com/x/.config?x=3bacf1dde2aec241
dashboard link: https://syzkaller.appspot.com/bug?extid=6322832df18f369c5366

compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12d20589680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15338b15680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f1d680ce5f50/disk-53771c18.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4e844c4141e8/vmlinux-53771c18.xz
kernel image: https://storage.googleapis.com/syzbot-assets/228ff69bbe13/bzImage-53771c18.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+632283...@syzkaller.appspotmail.com

general protection fault, probably for non-canonical address 0xdffffc0000000008: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000040-0x0000000000000047]

CPU: 0 PID: 296 Comm: syz-executor424 Not tainted 6.1.25-syzkaller-00041-g53771c1826da #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023

RIP: 0010:vfs_rename+0x1b2/0x1190 fs/namei.c:4692
Code: c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 f6 76 f3 ff 48 8b 03 48 89 44 24 60 48 8b 44 24 30 4c 8d 70 30 4d 89 f5 49 c1 ed 03 <43> 80 7c 3d 00 00 74 08 4c 89 f7 e8 ce 76 f3 ff 49 8b 06 48 89 44
RSP: 0018:ffffc90000e27ac0 EFLAGS: 00010202
RAX: 0000000000000010 RBX: ffff88811f4e2690 RCX: ffff88811b328000
RDX: ffff88811b328000 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc90000e27c30 R08: ffffffff81c7ca4b R09: fffff520001c4f67
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff8881130af740

R13: 0000000000000008 R14: 0000000000000040 R15: dffffc0000000000

FS: 00007f556d5af6c0(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000020007000 CR3: 00000001220d2000 CR4: 00000000003506b0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

do_renameat2+0xac8/0x1480 fs/namei.c:4930
__do_sys_rename fs/namei.c:4976 [inline]
__se_sys_rename fs/namei.c:4974 [inline]
__x64_sys_rename+0x86/0x90 fs/namei.c:4974

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f556d5ed9b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f556d5af218 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f556d67e408 RCX: 00007f556d5ed9b9
RDX: 00007f556d5ed9b9 RSI: 0000000020000140 RDI: 0000000020000100
RBP: 00007f556d67e400 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f556d64b0a4
R13: 0030656c69662f2e R14: 00007f556d64b0de R15: 00007f556d6490a0
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:vfs_rename+0x1b2/0x1190 fs/namei.c:4692
Code: c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 f6 76 f3 ff 48 8b 03 48 89 44 24 60 48 8b 44 24 30 4c 8d 70 30 4d 89 f5 49 c1 ed 03 <43> 80 7c 3d 00 00 74 08 4c 89 f7 e8 ce 76 f3 ff 49 8b 06 48 89 44
RSP: 0018:ffffc90000e27ac0 EFLAGS: 00010202
RAX: 0000000000000010 RBX: ffff88811f4e2690 RCX: ffff88811b328000
RDX: ffff88811b328000 RSI: 0000000000400000 RDI: 0000000000200000
RBP: ffffc90000e27c30 R08: ffffffff81c7ca4b R09: fffff520001c4f67
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff8881130af740

R13: 0000000000000008 R14: 0000000000000040 R15: dffffc0000000000

FS: 00007f556d5af6c0(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f556d644598 CR3: 00000001220d2000 CR4: 00000000003506a0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: c1 e8 03 shr $0x3,%eax
3: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1)
8: 74 08 je 0x12
a: 48 89 df mov %rbx,%rdi

d: e8 f6 76 f3 ff call 0xfff37708

12: 48 8b 03 mov (%rbx),%rax

15: 48 89 44 24 60 mov %rax,0x60(%rsp)
1a: 48 8b 44 24 30 mov 0x30(%rsp),%rax
1f: 4c 8d 70 30 lea 0x30(%rax),%r14

23: 4d 89 f5 mov %r14,%r13
26: 49 c1 ed 03 shr $0x3,%r13
* 2a: 43 80 7c 3d 00 00 cmpb $0x0,0x0(%r13,%r15,1) <-- trapping instruction
30: 74 08 je 0x3a
32: 4c 89 f7 mov %r14,%rdi

35: e8 ce 76 f3 ff call 0xfff37708

[syzbot]

Bug presence analysis results: the bug reproduces only on Android 6.1.

syzbot has run the reproducer on other relevant kernel trees and got
the following results:

android14-6.1 (commit 53771c1826da) on 2023/10/22:
general protection fault in vfs_rename
Report: https://syzkaller.appspot.com/x/report.txt?x=16f29999680000

lts (commit b1644a0031cf) on 2023/10/22:
Didn't crash.

upstream (commit 1acfd2bd3f0d) on 2023/10/22:
Didn't crash.

More details can be found at:
https://syzkaller.appspot.com/bug?extid=6322832df18f369c5366

[syzbot]

syzbot has bisected this issue to:

commit 57f3ff9648991998d008ecf32f2f9e78a08bfb8b
Author: Daniel Rosenberg <dro...@google.com>
Date: Thu Dec 2 21:50:02 2021 +0000

ANDROID: fuse-bpf v1.1

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=110a7b33680000
start commit: 53771c1826da ANDROID: Update the ABI symbol list
git tree: android14-6.1
final oops: https://syzkaller.appspot.com/x/report.txt?x=130a7b33680000
console output: https://syzkaller.appspot.com/x/log.txt?x=150a7b33680000

kernel config: https://syzkaller.appspot.com/x/.config?x=3bacf1dde2aec241
dashboard link: https://syzkaller.appspot.com/bug?extid=6322832df18f369c5366

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12d20589680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15338b15680000

Reported-by: syzbot+632283...@syzkaller.appspotmail.com
Fixes: 57f3ff964899 ("ANDROID: fuse-bpf v1.1")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection