[Android 5.15] general protection fault in ax88179_disconnect

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: c541149e0f52 ANDROID: db845c: Enable device tree overlay s..
git tree: android13-5.15-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=176108b3e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=32e8ab4f45167b69
dashboard link: https://syzkaller.appspot.com/bug?extid=8884651d1008d50fe387
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=178b932be80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=131a50dde80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e3b03f4e0499/disk-c541149e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/29e684eb32a6/vmlinux-c541149e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/199125b6d38b/bzImage-c541149e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+888465...@syzkaller.appspotmail.com

ax88179_178a 1-1:0.0 (unnamed net_device) (uninitialized): Failed to read reg index 0x0000: -71
ax88179_178a 1-1:0.0 eth1: register 'ax88179_178a' at usb-dummy_hcd.0-1, ASIX AX88179 USB 3.0 Gigabit Ethernet, 1e:79:e9:ec:a1:23
usb 1-1: USB disconnect, device number 2
general protection fault, probably for non-canonical address 0xdffffc0000000002: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]
CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.15.146-syzkaller-00264-gc541149e0f52 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Workqueue: usb_hub_wq hub_event
RIP: 0010:ax88179_disconnect+0x6d/0xb0 drivers/net/usb/ax88179_178a.c:531
Code: 54 fe 48 83 c3 20 48 89 d8 48 c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 11 b0 96 fe 48 8b 1b 48 83 c3 10 48 89 d8 48 c1 e8 03 <42> 0f b6 04 38 84 c0 75 19 c6 03 01 4c 89 f7 e8 4f a2 04 00 eb 05
RSP: 0018:ffffc90000147628 EFLAGS: 00010202
RAX: 0000000000000002 RBX: 0000000000000010 RCX: ffff888100332780
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff888119c4d000
RBP: ffffc90000147640 R08: ffffffff8326e3d2 R09: fffff52000028eb5
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff888119c4d024
R13: ffff888119c4d030 R14: ffff888119c4d000 R15: dffffc0000000000
FS: 0000000000000000(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fefa47332c0 CR3: 000000010c3ef000 CR4: 00000000003506b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
usb_unbind_interface+0x1fa/0x8c0 drivers/usb/core/driver.c:458
__device_release_driver drivers/base/dd.c:1229 [inline]
device_release_driver_internal+0x50b/0x7d0 drivers/base/dd.c:1262
device_release_driver+0x19/0x20 drivers/base/dd.c:1285
bus_remove_device+0x2f8/0x360 drivers/base/bus.c:529
device_del+0x663/0xe90 drivers/base/core.c:3592
usb_disable_device+0x380/0x720 drivers/usb/core/message.c:1414
usb_disconnect+0x32a/0x890 drivers/usb/core/hub.c:2240
hub_port_connect drivers/usb/core/hub.c:5334 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5635 [inline]
port_event drivers/usb/core/hub.c:5785 [inline]
hub_event+0x1d42/0x4770 drivers/usb/core/hub.c:5867
process_one_work+0x6bb/0xc10 kernel/workqueue.c:2317
process_scheduled_works kernel/workqueue.c:2380 [inline]
worker_thread+0xe02/0x12a0 kernel/workqueue.c:2466
kthread+0x421/0x510 kernel/kthread.c:337
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
</TASK>
Modules linked in:
---[ end trace b7fac83d77f8026d ]---
RIP: 0010:ax88179_disconnect+0x6d/0xb0 drivers/net/usb/ax88179_178a.c:531
Code: 54 fe 48 83 c3 20 48 89 d8 48 c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 11 b0 96 fe 48 8b 1b 48 83 c3 10 48 89 d8 48 c1 e8 03 <42> 0f b6 04 38 84 c0 75 19 c6 03 01 4c 89 f7 e8 4f a2 04 00 eb 05
RSP: 0018:ffffc90000147628 EFLAGS: 00010202
RAX: 0000000000000002 RBX: 0000000000000010 RCX: ffff888100332780
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff888119c4d000
RBP: ffffc90000147640 R08: ffffffff8326e3d2 R09: fffff52000028eb5
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff888119c4d024
R13: ffff888119c4d030 R14: ffff888119c4d000 R15: dffffc0000000000
FS: 0000000000000000(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000564b3ff36088 CR3: 000000010c3ef000 CR4: 00000000003506b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: 54 push %rsp
1: fe 48 83 decb -0x7d(%rax)
4: c3 ret
5: 20 48 89 and %cl,-0x77(%rax)
8: d8 48 c1 fmuls -0x3f(%rax)
b: e8 03 42 80 3c call 0x3c804213
10: 38 00 cmp %al,(%rax)
12: 74 08 je 0x1c
14: 48 89 df mov %rbx,%rdi
17: e8 11 b0 96 fe call 0xfe96b02d
1c: 48 8b 1b mov (%rbx),%rbx
1f: 48 83 c3 10 add $0x10,%rbx
23: 48 89 d8 mov %rbx,%rax
26: 48 c1 e8 03 shr $0x3,%rax
* 2a: 42 0f b6 04 38 movzbl (%rax,%r15,1),%eax <-- trapping instruction
2f: 84 c0 test %al,%al
31: 75 19 jne 0x4c
33: c6 03 01 movb $0x1,(%rbx)
36: 4c 89 f7 mov %r14,%rdi
39: e8 4f a2 04 00 call 0x4a28d
3e: eb 05 jmp 0x45


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 231752a0a05d84dd7b315ac795f6abff0c76f906
Author: Justin Chen <justi...@gmail.com>
Date: Thu Jul 21 00:28:15 2022 +0000

net: usb: ax88179_178a: move priv to driver_priv

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16a5f230180000
start commit: c541149e0f52 ANDROID: db845c: Enable device tree overlay s..
git tree: android13-5.15-lts

kernel config: https://syzkaller.appspot.com/x/.config?x=32e8ab4f45167b69
dashboard link: https://syzkaller.appspot.com/bug?extid=8884651d1008d50fe387

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=178b932be80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=131a50dde80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: net: usb: ax88179_178a: move priv to driver_priv

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.