kernel BUG in jbd2_journal_dirty_metadata

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: c73b4619ad86 ANDROID: abi preservation for fscrypt change ..
git tree: android13-5.15-lts
console output: https://syzkaller.appspot.com/x/log.txt?x=16875baf880000
kernel config: https://syzkaller.appspot.com/x/.config?x=d7c9bd3bb9661aad
dashboard link: https://syzkaller.appspot.com/bug?extid=3b5082684efce8492db2
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10c855e7880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11b87100480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2d1b5fd68d59/disk-c73b4619.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8f8fe73d2dd3/vmlinux-c73b4619.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0ed4cdb17035/bzImage-c73b4619.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3b5082...@syzkaller.appspotmail.com

JBD2: assertion failure: h_type=4 h_line_no=3355 block_no=4861 jlist=2
------------[ cut here ]------------
kernel BUG at fs/jbd2/transaction.c:1517!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 509 Comm: syz-executor158 Not tainted 5.15.78-syzkaller-00911-gc73b4619ad86 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:jbd2_journal_dirty_metadata+0xc3f/0xc50 fs/jbd2/transaction.c:1516
Code: 06 b1 ff e9 a2 fd ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c cf fd ff ff 48 89 df e8 2b 06 b1 ff e9 c2 fd ff ff e8 71 a1 6e ff <0f> 0b e8 6a a1 6e ff 0f 0b 0f 1f 84 00 00 00 00 00 55 48 89 e5 41
RSP: 0018:ffffc90000ce7758 EFLAGS: 00010293
RAX: ffffffff8202fe1f RBX: 0000000000000002 RCX: ffff8881069a4f00
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000001
RBP: ffffc90000ce77d8 R08: ffffffff8202f624 R09: ffffed103ee065e8
R10: ffffed103ee065e8 R11: 1ffff1103ee065e7 R12: 1ffff110218da8de
R13: dffffc0000000000 R14: ffff88810c6d46f0 R15: ffff88811d5de3c0
FS: 0000555556794400(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f375b64ed80 CR3: 0000000121a8e000 CR4: 00000000003506b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__ext4_handle_dirty_metadata+0x1e5/0x820 fs/ext4/ext4_jbd2.c:350
ext4_handle_dirty_dirblock+0x35e/0x6c0 fs/ext4/namei.c:438
add_dirent_to_buf+0x6a1/0x7c0 fs/ext4/namei.c:2196
ext4_add_entry+0x918/0x1290 fs/ext4/namei.c:2424
ext4_add_nondir+0x97/0x270 fs/ext4/namei.c:2772
ext4_symlink+0x9b5/0xfe0 fs/ext4/namei.c:3423
vfs_symlink+0x29e/0x470 fs/namei.c:4302
do_symlinkat+0x1f8/0x5b0 fs/namei.c:4331
__do_sys_symlink fs/namei.c:4353 [inline]
__se_sys_symlink fs/namei.c:4351 [inline]
__x64_sys_symlink+0x7e/0x90 fs/namei.c:4351
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f375b5ea877
Code: 24 30 ba 22 00 00 00 4c 8b 74 24 28 64 c7 03 22 00 00 00 e9 76 fd ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 58 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd86c63c48 EFLAGS: 00000206 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 0000000000010814 RCX: 00007f375b5ea877
RDX: 00007ffd86c63d27 RSI: 00007f375b6390ae RDI: 00007ffd86c63d10
RBP: 0000000000000000 R08: 0000000000000000 R09: 00007ffd86c63ae0
R10: 00007ffd86c63997 R11: 0000000000000206 R12: 00007ffd86c63c70
R13: 00007ffd86c63cd0 R14: 0000000000000006 R15: 00007ffd86c63d10
</TASK>
Modules linked in:
---[ end trace 4898221457b2e298 ]---
RIP: 0010:jbd2_journal_dirty_metadata+0xc3f/0xc50 fs/jbd2/transaction.c:1516
Code: 06 b1 ff e9 a2 fd ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c cf fd ff ff 48 89 df e8 2b 06 b1 ff e9 c2 fd ff ff e8 71 a1 6e ff <0f> 0b e8 6a a1 6e ff 0f 0b 0f 1f 84 00 00 00 00 00 55 48 89 e5 41
RSP: 0018:ffffc90000ce7758 EFLAGS: 00010293
RAX: ffffffff8202fe1f RBX: 0000000000000002 RCX: ffff8881069a4f00
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000001
RBP: ffffc90000ce77d8 R08: ffffffff8202f624 R09: ffffed103ee065e8
R10: ffffed103ee065e8 R11: 1ffff1103ee065e7 R12: 1ffff110218da8de
R13: dffffc0000000000 R14: ffff88810c6d46f0 R15: ffff88811d5de3c0
FS: 0000555556794400(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f375b64ed80 CR3: 0000000121a8e000 CR4: 00000000003506b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[Tudor Ambarus]

#syz test
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

[Tudor Ambarus]

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
linux-5.15.y

[Tudor Ambarus]

#syz test https://android.googlesource.com/kernel/common android13-5.15-lts

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
SYZFATAL: executor failed NUM times: failed to create temp dir: mkdir ./syzkaller-testdirNUM: no space left on device

2022/12/20 17:54:06 SYZFATAL: executor failed 11 times: failed to create temp dir: mkdir ./syzkaller-testdir366783780: no space left on device


Tested on:

commit: b6bb9676 Merge tag 'm68knommu-for-v6.2' of git://git.k..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=127c914f880000
kernel config: https://syzkaller.appspot.com/x/.config?x=50ae10bbe87733d7

dashboard link: https://syzkaller.appspot.com/bug?extid=3b5082684efce8492db2
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
SYZFATAL: executor failed NUM times: failed to create temp dir: mkdir ./syzkaller-testdirNUM: no space left on device

2022/12/20 18:02:50 SYZFATAL: executor failed 11 times: failed to create temp dir: mkdir ./syzkaller-testdir1048848217: no space left on device


Tested on:

commit: d68f50bf Linux 5.15.84
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17905d4f880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9fdecc764ea03303

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
SYZFATAL: executor failed NUM times: failed to create temp dir: mkdir ./syzkaller-testdirNUM: no space left on device

2022/12/20 18:09:53 SYZFATAL: executor failed 11 times: failed to create temp dir: mkdir ./syzkaller-testdir3197534553: no space left on device


Tested on:

commit: c73b4619 ANDROID: abi preservation for fscrypt change ..
git tree: android13-5.15-lts
console output: https://syzkaller.appspot.com/x/log.txt?x=168c649b880000
kernel config: https://syzkaller.appspot.com/x/.config?x=57041d0cd45b9364

[Jun Nie]

The repro.c test is testing in network domain. But we see a ext4 bug here. So it is not a good reproducer.

All failures from Tudor's test shows bug: no space left on device

[Tudor Ambarus]

trying one more time to see if the reproducer is valid, this time with
the sha1 used in the bug report:

#syz test: https://android.googlesource.com/kernel/common
c73b4619ad86a2a29fc998e950e98bcdfa2f6d8f

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:

SYZFATAL: executor failed NUM times: failed to create temp dir: mkdir ./syzkaller-testdirNUM: no space left on device

2023/04/06 12:13:04 SYZFATAL: executor failed 11 times: failed to create temp dir: mkdir ./syzkaller-testdir1929085488: no space left on device

Tested on:

commit: c73b4619 ANDROID: abi preservation for fscrypt change ..

git tree: https://android.googlesource.com/kernel/common
console output: https://syzkaller.appspot.com/x/log.txt?x=1602dcddc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=62742f737a7d3f81
dashboard link: https://syzkaller.appspot.com/bug?extid=3b5082684efce8492db2
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

[Tudor Ambarus]

The bug was reproduced only once by syzbot. I tried various bases,
including the sha1 on which the bug was reported, all fail with the
message "no space left on device".

#syz invalid