KASAN: use-after-free Read in virtqueue_add
18 views
Skip to first unread message
syzbot
Jun 13, 2021, 7:51:25 AM6/13/21
to syzkaller-a...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 83ffd1a8 UPSTREAM: net: fix use-after-free when UDP GRO wi..
git tree: android12-5.4
console output: https://syzkaller.appspot.com/x/log.txt?x=176ae6ffd00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d6369a9bfb56299f
dashboard link: https://syzkaller.appspot.com/bug?extid=b140ec75bd5a047c7362
compiler: Debian clang version 11.0.1-2
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b140ec...@syzkaller.appspotmail.com
==================================================================
BUG: KASAN: use-after-free in virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
Read of size 1 at addr ffff8881ded25b38 by task kworker/0:1H/95
CPU: 0 PID: 95 Comm: kworker/0:1H Not tainted 5.4.125-syzkaller-00121-g83ffd1a84016 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: kblockd blk_mq_run_work_fn
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1d8/0x24e lib/dump_stack.c:118
print_address_description+0x9b/0x650 mm/kasan/report.c:384
__kasan_report+0x182/0x260 mm/kasan/report.c:516
kasan_report+0x30/0x60 mm/kasan/common.c:641
virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
virtqueue_add_sgs+0x112/0x130 drivers/virtio/virtio_ring.c:1740
__virtscsi_add_cmd drivers/scsi/virtio_scsi.c:447 [inline]
virtscsi_add_cmd+0x52b/0x680 drivers/scsi/virtio_scsi.c:481
virtscsi_queuecommand+0x34d/0x590 drivers/scsi/virtio_scsi.c:578
scsi_dispatch_cmd+0x2f0/0x6e0 drivers/scsi/scsi_lib.c:1566
scsi_queue_rq+0x1c53/0x2720 drivers/scsi/scsi_lib.c:1701
blk_mq_dispatch_rq_list+0x90c/0x17e0 block/blk-mq.c:1297
blk_mq_do_dispatch_sched+0x313/0x3f0 block/blk-mq-sched.c:124
blk_mq_sched_dispatch_requests+0x4e3/0x5e0 block/blk-mq-sched.c:220
__blk_mq_run_hw_queue+0x142/0x260 block/blk-mq.c:1428
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Allocated by task 518:
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
__kasan_kmalloc+0x137/0x1e0 mm/kasan/common.c:517
kmem_cache_alloc_trace+0x139/0x2b0 mm/slub.c:2848
kmalloc include/linux/slab.h:556 [inline]
__vring_new_virtqueue+0x141/0xd40 drivers/virtio/virtio_ring.c:2071
vring_create_virtqueue_split drivers/virtio/virtio_ring.c:894 [inline]
vring_create_virtqueue+0x1830/0x1d00 drivers/virtio/virtio_ring.c:2152
setup_vq+0x161/0x370 drivers/virtio/virtio_pci_legacy.c:137
vp_setup_vq+0xbc/0x330 drivers/virtio/virtio_pci_common.c:189
vp_find_vqs_msix+0x88b/0xc40 drivers/virtio/virtio_pci_common.c:323
vp_find_vqs+0x45/0x4a0 drivers/virtio/virtio_pci_common.c:400
virtio_find_vqs include/linux/virtio_config.h:197 [inline]
virtscsi_init+0x490/0xa60 drivers/scsi/virtio_scsi.c:807
virtscsi_restore+0xe2/0xe90 drivers/scsi/virtio_scsi.c:941
virtio_device_restore+0x39c/0x5a0 drivers/virtio/virtio.c:413
dpm_run_callback drivers/base/power/main.c:487 [inline]
device_resume+0x543/0x910 drivers/base/power/main.c:1029
async_resume+0x23/0x170 drivers/base/power/main.c:1049
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Freed by task 519:
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
kasan_set_free_info mm/kasan/common.c:333 [inline]
__kasan_slab_free+0x18a/0x240 mm/kasan/common.c:475
slab_free_hook mm/slub.c:1454 [inline]
slab_free_freelist_hook+0x7b/0x150 mm/slub.c:1492
slab_free mm/slub.c:3072 [inline]
kfree+0xe0/0x660 mm/slub.c:4061
vp_del_vq drivers/virtio/virtio_pci_common.c:221 [inline]
vp_del_vqs+0x37c/0x8c0 drivers/virtio/virtio_pci_common.c:243
virtscsi_remove_vqs drivers/scsi/virtio_scsi.c:772 [inline]
virtscsi_freeze+0x8d/0xa0 drivers/scsi/virtio_scsi.c:931
virtio_pci_freeze+0x39/0x70 drivers/virtio/virtio_pci_common.c:466
pci_pm_suspend+0x2dc/0x910 drivers/pci/pci-driver.c:789
dpm_run_callback drivers/base/power/main.c:487 [inline]
__device_suspend+0x84c/0x1300 drivers/base/power/main.c:1816
async_suspend+0x25/0x1f0 drivers/base/power/main.c:1848
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
The buggy address belongs to the object at ffff8881ded25b00
which belongs to the cache kmalloc-192 of size 192
The buggy address is located 56 bytes inside of
192-byte region [ffff8881ded25b00, ffff8881ded25bc0)
The buggy address belongs to the page:
page:ffffea00077b4940 refcount:1 mapcount:0 mapping:ffff8881f5c02a00 index:0x0
flags: 0x8000000000000200(slab)
raw: 8000000000000200 ffffea00068a5f00 0000000a00000003 ffff8881f5c02a00
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12a20(GFP_ATOMIC|__GFP_NOWARN|__GFP_NORETRY)
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook mm/page_alloc.c:2165 [inline]
prep_new_page+0x19a/0x380 mm/page_alloc.c:2171
get_page_from_freelist+0x550/0x8b0 mm/page_alloc.c:3794
__alloc_pages_nodemask+0x3a2/0x880 mm/page_alloc.c:4855
alloc_slab_page+0x39/0x3e0 mm/slub.c:342
allocate_slab mm/slub.c:1675 [inline]
new_slab+0x97/0x460 mm/slub.c:1741
new_slab_objects mm/slub.c:2498 [inline]
___slab_alloc+0x330/0x4c0 mm/slub.c:2659
__slab_alloc mm/slub.c:2699 [inline]
slab_alloc_node mm/slub.c:2784 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc_trace+0x199/0x2b0 mm/slub.c:2846
kmalloc include/linux/slab.h:556 [inline]
kzalloc include/linux/slab.h:690 [inline]
mld_add_delrec net/ipv6/mcast.c:737 [inline]
igmp6_leave_group net/ipv6/mcast.c:2456 [inline]
igmp6_group_dropped+0x4c4/0xba0 net/ipv6/mcast.c:716
__ipv6_dev_mc_dec+0x26f/0x4e0 net/ipv6/mcast.c:958
addrconf_leave_solict net/ipv6/addrconf.c:2165 [inline]
__ipv6_ifa_notify+0x91e/0x1340 net/ipv6/addrconf.c:6054
addrconf_ifdown+0xb57/0x15e0 net/ipv6/addrconf.c:3855
addrconf_notify+0x45f/0x3c90 net/ipv6/addrconf.c:3666
notifier_call_chain kernel/notifier.c:98 [inline]
__raw_notifier_call_chain kernel/notifier.c:399 [inline]
raw_notifier_call_chain+0x9e/0x110 kernel/notifier.c:406
__dev_notify_flags+0x264/0x4f0 net/core/dev.c:1670
dev_change_flags+0xe3/0x190 net/core/dev.c:7983
do_setlink+0xc2c/0x3b50 net/core/rtnetlink.c:2519
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1176 [inline]
free_pcp_prepare+0x1a9/0x270 mm/page_alloc.c:1233
free_unref_page_prepare mm/page_alloc.c:3085 [inline]
free_unref_page mm/page_alloc.c:3134 [inline]
free_the_page mm/page_alloc.c:4915 [inline]
__free_pages+0x9c/0x250 mm/page_alloc.c:4923
__free_slab+0x237/0x2f0 mm/slub.c:1766
free_slab mm/slub.c:1781 [inline]
discard_slab mm/slub.c:1787 [inline]
unfreeze_partials+0x14f/0x180 mm/slub.c:2279
put_cpu_partial+0xb5/0x150 mm/slub.c:2315
__slab_free mm/slub.c:2963 [inline]
do_slab_free mm/slub.c:3060 [inline]
___cache_free+0x352/0x4e0 mm/slub.c:3079
qlist_free_all mm/kasan/quarantine.c:167 [inline]
quarantine_reduce+0x17a/0x1e0 mm/kasan/quarantine.c:260
__kasan_kmalloc+0x43/0x1e0 mm/kasan/common.c:495
slab_post_alloc_hook mm/slab.h:584 [inline]
slab_alloc_node mm/slub.c:2821 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc+0x115/0x290 mm/slub.c:2834
getname_flags+0xba/0x640 fs/namei.c:141
getname fs/namei.c:212 [inline]
user_path_create fs/namei.c:3771 [inline]
do_mkdirat+0x9e/0x330 fs/namei.c:3909
do_syscall_64+0xcb/0x1e0 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Memory state around the buggy address:
ffff8881ded25a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881ded25a80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff8881ded25b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881ded25b80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881ded25c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: 83ffd1a8 UPSTREAM: net: fix use-after-free when UDP GRO wi..
git tree: android12-5.4
console output: https://syzkaller.appspot.com/x/log.txt?x=176ae6ffd00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d6369a9bfb56299f
dashboard link: https://syzkaller.appspot.com/bug?extid=b140ec75bd5a047c7362
compiler: Debian clang version 11.0.1-2
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b140ec...@syzkaller.appspotmail.com
==================================================================
BUG: KASAN: use-after-free in virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
Read of size 1 at addr ffff8881ded25b38 by task kworker/0:1H/95
CPU: 0 PID: 95 Comm: kworker/0:1H Not tainted 5.4.125-syzkaller-00121-g83ffd1a84016 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: kblockd blk_mq_run_work_fn
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1d8/0x24e lib/dump_stack.c:118
print_address_description+0x9b/0x650 mm/kasan/report.c:384
__kasan_report+0x182/0x260 mm/kasan/report.c:516
kasan_report+0x30/0x60 mm/kasan/common.c:641
virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
virtqueue_add_sgs+0x112/0x130 drivers/virtio/virtio_ring.c:1740
__virtscsi_add_cmd drivers/scsi/virtio_scsi.c:447 [inline]
virtscsi_add_cmd+0x52b/0x680 drivers/scsi/virtio_scsi.c:481
virtscsi_queuecommand+0x34d/0x590 drivers/scsi/virtio_scsi.c:578
scsi_dispatch_cmd+0x2f0/0x6e0 drivers/scsi/scsi_lib.c:1566
scsi_queue_rq+0x1c53/0x2720 drivers/scsi/scsi_lib.c:1701
blk_mq_dispatch_rq_list+0x90c/0x17e0 block/blk-mq.c:1297
blk_mq_do_dispatch_sched+0x313/0x3f0 block/blk-mq-sched.c:124
blk_mq_sched_dispatch_requests+0x4e3/0x5e0 block/blk-mq-sched.c:220
__blk_mq_run_hw_queue+0x142/0x260 block/blk-mq.c:1428
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Allocated by task 518:
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
__kasan_kmalloc+0x137/0x1e0 mm/kasan/common.c:517
kmem_cache_alloc_trace+0x139/0x2b0 mm/slub.c:2848
kmalloc include/linux/slab.h:556 [inline]
__vring_new_virtqueue+0x141/0xd40 drivers/virtio/virtio_ring.c:2071
vring_create_virtqueue_split drivers/virtio/virtio_ring.c:894 [inline]
vring_create_virtqueue+0x1830/0x1d00 drivers/virtio/virtio_ring.c:2152
setup_vq+0x161/0x370 drivers/virtio/virtio_pci_legacy.c:137
vp_setup_vq+0xbc/0x330 drivers/virtio/virtio_pci_common.c:189
vp_find_vqs_msix+0x88b/0xc40 drivers/virtio/virtio_pci_common.c:323
vp_find_vqs+0x45/0x4a0 drivers/virtio/virtio_pci_common.c:400
virtio_find_vqs include/linux/virtio_config.h:197 [inline]
virtscsi_init+0x490/0xa60 drivers/scsi/virtio_scsi.c:807
virtscsi_restore+0xe2/0xe90 drivers/scsi/virtio_scsi.c:941
virtio_device_restore+0x39c/0x5a0 drivers/virtio/virtio.c:413
dpm_run_callback drivers/base/power/main.c:487 [inline]
device_resume+0x543/0x910 drivers/base/power/main.c:1029
async_resume+0x23/0x170 drivers/base/power/main.c:1049
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Freed by task 519:
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
kasan_set_free_info mm/kasan/common.c:333 [inline]
__kasan_slab_free+0x18a/0x240 mm/kasan/common.c:475
slab_free_hook mm/slub.c:1454 [inline]
slab_free_freelist_hook+0x7b/0x150 mm/slub.c:1492
slab_free mm/slub.c:3072 [inline]
kfree+0xe0/0x660 mm/slub.c:4061
vp_del_vq drivers/virtio/virtio_pci_common.c:221 [inline]
vp_del_vqs+0x37c/0x8c0 drivers/virtio/virtio_pci_common.c:243
virtscsi_remove_vqs drivers/scsi/virtio_scsi.c:772 [inline]
virtscsi_freeze+0x8d/0xa0 drivers/scsi/virtio_scsi.c:931
virtio_pci_freeze+0x39/0x70 drivers/virtio/virtio_pci_common.c:466
pci_pm_suspend+0x2dc/0x910 drivers/pci/pci-driver.c:789
dpm_run_callback drivers/base/power/main.c:487 [inline]
__device_suspend+0x84c/0x1300 drivers/base/power/main.c:1816
async_suspend+0x25/0x1f0 drivers/base/power/main.c:1848
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
The buggy address belongs to the object at ffff8881ded25b00
which belongs to the cache kmalloc-192 of size 192
The buggy address is located 56 bytes inside of
192-byte region [ffff8881ded25b00, ffff8881ded25bc0)
The buggy address belongs to the page:
page:ffffea00077b4940 refcount:1 mapcount:0 mapping:ffff8881f5c02a00 index:0x0
flags: 0x8000000000000200(slab)
raw: 8000000000000200 ffffea00068a5f00 0000000a00000003 ffff8881f5c02a00
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12a20(GFP_ATOMIC|__GFP_NOWARN|__GFP_NORETRY)
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook mm/page_alloc.c:2165 [inline]
prep_new_page+0x19a/0x380 mm/page_alloc.c:2171
get_page_from_freelist+0x550/0x8b0 mm/page_alloc.c:3794
__alloc_pages_nodemask+0x3a2/0x880 mm/page_alloc.c:4855
alloc_slab_page+0x39/0x3e0 mm/slub.c:342
allocate_slab mm/slub.c:1675 [inline]
new_slab+0x97/0x460 mm/slub.c:1741
new_slab_objects mm/slub.c:2498 [inline]
___slab_alloc+0x330/0x4c0 mm/slub.c:2659
__slab_alloc mm/slub.c:2699 [inline]
slab_alloc_node mm/slub.c:2784 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc_trace+0x199/0x2b0 mm/slub.c:2846
kmalloc include/linux/slab.h:556 [inline]
kzalloc include/linux/slab.h:690 [inline]
mld_add_delrec net/ipv6/mcast.c:737 [inline]
igmp6_leave_group net/ipv6/mcast.c:2456 [inline]
igmp6_group_dropped+0x4c4/0xba0 net/ipv6/mcast.c:716
__ipv6_dev_mc_dec+0x26f/0x4e0 net/ipv6/mcast.c:958
addrconf_leave_solict net/ipv6/addrconf.c:2165 [inline]
__ipv6_ifa_notify+0x91e/0x1340 net/ipv6/addrconf.c:6054
addrconf_ifdown+0xb57/0x15e0 net/ipv6/addrconf.c:3855
addrconf_notify+0x45f/0x3c90 net/ipv6/addrconf.c:3666
notifier_call_chain kernel/notifier.c:98 [inline]
__raw_notifier_call_chain kernel/notifier.c:399 [inline]
raw_notifier_call_chain+0x9e/0x110 kernel/notifier.c:406
__dev_notify_flags+0x264/0x4f0 net/core/dev.c:1670
dev_change_flags+0xe3/0x190 net/core/dev.c:7983
do_setlink+0xc2c/0x3b50 net/core/rtnetlink.c:2519
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1176 [inline]
free_pcp_prepare+0x1a9/0x270 mm/page_alloc.c:1233
free_unref_page_prepare mm/page_alloc.c:3085 [inline]
free_unref_page mm/page_alloc.c:3134 [inline]
free_the_page mm/page_alloc.c:4915 [inline]
__free_pages+0x9c/0x250 mm/page_alloc.c:4923
__free_slab+0x237/0x2f0 mm/slub.c:1766
free_slab mm/slub.c:1781 [inline]
discard_slab mm/slub.c:1787 [inline]
unfreeze_partials+0x14f/0x180 mm/slub.c:2279
put_cpu_partial+0xb5/0x150 mm/slub.c:2315
__slab_free mm/slub.c:2963 [inline]
do_slab_free mm/slub.c:3060 [inline]
___cache_free+0x352/0x4e0 mm/slub.c:3079
qlist_free_all mm/kasan/quarantine.c:167 [inline]
quarantine_reduce+0x17a/0x1e0 mm/kasan/quarantine.c:260
__kasan_kmalloc+0x43/0x1e0 mm/kasan/common.c:495
slab_post_alloc_hook mm/slab.h:584 [inline]
slab_alloc_node mm/slub.c:2821 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc+0x115/0x290 mm/slub.c:2834
getname_flags+0xba/0x640 fs/namei.c:141
getname fs/namei.c:212 [inline]
user_path_create fs/namei.c:3771 [inline]
do_mkdirat+0x9e/0x330 fs/namei.c:3909
do_syscall_64+0xcb/0x1e0 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Memory state around the buggy address:
ffff8881ded25a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881ded25a80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff8881ded25b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881ded25b80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881ded25c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Jun 13, 2021, 12:01:26 PM6/13/21
to syzkaller-a...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 83ffd1a8 UPSTREAM: net: fix use-after-free when UDP GRO wi..
git tree: android12-5.4
console output: https://syzkaller.appspot.com/x/log.txt?x=1762d2ebd00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137405bbd00000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b140ec...@syzkaller.appspotmail.com
==================================================================
BUG: KASAN: use-after-free in virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
Read of size 1 at addr ffff8881e1690138 by task systemd/1
CPU: 0 PID: 1 Comm: systemd Not tainted 5.4.125-syzkaller-00121-g83ffd1a84016 #0
blk_mq_run_hw_queue+0x284/0x3a0 block/blk-mq.c:1533
blk_mq_sched_insert_requests+0x227/0x370 block/blk-mq-sched.c:485
blk_mq_flush_plug_list+0x858/0xa80 block/blk-mq.c:1801
blk_flush_plug_list+0x4b0/0x500 block/blk-core.c:1787
blk_finish_plug+0x5a/0x80 block/blk-core.c:1804
read_pages+0x3a9/0x400 mm/readahead.c:142
__do_page_cache_readahead+0x470/0x510 mm/readahead.c:212
ra_submit mm/internal.h:62 [inline]
do_sync_mmap_readahead mm/filemap.c:2441 [inline]
filemap_fault+0xb09/0x19c0 mm/filemap.c:2527
ext4_filemap_fault+0x7b/0x90 fs/ext4/inode.c:6416
__do_fault mm/memory.c:3196 [inline]
do_read_fault mm/memory.c:3596 [inline]
do_fault mm/memory.c:3725 [inline]
handle_pte_fault mm/memory.c:3956 [inline]
__handle_mm_fault mm/memory.c:4080 [inline]
handle_mm_fault+0x29c3/0x42f0 mm/memory.c:4117
do_user_addr_fault+0x4a0/0xb40 arch/x86/mm/fault.c:1469
page_fault+0x2f/0x40 arch/x86/entry/entry_64.S:1203
RIP: 0033:0x7fd99640b21d
Code: Bad RIP value.
RSP: 002b:00007ffdd4d85810 EFLAGS: 00010207
RAX: 0000000000000001 RBX: 000056010a4a6d10 RCX: 00007fd994d3e303
RDX: 0000000000000001 RSI: 00007ffdd4d85810 RDI: 0000000000000000
RBP: 00007ffdd4d85ac0 R08: 431bde82d7b634db R09: 0000000000000bd0
R10: 00000000ffffffff R11: 0000000000000000 R12: 00007ffdd4d85810
R13: 0000000000000001 R14: ffffffffffffffff R15: 0000000000000002
Allocated by task 341:
flags: 0x8000000000000200(slab)
raw: 8000000000000200 ffffea0007885240 0000000400000004 ffff8881f5c02a00
do_dentry_open+0x949/0x1100 fs/open.c:796
do_last fs/namei.c:3495 [inline]
path_openat+0x1127/0x3da0 fs/namei.c:3612
do_filp_open+0x208/0x450 fs/namei.c:3642
do_sys_open+0x383/0x7c0 fs/open.c:1113
do_syscall_64+0xcb/0x1e0 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
inode_doinit_with_dentry+0xb34/0x11d0 security/selinux/hooks.c:1562
security_d_instantiate+0xa5/0x100 security/security.c:1882
d_splice_alias+0x71/0x590 fs/dcache.c:3010
kernfs_iop_lookup+0x17a/0x1f0 fs/kernfs/dir.c:1104
__lookup_slow+0x2f8/0x450 fs/namei.c:1748
lookup_slow fs/namei.c:1765 [inline]
walk_component+0x3e1/0x960 fs/namei.c:1885
lookup_last fs/namei.c:2348 [inline]
path_lookupat+0x219/0xa40 fs/namei.c:2393
filename_lookup+0x223/0x6a0 fs/namei.c:2423
user_path_at include/linux/namei.h:49 [inline]
do_faccessat+0x323/0x7a0 fs/open.c:398
ffff8881e1690080: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff8881e1690100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881e1690180: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881e1690200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
HEAD commit: 83ffd1a8 UPSTREAM: net: fix use-after-free when UDP GRO wi..
git tree: android12-5.4
kernel config: https://syzkaller.appspot.com/x/.config?x=d6369a9bfb56299f
dashboard link: https://syzkaller.appspot.com/bug?extid=b140ec75bd5a047c7362
compiler: Debian clang version 11.0.1-2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1453fc98300000
dashboard link: https://syzkaller.appspot.com/bug?extid=b140ec75bd5a047c7362
compiler: Debian clang version 11.0.1-2
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137405bbd00000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b140ec...@syzkaller.appspotmail.com
==================================================================
BUG: KASAN: use-after-free in virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
CPU: 0 PID: 1 Comm: systemd Not tainted 5.4.125-syzkaller-00121-g83ffd1a84016 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1d8/0x24e lib/dump_stack.c:118
print_address_description+0x9b/0x650 mm/kasan/report.c:384
__kasan_report+0x182/0x260 mm/kasan/report.c:516
kasan_report+0x30/0x60 mm/kasan/common.c:641
virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
virtqueue_add_sgs+0x112/0x130 drivers/virtio/virtio_ring.c:1740
__virtscsi_add_cmd drivers/scsi/virtio_scsi.c:447 [inline]
virtscsi_add_cmd+0x52b/0x680 drivers/scsi/virtio_scsi.c:481
virtscsi_queuecommand+0x34d/0x590 drivers/scsi/virtio_scsi.c:578
scsi_dispatch_cmd+0x2f0/0x6e0 drivers/scsi/scsi_lib.c:1566
scsi_queue_rq+0x1c53/0x2720 drivers/scsi/scsi_lib.c:1701
blk_mq_dispatch_rq_list+0x90c/0x17e0 block/blk-mq.c:1297
blk_mq_do_dispatch_sched+0x313/0x3f0 block/blk-mq-sched.c:124
blk_mq_sched_dispatch_requests+0x4e3/0x5e0 block/blk-mq-sched.c:220
__blk_mq_run_hw_queue+0x142/0x260 block/blk-mq.c:1428
__blk_mq_delay_run_hw_queue+0x22c/0x570 block/blk-mq.c:1496
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1d8/0x24e lib/dump_stack.c:118
print_address_description+0x9b/0x650 mm/kasan/report.c:384
__kasan_report+0x182/0x260 mm/kasan/report.c:516
kasan_report+0x30/0x60 mm/kasan/common.c:641
virtqueue_add+0x3603/0x3dd0 drivers/virtio/virtio_ring.c:1704
virtqueue_add_sgs+0x112/0x130 drivers/virtio/virtio_ring.c:1740
__virtscsi_add_cmd drivers/scsi/virtio_scsi.c:447 [inline]
virtscsi_add_cmd+0x52b/0x680 drivers/scsi/virtio_scsi.c:481
virtscsi_queuecommand+0x34d/0x590 drivers/scsi/virtio_scsi.c:578
scsi_dispatch_cmd+0x2f0/0x6e0 drivers/scsi/scsi_lib.c:1566
scsi_queue_rq+0x1c53/0x2720 drivers/scsi/scsi_lib.c:1701
blk_mq_dispatch_rq_list+0x90c/0x17e0 block/blk-mq.c:1297
blk_mq_do_dispatch_sched+0x313/0x3f0 block/blk-mq-sched.c:124
blk_mq_sched_dispatch_requests+0x4e3/0x5e0 block/blk-mq-sched.c:220
__blk_mq_run_hw_queue+0x142/0x260 block/blk-mq.c:1428
blk_mq_run_hw_queue+0x284/0x3a0 block/blk-mq.c:1533
blk_mq_sched_insert_requests+0x227/0x370 block/blk-mq-sched.c:485
blk_mq_flush_plug_list+0x858/0xa80 block/blk-mq.c:1801
blk_flush_plug_list+0x4b0/0x500 block/blk-core.c:1787
blk_finish_plug+0x5a/0x80 block/blk-core.c:1804
read_pages+0x3a9/0x400 mm/readahead.c:142
__do_page_cache_readahead+0x470/0x510 mm/readahead.c:212
ra_submit mm/internal.h:62 [inline]
do_sync_mmap_readahead mm/filemap.c:2441 [inline]
filemap_fault+0xb09/0x19c0 mm/filemap.c:2527
ext4_filemap_fault+0x7b/0x90 fs/ext4/inode.c:6416
__do_fault mm/memory.c:3196 [inline]
do_read_fault mm/memory.c:3596 [inline]
do_fault mm/memory.c:3725 [inline]
handle_pte_fault mm/memory.c:3956 [inline]
__handle_mm_fault mm/memory.c:4080 [inline]
handle_mm_fault+0x29c3/0x42f0 mm/memory.c:4117
do_user_addr_fault+0x4a0/0xb40 arch/x86/mm/fault.c:1469
page_fault+0x2f/0x40 arch/x86/entry/entry_64.S:1203
RIP: 0033:0x7fd99640b21d
Code: Bad RIP value.
RSP: 002b:00007ffdd4d85810 EFLAGS: 00010207
RAX: 0000000000000001 RBX: 000056010a4a6d10 RCX: 00007fd994d3e303
RDX: 0000000000000001 RSI: 00007ffdd4d85810 RDI: 0000000000000000
RBP: 00007ffdd4d85ac0 R08: 431bde82d7b634db R09: 0000000000000bd0
R10: 00000000ffffffff R11: 0000000000000000 R12: 00007ffdd4d85810
R13: 0000000000000001 R14: ffffffffffffffff R15: 0000000000000002
Allocated by task 341:
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
__kasan_kmalloc+0x137/0x1e0 mm/kasan/common.c:517
kmem_cache_alloc_trace+0x139/0x2b0 mm/slub.c:2848
kmalloc include/linux/slab.h:556 [inline]
__vring_new_virtqueue+0x141/0xd40 drivers/virtio/virtio_ring.c:2071
vring_create_virtqueue_split drivers/virtio/virtio_ring.c:894 [inline]
vring_create_virtqueue+0x1830/0x1d00 drivers/virtio/virtio_ring.c:2152
setup_vq+0x161/0x370 drivers/virtio/virtio_pci_legacy.c:137
vp_setup_vq+0xbc/0x330 drivers/virtio/virtio_pci_common.c:189
vp_find_vqs_msix+0x88b/0xc40 drivers/virtio/virtio_pci_common.c:323
vp_find_vqs+0x45/0x4a0 drivers/virtio/virtio_pci_common.c:400
virtio_find_vqs include/linux/virtio_config.h:197 [inline]
virtscsi_init+0x490/0xa60 drivers/scsi/virtio_scsi.c:807
virtscsi_restore+0xe2/0xe90 drivers/scsi/virtio_scsi.c:941
virtio_device_restore+0x39c/0x5a0 drivers/virtio/virtio.c:413
dpm_run_callback drivers/base/power/main.c:487 [inline]
device_resume+0x543/0x910 drivers/base/power/main.c:1029
async_resume+0x23/0x170 drivers/base/power/main.c:1049
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Freed by task 351:
set_track mm/kasan/common.c:78 [inline]
__kasan_kmalloc+0x137/0x1e0 mm/kasan/common.c:517
kmem_cache_alloc_trace+0x139/0x2b0 mm/slub.c:2848
kmalloc include/linux/slab.h:556 [inline]
__vring_new_virtqueue+0x141/0xd40 drivers/virtio/virtio_ring.c:2071
vring_create_virtqueue_split drivers/virtio/virtio_ring.c:894 [inline]
vring_create_virtqueue+0x1830/0x1d00 drivers/virtio/virtio_ring.c:2152
setup_vq+0x161/0x370 drivers/virtio/virtio_pci_legacy.c:137
vp_setup_vq+0xbc/0x330 drivers/virtio/virtio_pci_common.c:189
vp_find_vqs_msix+0x88b/0xc40 drivers/virtio/virtio_pci_common.c:323
vp_find_vqs+0x45/0x4a0 drivers/virtio/virtio_pci_common.c:400
virtio_find_vqs include/linux/virtio_config.h:197 [inline]
virtscsi_init+0x490/0xa60 drivers/scsi/virtio_scsi.c:807
virtscsi_restore+0xe2/0xe90 drivers/scsi/virtio_scsi.c:941
virtio_device_restore+0x39c/0x5a0 drivers/virtio/virtio.c:413
dpm_run_callback drivers/base/power/main.c:487 [inline]
device_resume+0x543/0x910 drivers/base/power/main.c:1029
async_resume+0x23/0x170 drivers/base/power/main.c:1049
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
save_stack mm/kasan/common.c:70 [inline]
set_track mm/kasan/common.c:78 [inline]
kasan_set_free_info mm/kasan/common.c:333 [inline]
__kasan_slab_free+0x18a/0x240 mm/kasan/common.c:475
slab_free_hook mm/slub.c:1454 [inline]
slab_free_freelist_hook+0x7b/0x150 mm/slub.c:1492
slab_free mm/slub.c:3072 [inline]
kfree+0xe0/0x660 mm/slub.c:4061
vp_del_vq drivers/virtio/virtio_pci_common.c:221 [inline]
vp_del_vqs+0x37c/0x8c0 drivers/virtio/virtio_pci_common.c:243
virtscsi_remove_vqs drivers/scsi/virtio_scsi.c:772 [inline]
virtscsi_freeze+0x8d/0xa0 drivers/scsi/virtio_scsi.c:931
virtio_pci_freeze+0x39/0x70 drivers/virtio/virtio_pci_common.c:466
pci_pm_suspend+0x2dc/0x910 drivers/pci/pci-driver.c:789
dpm_run_callback drivers/base/power/main.c:487 [inline]
__device_suspend+0x84c/0x1300 drivers/base/power/main.c:1816
async_suspend+0x25/0x1f0 drivers/base/power/main.c:1848
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
The buggy address belongs to the object at ffff8881e1690100
set_track mm/kasan/common.c:78 [inline]
kasan_set_free_info mm/kasan/common.c:333 [inline]
__kasan_slab_free+0x18a/0x240 mm/kasan/common.c:475
slab_free_hook mm/slub.c:1454 [inline]
slab_free_freelist_hook+0x7b/0x150 mm/slub.c:1492
slab_free mm/slub.c:3072 [inline]
kfree+0xe0/0x660 mm/slub.c:4061
vp_del_vq drivers/virtio/virtio_pci_common.c:221 [inline]
vp_del_vqs+0x37c/0x8c0 drivers/virtio/virtio_pci_common.c:243
virtscsi_remove_vqs drivers/scsi/virtio_scsi.c:772 [inline]
virtscsi_freeze+0x8d/0xa0 drivers/scsi/virtio_scsi.c:931
virtio_pci_freeze+0x39/0x70 drivers/virtio/virtio_pci_common.c:466
pci_pm_suspend+0x2dc/0x910 drivers/pci/pci-driver.c:789
dpm_run_callback drivers/base/power/main.c:487 [inline]
__device_suspend+0x84c/0x1300 drivers/base/power/main.c:1816
async_suspend+0x25/0x1f0 drivers/base/power/main.c:1848
async_run_entry_fn+0xea/0x3c0 kernel/async.c:123
process_one_work+0x679/0x1030 kernel/workqueue.c:2277
worker_thread+0xa6f/0x1400 kernel/workqueue.c:2423
kthread+0x30f/0x330 kernel/kthread.c:268
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
which belongs to the cache kmalloc-192 of size 192
The buggy address is located 56 bytes inside of
192-byte region [ffff8881e1690100, ffff8881e16901c0)
The buggy address is located 56 bytes inside of
The buggy address belongs to the page:
page:ffffea000785a400 refcount:1 mapcount:0 mapping:ffff8881f5c02a00 index:0x0
flags: 0x8000000000000200(slab)
raw: 8000000000000200 ffffea0007885240 0000000400000004 ffff8881f5c02a00
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY)
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook mm/page_alloc.c:2165 [inline]
prep_new_page+0x19a/0x380 mm/page_alloc.c:2171
get_page_from_freelist+0x550/0x8b0 mm/page_alloc.c:3794
__alloc_pages_nodemask+0x3a2/0x880 mm/page_alloc.c:4855
alloc_slab_page+0x39/0x3e0 mm/slub.c:342
allocate_slab mm/slub.c:1675 [inline]
new_slab+0x97/0x460 mm/slub.c:1741
new_slab_objects mm/slub.c:2498 [inline]
___slab_alloc+0x330/0x4c0 mm/slub.c:2659
__slab_alloc mm/slub.c:2699 [inline]
slab_alloc_node mm/slub.c:2784 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc_trace+0x199/0x2b0 mm/slub.c:2846
kmalloc include/linux/slab.h:556 [inline]
kzalloc include/linux/slab.h:690 [inline]
kernfs_fop_open+0x321/0xad0 fs/kernfs/file.c:647
post_alloc_hook mm/page_alloc.c:2165 [inline]
prep_new_page+0x19a/0x380 mm/page_alloc.c:2171
get_page_from_freelist+0x550/0x8b0 mm/page_alloc.c:3794
__alloc_pages_nodemask+0x3a2/0x880 mm/page_alloc.c:4855
alloc_slab_page+0x39/0x3e0 mm/slub.c:342
allocate_slab mm/slub.c:1675 [inline]
new_slab+0x97/0x460 mm/slub.c:1741
new_slab_objects mm/slub.c:2498 [inline]
___slab_alloc+0x330/0x4c0 mm/slub.c:2659
__slab_alloc mm/slub.c:2699 [inline]
slab_alloc_node mm/slub.c:2784 [inline]
slab_alloc mm/slub.c:2829 [inline]
kmem_cache_alloc_trace+0x199/0x2b0 mm/slub.c:2846
kmalloc include/linux/slab.h:556 [inline]
kzalloc include/linux/slab.h:690 [inline]
do_dentry_open+0x949/0x1100 fs/open.c:796
do_last fs/namei.c:3495 [inline]
path_openat+0x1127/0x3da0 fs/namei.c:3612
do_filp_open+0x208/0x450 fs/namei.c:3642
do_sys_open+0x383/0x7c0 fs/open.c:1113
do_syscall_64+0xcb/0x1e0 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1176 [inline]
free_pcp_prepare+0x1a9/0x270 mm/page_alloc.c:1233
free_unref_page_prepare mm/page_alloc.c:3085 [inline]
free_unref_page mm/page_alloc.c:3134 [inline]
free_the_page mm/page_alloc.c:4915 [inline]
__free_pages+0x9c/0x250 mm/page_alloc.c:4923
selinux_genfs_get_sid security/selinux/hooks.c:1367 [inline]
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1176 [inline]
free_pcp_prepare+0x1a9/0x270 mm/page_alloc.c:1233
free_unref_page_prepare mm/page_alloc.c:3085 [inline]
free_unref_page mm/page_alloc.c:3134 [inline]
free_the_page mm/page_alloc.c:4915 [inline]
__free_pages+0x9c/0x250 mm/page_alloc.c:4923
inode_doinit_with_dentry+0xb34/0x11d0 security/selinux/hooks.c:1562
security_d_instantiate+0xa5/0x100 security/security.c:1882
d_splice_alias+0x71/0x590 fs/dcache.c:3010
kernfs_iop_lookup+0x17a/0x1f0 fs/kernfs/dir.c:1104
__lookup_slow+0x2f8/0x450 fs/namei.c:1748
lookup_slow fs/namei.c:1765 [inline]
walk_component+0x3e1/0x960 fs/namei.c:1885
lookup_last fs/namei.c:2348 [inline]
path_lookupat+0x219/0xa40 fs/namei.c:2393
filename_lookup+0x223/0x6a0 fs/namei.c:2423
user_path_at include/linux/namei.h:49 [inline]
do_faccessat+0x323/0x7a0 fs/open.c:398
do_syscall_64+0xcb/0x1e0 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Memory state around the buggy address:
ffff8881e1690000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Memory state around the buggy address:
ffff8881e1690080: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff8881e1690100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881e1690180: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881e1690200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================
Reply all
Reply to author
Forward
0 new messages