[Android 5.10] BUG: soft lockup in tc_modify_qdisc

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 59b65efafe20 Revert "gpio: Allow per-parent interrupt data"
git tree: android13-5.10-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=15ec3c4ca80000
kernel config: https://syzkaller.appspot.com/x/.config?x=88bb808f093a622
dashboard link: https://syzkaller.appspot.com/bug?extid=7172c9f3c3b9f1d10872
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11684544a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=178128b0a80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e1cc205946a4/disk-59b65efa.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/05df9ac34d65/vmlinux-59b65efa.xz
kernel image: https://storage.googleapis.com/syzbot-assets/61bb98dc00cb/bzImage-59b65efa.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7172c9...@syzkaller.appspotmail.com

RBP: 0000000000000000 R08: 00007ffe4819bda0 R09: 00007ffe4819bda0
R10: 00007ffe4819bda0 R11: 0000000000000246 R12: 00007ffe4819bd9c
R13: 0000000000000000 R14: 00007ffe4819bdb0 R15: 0000000000000000
watchdog: BUG: soft lockup - CPU#0 stuck for 123s! [syz-executor396:289]
Modules linked in:
CPU: 0 PID: 289 Comm: syz-executor396 Not tainted 5.10.186-syzkaller-01315-g59b65efafe20 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
RIP: 0010:native_restore_fl arch/x86/include/asm/irqflags.h:41 [inline]
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/irqflags.h:84 [inline]
RIP: 0010:kvm_wait+0xfc/0x150 arch/x86/kernel/kvm.c:926
Code: 38 f0 75 26 41 f7 c7 00 02 00 00 75 0f 0f 1f 44 00 00 0f 00 2d 05 48 d5 03 f4 eb 0e 0f 1f 44 00 00 0f 00 2d f6 47 d5 03 fb f4 <4c> 89 7c 24 18 ff 74 24 18 9d 48 c7 44 24 20 0e 36 e0 45 49 c7 04
RSP: 0018:ffffc9000096eb00 EFLAGS: 00000246
RAX: 0000000000000003 RBX: 1ffff9200012dd64 RCX: ffffffff8150a3c4
RDX: 0000000000000001 RSI: 0000000000000003 RDI: ffffc9000096eb40
RBP: ffffc9000096ebb0 R08: dffffc0000000000 R09: ffffed1022c7aa16
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: ffff8881163d50ac R14: 0000000000000003 R15: 0000000000000246
FS: 000055555694a300(0000) GS:ffff8881f7000000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000458e30 CR3: 000000011c8d6000 CR4: 00000000003506b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
</IRQ>
pv_wait arch/x86/include/asm/paravirt.h:564 [inline]
pv_wait_head_or_lock kernel/locking/qspinlock_paravirt.h:470 [inline]
__pv_queued_spin_lock_slowpath+0x72f/0xc70 kernel/locking/qspinlock.c:508
pv_queued_spin_lock_slowpath arch/x86/include/asm/paravirt.h:554 [inline]
queued_spin_lock_slowpath arch/x86/include/asm/qspinlock.h:51 [inline]
queued_spin_lock include/asm-generic/qspinlock.h:85 [inline]
do_raw_spin_lock include/linux/spinlock.h:183 [inline]
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:136 [inline]
_raw_spin_lock_bh+0x139/0x1b0 kernel/locking/spinlock.c:175
spin_lock_bh include/linux/spinlock.h:359 [inline]
get_dist_table+0x207/0x2e0 net/sched/sch_netem.c:798
netem_change+0x974/0x1fb0 net/sched/sch_netem.c:988
netem_init+0x5b/0xb0 net/sched/sch_netem.c:1075
qdisc_create+0x879/0x12d0 net/sched/sch_api.c:1264
tc_modify_qdisc+0x8a4/0x13f0
rtnetlink_rcv_msg+0x955/0xc50 net/core/rtnetlink.c:5571
netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2496
rtnetlink_rcv+0x1c/0x20 net/core/rtnetlink.c:5589
netlink_unicast_kernel net/netlink/af_netlink.c:1322 [inline]
netlink_unicast+0x8df/0xac0 net/netlink/af_netlink.c:1348
netlink_sendmsg+0xa46/0xd00 net/netlink/af_netlink.c:1915
sock_sendmsg_nosec net/socket.c:652 [inline]
sock_sendmsg net/socket.c:672 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2357
___sys_sendmsg+0x252/0x2e0 net/socket.c:2411
__sys_sendmsg net/socket.c:2440 [inline]
__do_sys_sendmsg net/socket.c:2449 [inline]
__se_sys_sendmsg+0x1b1/0x280 net/socket.c:2447
__x64_sys_sendmsg+0x7b/0x90 net/socket.c:2447
do_syscall_64+0x34/0x70
entry_SYSCALL_64_after_hwframe+0x61/0xc6
RIP: 0033:0x7f113a3e2859
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe4819bd78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f113a3e2859
RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000003
RBP: 0000000000000000 R08: 00007ffe4819bda0 R09: 00007ffe4819bda0
R10: 00007ffe4819bda0 R11: 0000000000000246 R12: 00007ffe4819bd9c
R13: 0000000000000000 R14: 00007ffe4819bdb0 R15: 0000000000000000


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 879959450ec7 Revert "gpio: Allow per-parent interrupt data"
git tree: android13-5.15-lts
console+strace: https://syzkaller.appspot.com/x/log.txt?x=12cb8264a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=abc1ff3f961b3663
dashboard link: https://syzkaller.appspot.com/bug?extid=f9a0a3f9246bec7950e4

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=169c3c4ca80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=112b77e8a80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/19790299aa5a/disk-87995945.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4b49a0d0a449/vmlinux-87995945.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f3748dd46658/bzImage-87995945.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+f9a0a3...@syzkaller.appspotmail.com

RBP: 00007f04566213e0 R08: 0000000000000004 R09: 0000000000000000
R10: 000000000000000c R11: 0000000000000246 R12: 00007f04566213ec
R13: 00007ffe92e5bf8f R14: 00007f0456548300 R15: 0000000000022000
</TASK>
watchdog: BUG: soft lockup - CPU#1 stuck for 225s! [syz-executor152:297]
Modules linked in:
CPU: 1 PID: 297 Comm: syz-executor152 Not tainted 5.15.119-syzkaller-01849-g879959450ec7 #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023

RIP: 0010:native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
RIP: 0010:arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
RIP: 0010:kvm_wait+0x147/0x180 arch/x86/kernel/kvm.c:918
Code: 4c 89 e8 48 c1 e8 03 42 0f b6 04 20 84 c0 44 8b 74 24 1c 75 34 41 0f b6 45 00 44 38 f0 75 10 66 90 0f 00 2d ab ff f2 03 fb f4 <e9> 24 ff ff ff fb e9 1e ff ff ff 44 89 e9 80 e1 07 38 c1 7c a3 4c
RSP: 0018:ffffc90000986b00 EFLAGS: 00000246
RAX: 0000000000000003 RBX: 1ffff92000130d64 RCX: ffffffff8154cacf
RDX: dffffc0000000000 RSI: 0000000000000003 RDI: ffff888113f9dcac
RBP: ffffc90000986bb0 R08: dffffc0000000000 R09: ffffed10227f3b96

R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000

R13: ffff888113f9dcac R14: 0000000000000003 R15: 1ffff92000130d68
FS: 00007f0456548700(0000) GS:ffff8881f7100000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000000458e30 CR3: 000000011d2ba000 CR4: 00000000003506a0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
</IRQ>

<TASK>
pv_wait arch/x86/include/asm/paravirt.h:597 [inline]
pv_wait_head_or_lock kernel/locking/qspinlock_paravirt.h:470 [inline]
__pv_queued_spin_lock_slowpath+0x6bc/0xc40 kernel/locking/qspinlock.c:508
pv_queued_spin_lock_slowpath arch/x86/include/asm/paravirt.h:585 [inline]

queued_spin_lock_slowpath arch/x86/include/asm/qspinlock.h:51 [inline]
queued_spin_lock include/asm-generic/qspinlock.h:85 [inline]

do_raw_spin_lock include/linux/spinlock.h:187 [inline]
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:136 [inline]
_raw_spin_lock_bh+0x139/0x1b0 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:368 [inline]
get_dist_table+0x207/0x2e0 net/sched/sch_netem.c:798
netem_change+0xa05/0x20c0 net/sched/sch_netem.c:988
netem_init+0x5b/0xb0 net/sched/sch_netem.c:1075
qdisc_create+0x890/0x12e0 net/sched/sch_api.c:1264
tc_modify_qdisc+0x8b4/0x14b0
rtnetlink_rcv_msg+0x951/0xc40 net/core/rtnetlink.c:5593
netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2504
rtnetlink_rcv+0x1c/0x20 net/core/rtnetlink.c:5611
netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
netlink_unicast+0x8df/0xac0 net/netlink/af_netlink.c:1356
netlink_sendmsg+0xa0a/0xd20 net/netlink/af_netlink.c:1923
sock_sendmsg_nosec net/socket.c:704 [inline]
sock_sendmsg net/socket.c:724 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2412
___sys_sendmsg+0x252/0x2e0 net/socket.c:2466
__sys_sendmsg net/socket.c:2495 [inline]
__do_sys_sendmsg net/socket.c:2504 [inline]
__se_sys_sendmsg+0x19a/0x260 net/socket.c:2502
__x64_sys_sendmsg+0x7b/0x90 net/socket.c:2502
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f045659f819
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 01 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0456548208 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f04566213e8 RCX: 00007f045659f819

RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000003

RBP: 00007f04566213e0 R08: 0000000000000004 R09: 0000000000000000
R10: 000000000000000c R11: 0000000000000246 R12: 00007f04566213ec
R13: 00007ffe92e5bf8f R14: 00007f0456548300 R15: 0000000000022000
</TASK>
Sending NMI from CPU 1 to CPUs 0:
NMI backtrace for cpu 0 skipped: idling at native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
NMI backtrace for cpu 0 skipped: idling at arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
NMI backtrace for cpu 0 skipped: idling at acpi_safe_halt drivers/acpi/processor_idle.c:109 [inline]
NMI backtrace for cpu 0 skipped: idling at acpi_idle_do_entry drivers/acpi/processor_idle.c:570 [inline]
NMI backtrace for cpu 0 skipped: idling at acpi_idle_enter+0x416/0x760 drivers/acpi/processor_idle.c:705

[syzbot]

syzbot has bisected this issue to:

commit bc75968b494ab9991e855ab429e850d415ac835e
Author: Eric Dumazet <edum...@google.com>
Date: Tue Jun 20 18:44:25 2023 +0000

sch_netem: acquire qdisc lock in netem_change()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1795a590a80000
start commit: 59b65efafe20 Revert "gpio: Allow per-parent interrupt data"
git tree: android13-5.10-lts
final oops: https://syzkaller.appspot.com/x/report.txt?x=1455a590a80000
console output: https://syzkaller.appspot.com/x/log.txt?x=1055a590a80000

kernel config: https://syzkaller.appspot.com/x/.config?x=88bb808f093a622
dashboard link: https://syzkaller.appspot.com/bug?extid=7172c9f3c3b9f1d10872

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11684544a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=178128b0a80000

Reported-by: syzbot+7172c9...@syzkaller.appspotmail.com
Fixes: bc75968b494a ("sch_netem: acquire qdisc lock in netem_change()")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

syzbot has bisected this issue to:

commit c1a2b52d999e9f7d31f2c7de459a2f3269d5fdf4

Author: Eric Dumazet <edum...@google.com>
Date: Tue Jun 20 18:44:25 2023 +0000

sch_netem: acquire qdisc lock in netem_change()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15f02688a80000
start commit: 879959450ec7 Revert "gpio: Allow per-parent interrupt data"
git tree: android13-5.15-lts
final oops: https://syzkaller.appspot.com/x/report.txt?x=17f02688a80000
console output: https://syzkaller.appspot.com/x/log.txt?x=13f02688a80000

kernel config: https://syzkaller.appspot.com/x/.config?x=abc1ff3f961b3663
dashboard link: https://syzkaller.appspot.com/bug?extid=f9a0a3f9246bec7950e4

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=169c3c4ca80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=112b77e8a80000

Reported-by: syzbot+f9a0a3...@syzkaller.appspotmail.com
Fixes: c1a2b52d999e ("sch_netem: acquire qdisc lock in netem_change()")

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 3b55ce96efc5e6722d8374e04d9f721cc29e4d4b
Author: Eric Dumazet <edum...@google.com>
Date: Thu Jun 22 18:15:03 2023 +0000

sch_netem: fix issues in netem_change() vs get_dist_table()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1097e13e680000
start commit: c6a1fbd8e4aa Merge 5.10.189 into android13-5.10-lts
git tree: android13-5.10-lts
kernel config: https://syzkaller.appspot.com/x/.config?x=acb6666d552b65cc
dashboard link: https://syzkaller.appspot.com/bug?extid=7172c9f3c3b9f1d10872
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=176f4c8fa80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1215a857a80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: sch_netem: fix issues in netem_change() vs get_dist_table()

[syzbot]

syzbot suspects this issue was fixed by commit:

commit af99918f0e39aeb14d2cd08ca79faf9ccb1ec47f

Author: Eric Dumazet <edum...@google.com>
Date: Thu Jun 22 18:15:03 2023 +0000

sch_netem: fix issues in netem_change() vs get_dist_table()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11a14be1680000
start commit: 83c56fbab45d Merge 5.15.123 into android13-5.15-lts
git tree: android13-5.15-lts
kernel config: https://syzkaller.appspot.com/x/.config?x=ae44a30bf69d64a6
dashboard link: https://syzkaller.appspot.com/bug?extid=f9a0a3f9246bec7950e4
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1346cb87a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12e021e0680000

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.

[syzbot]