Help needed: guidance on group theory
106 views
Skip to first unread message
Voaides Negustor Robert
Mar 16, 2025, 12:41:13 PM3/16/25
to sympy
Hello everyone,
I’ve submitted a PR (#27730) adding functionality to sympy.combinatorics, specfically for permutation groups, but it has gone unnoticed. I couldn’t find a reviewer familiar with the module.
If anyone can review it or point me to the right person, I’d really appreciate it.
Best,
Robert
Oscar Benjamin
Mar 29, 2025, 9:04:16 AM3/29/25
to sy...@googlegroups.com
The problem with that PR is that it is for a part of the codebase that
is not known well by any of the regular sympy contributors. The code
as implemented seems to come from the linked issue but there that code
was shown by someone who was asking about it rather than making a
clear claim that the code is correct.
If anyone else on the mailing list here has experience with sympy's
group theory functionality then it would be good if they can verify
whether or not the code is correct.
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/sympy/0769de67-526a-4ba4-85ec-b2e461fefd40n%40googlegroups.com.
is not known well by any of the regular sympy contributors. The code
as implemented seems to come from the linked issue but there that code
was shown by someone who was asking about it rather than making a
clear claim that the code is correct.
If anyone else on the mailing list here has experience with sympy's
group theory functionality then it would be good if they can verify
whether or not the code is correct.
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/sympy/0769de67-526a-4ba4-85ec-b2e461fefd40n%40googlegroups.com.
Voaides Negustor Robert
Mar 30, 2025, 2:12:28 PM3/30/25
to sympy
The algorithm in itself, as seen in the issue, is further detailed in the handbook of computational group theory, from which I have done more serious research.
So I think it should be correct.
However, review is greatly appreciated.
Oscar Benjamin
Mar 30, 2025, 4:04:33 PM3/30/25
to sy...@googlegroups.com
I'm not going to read a textbook to review the pull request. Please
explain clearly on the pull request what the code does, where the
algorithm comes from, why it is correct and whether it is reasonable
from a performance perspective.
Don't assume that anyone reviewing the pull request understands even
what any of the relevant sympy functions does (I don't). I'm happy to
review it but you will need to convince me that it is correct without
me needing to spend any significant time going over that part of the
codebase.
On Sun, 30 Mar 2025 at 19:12, Voaides Negustor Robert
> To view this discussion visit https://groups.google.com/d/msgid/sympy/fa4bb130-ec4f-4797-ada4-43abe1a7df84n%40googlegroups.com.
explain clearly on the pull request what the code does, where the
algorithm comes from, why it is correct and whether it is reasonable
from a performance perspective.
Don't assume that anyone reviewing the pull request understands even
what any of the relevant sympy functions does (I don't). I'm happy to
review it but you will need to convince me that it is correct without
me needing to spend any significant time going over that part of the
codebase.
On Sun, 30 Mar 2025 at 19:12, Voaides Negustor Robert
Voaides Negustor Robert
Apr 1, 2025, 2:50:26 AM4/1/25
to sympy
This is very helpful guidance, thank you!
Reply all
Reply to author
Forward
0 new messages