Beam bending Module

53 views
Skip to first unread message

SAMPAD SAHA

unread,
Jul 7, 2016, 1:48:53 PM7/7/16
to sy...@googlegroups.com, Sartaj Singh, Jason K. Moore, Aaron Meurer
In PR #11266 I want to use the functionalities of Singularity Functions. The functionalities have been inplemented at PR  #11237  and #11178 . What should I do now? Should I wait untill both the PRs of Singularity Functions gets merged or is there any other ways?

Thanking You

Regards
Sampad Kumar Saha
Mathematics and Computing
I.I.T. Kharagpur



Jason Moore

unread,
Jul 7, 2016, 2:00:14 PM7/7/16
to sy...@googlegroups.com
You can create a new branch and merge in 11237 and 11178, then start adding new commits. Once the two prereq branches are merged your new branch will merge cleanly into master.

--
You received this message because you are subscribed to the Google Groups "sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
To post to this group, send email to sy...@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CANzav4FP4C-mi7QU0n8uCLh%3DZrUOv%3DR-%2B-EqFbJ7ZJ6KBJrbtA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

SAMPAD SAHA

unread,
Jul 7, 2016, 2:22:51 PM7/7/16
to sy...@googlegroups.com
I will create a new branch form ##11266. Then How to merge in 11237 and 11178 ?




Regards
Sampad Kumar Saha
Mathematics and Computing
I.I.T. Kharagpur

Aaron Meurer

unread,
Jul 7, 2016, 3:03:23 PM7/7/16
to sy...@googlegroups.com
Use, for instance,

git merge SF_integration

That will merge in the SF_integration branch. 

Word of warning: avoid rebasing any of your branches if you do this. Otherwise, you will end up with duplicate commits. 

Aaron Meurer

SAMPAD SAHA

unread,
Jul 7, 2016, 3:07:32 PM7/7/16
to sy...@googlegroups.com


> Word of warning: avoid rebasing any of your branches if you do this. Otherwise, you will end up with duplicate commits. 

Due to this reason, sometimes I feel like to wait for the other two branches to be merged.


Regards
Sampad Kumar Saha
Mathematics and Computing
I.I.T. Kharagpur

Aaron Meurer

unread,
Jul 7, 2016, 3:13:28 PM7/7/16
to sy...@googlegroups.com
Well you shouldn't stall your work because of this. 

This is only an issue specifically if you use the "git rebase" command. If you only use the "git merge" command to resolve conflicts, there won't be an issue, because git merge doesn't create duplicate commits. In general, avoid any command that requires you to force push. 

Even so, this can get complicated, because you may have to merge in changes from your branches if you need them, and it can be hard to keep track of what change should go in what branch, so if it is possible to merge the pull requests first, I would recommend it. 

Aaron Meurer

SAMPAD SAHA

unread,
Jul 7, 2016, 3:17:34 PM7/7/16
to sy...@googlegroups.com
Even so, this can get complicated, because you may have to merge in changes from your branches if you need them, and it can be hard to keep track of what change should go in what branch, so if it is possible to merge the pull requests first, I would recommend it. 

I too believe in this. Thank You. 

I will try to use `git merge`. But actually I am worried, if this gets complicated.




Regards
Sampad Kumar Saha
Mathematics and Computing
I.I.T. Kharagpur

SAMPAD SAHA

unread,
Jul 9, 2016, 7:18:08 PM7/9/16
to sy...@googlegroups.com
Thank You Aaron. It was quite easy and straight forward.




Regards
Sampad Kumar Saha
Mathematics and Computing
I.I.T. Kharagpur

Reply all
Reply to author
Forward
0 new messages