subset() : why not is_subset() ?

[Amit Saha]

Is there any reason why the subset() method in sympy/core/sets.py is
not is_subset() (considering that it always returns a boolean) and
also consistent with some of the other is_ methods as well.?

Best,
Amit.


--
http://echorand.me

[Aaron Meurer]

I agree. The builtin set's method is called issubset.

Aaron Meurer

> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CANODV3mcy-XR6yt75EbbrSoNuM7P%2B-bJoY1kBR1fzVg6qBJ%2BQw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

[Amit Saha]

On Tue, Mar 25, 2014 at 11:18 AM, Aaron Meurer <asme...@gmail.com> wrote:
> I agree. The builtin set's method is called issubset.

Before I work on the patch, what is the strategy to make backward
incompatible changes? Since, existing users may be surprised if we
suddenly remove the method and replace it by another one and even
break their existing code.

Suggestions will be helpful.

[Sergey Kirpichev]

On Tuesday, March 25, 2014 2:14:10 PM UTC+4, Amit Saha wrote:

Before I work on the patch, what is the strategy to make backward
incompatible changes? Since, existing users may be surprised if we
suddenly remove the method and replace it by another one and even
break their existing code.

I suggest you to take look on the code around.  We have
a lot of bugs with  DeprecationRemoval label.

In this particular example, you should rename method and then
add @deprecated decorator.

[Aaron Meurer]

Yes, read the docstring of SymPyDeprecationWarning, and grep the code
for @deprecated.

Aaron Meurer

> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sympy.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/sympy/d446c0eb-284c-4ac9-b570-caf7aee42b86%40googlegroups.com.

[Amit Saha]

Thanks, I have submitted the pull request with the change:
https://github.com/sympy/sympy/pull/7346

Suggestions and comments appreciated.