workflow for continuing an existing PR

[Stefan W]

Hi,

I have a question: if the author of a PR is inactive, is it possible for someone else to continue their work without opening a new PR (meaning, branching from their branch, and continuing work) ? What would be a best practice for this?

Thanks,

Stefan

[Aaron Meurer]

You can revive an existing PR if the author isn't working on it any
more. See https://github.com/sympy/sympy/wiki/Reviving-pull-requests.

It isn't possible for you to reuse the same PR unless you have push
access. In that case, it is fine to close the PR and open a new one
that references the old one. The important thing is to leave the
original commits intact so that the authorship stays (only push new
commits, don't squash your commits into the other person's).

Aaron Meurer

> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/69a12ed3-4106-48ae-a90f-d39249149033n%40googlegroups.com.

[Oscar Benjamin]

If the original commit history is messy I would recommend squashing
the original commits and using "coauthored-by" to attribute the
original author. It's best to do this before making your own commits
on top.

Oscar

> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6Jxx7Q91HCjREc5cgF6_KtXzHLZ%3D4wsEvwExamHKg4k8w%40mail.gmail.com.