fixes #8239

60 views
Skip to first unread message

Akshat Jain

unread,
Nov 16, 2014, 9:08:34 AM11/16/14
to sy...@googlegroups.com
This is in reference to issue #8239
I am new. I submitted my first  patch but Travic Ci gave "This branch has failed checks, but can be merged." ? What does this mean? Is it accepted or rejected?
Or what changes should I make?

Sushant Hiray

unread,
Nov 16, 2014, 9:17:08 AM11/16/14
to sy...@googlegroups.com
Hi Akshat,

If github says it can be merged, it just means that there are no merge conflicts between your changes and the master branch.

On the other hand, sometimes Travis tests just run out of time. Your tests have been restarted again. You can have a look at their status here

You can as well look into travis logs to see why tests failed. If it shows timeout error then you can ask
the project admins to restart the builds.

Hope this helps,

Sushant

Sushant Hiray,
Senior Undergrad CSE,
IIT Bombay



--
You received this message because you are subscribed to the Google Groups "sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
To post to this group, send email to sy...@googlegroups.com.
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/93eb19c0-fa1a-489d-841e-3867ea3faaba%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Joachim Durchholz

unread,
Nov 16, 2014, 9:21:45 AM11/16/14
to sy...@googlegroups.com
Am 16.11.2014 um 15:08 schrieb Akshat Jain:
> This is in reference to issue #8239
> I am new. I submitted my first patch but Travic Ci gave "This branch has
> failed checks, but can be merged." ? What does this mean? Is it accepted or
> rejected?

It is neither accepted nor rejected, it's just a fix that lives in your
personal copy of the repository and has not yet been pulled into SymPy.

"Failed checks" means that some of the unit tests failed.

> Or what changes should I make?

Look into the Travis logs and see what errors have been reported.
Fix them, then re-push to your Github repository and see what Travis
reports.

Sergey Kirpichev

unread,
Nov 16, 2014, 10:43:51 AM11/16/14
to sy...@googlegroups.com


On Sunday, November 16, 2014 5:21:45 PM UTC+3, Joachim Durchholz wrote:
Look into the Travis logs and see what errors have been reported.
Fix them, then re-push to your Github repository and see what Travis
reports.

A slight correction: "Fix them"  -> "Fix them, test locally"

See
https://github.com/sympy/sympy/wiki/Development-workflow#be-sure-that-all-tests-of-sympy-pass
Reply all
Reply to author
Forward
0 new messages