Pull Request issue:8984

[Vaibhav Raj]

Hi all! I,Vaibhav Raj am a second year Compute Science student at Indian Institue of Technology Rookee.I have recently started contributing to sympy and successfully made a pull request for the issue:8984.Pls consider it and suggest me for new bugs and relevant work.

Thankyou

[Joachim Durchholz]

For some reason, 1,266 (all?) files were marked world-writable, then
that change was committed and included in the PR.
The actual fix does not seem to have gone in, github is reporting "0
additions, 0 deletions" for the PR.

HTH
Jo

[Ramana Venkata]

Hi Vaibhav,

I think you must follows this guide https://github.com/sympy/sympy/wiki/Development-workflow once before you send a Pull Request especially if you have not used git or Github in the past. This guide explains the correct way to setup up development environment, how create a branch, how to commit you changes, how to push to a remote branch, how to rebase against master etc., 

It seems somebody already sent a PR just before you https://github.com/sympy/sympy/pull/8985 .  So, I suggest you to pick up another easy to fix issue https://github.com/sympy/sympy/issues?q=is%3Aopen+label%3A%22Easy+to+Fix%22+is%3Aissue and work on it. After you think it's ready, go over the steps given in the Development Workflow wiki page make sure you have got everything correct. then send in the PR. If you have trouble understanding any step or having difficult fixing the issue,  feel free to ask here or on the sympy's gitter channel.