General query regarding code reviews

[Rushabh Mehta]

Hello sympy community,

I noticed that there are a lot of pull requests made by beginning contributors which have simple issues like a whitespace code quality check fail, authors fail etc. While these are small problems, they can slow down the review process and discourage new contributors. I feel that they should be pointed to the right direction as soon as possible, this will reduce the load on the more experienced developers and make the PR process faster for the new contributors. So my main question is "At what point can a person review their first pull request?". Any advice / rule of thumb is appreciated. 

Regards,

Rushabh Mehta

[Oscar Benjamin]

Hi Rushabh,

There are no rules about who can review pull requests. If you are
reasonably confident that you can offer helpful advice, suggestions or
opinions then go ahead. As I am sure you have noticed there are more
pull requests in need of review than there are people who have the
time to go through and review them all.

Oscar

> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/sympy/1179d09a-9e28-48f6-b248-34a568b0f1abn%40googlegroups.com.

[Rushabh Mehta]

Thanks so much for the quick response! I will check the open PRs from newer contributors and try to help them out! I'm told that code reviewing is a major part of software development.