Pull Request to fix

21 views
Skip to first unread message

Greg Laabs

unread,
Apr 23, 2019, 3:47:01 PM4/23/19
to sucks-users
Hey everyone,

I have submitted a PR to fix the issues Home Assistant (and others) users have been having with sucks due to certificate issues. I explained the rationale for the fix in the PR: https://github.com/wpietri/sucks/pull/67

I'd love some eyes on it so we can get it merged, published, and push a new version of Home Assistant to get the fix.

Greg Laabs

unread,
Apr 23, 2019, 3:47:41 PM4/23/19
to sucks-users
Whoops, that subject line was bad!

William Pietri

unread,
Apr 23, 2019, 7:25:49 PM4/23/19
to sucks-users
If you say it works, then that seems fine by me. I'll be traveling for a couple of weeks, so unless anybody objects I'll approve it shortly, bump the version number, and release a new version.

William
--
You received this message because you are subscribed to the Google Groups "sucks-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sucks-users...@googlegroups.com.
To post to this group, send email to sucks...@googlegroups.com.
Visit this group at https://groups.google.com/group/sucks-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/sucks-users/13d0e596-61c6-4808-927c-67e851227938%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

William Pietri

unread,
Apr 23, 2019, 9:39:01 PM4/23/19
to sucks-users
On 4/23/19 4:25 PM, William Pietri wrote:
If you say it works, then that seems fine by me. I'll be traveling for a couple of weeks, so unless anybody objects I'll approve it shortly, bump the version number, and release a new version.


Done! Thanks for the hard work on this. I know this has been a pain for a lot of people.

William
Reply all
Reply to author
Forward
0 new messages