SQUID S2095 improvement

[Charles Morin]

Hi,

Sonar rule #S2095 always expects a .close() call in the finally block. However, Java already has that overhead in place since Java 7+.

As per the ResultSet Javadoc:

A ResultSet object is automatically closed when the Statement object that generated it is closed, re-executed, or used to retrieve the next result from a sequence of multiple results.

Could it be possible to make the rule a little bit smarter so that overhead is taken into consideration?

API Docs :

http://docs.oracle.com/javase/7/docs/api/java/sql/ResultSet.html

Thank you

Charles

[Tibor Blenessy]

Hello,

indeed that could be an useful extension of the rule. Can you please provide short code sample demonstrating the problem? Thanks.

Best regards

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/c7a5d306-78f1-4969-b3eb-002adda2f535%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Tibor BLENESSY | SonarSource

Software Engineer

http://sonarsource.com

[Charles Morin]

Of course!

try (Connection connection = CommonTools.connectToDatasource();

     PreparedStatement statement = connection.prepareStatement("SELECT * FROM myschema.myfunction(?, ?, ?)");) {

    statement.setInt(1, siteId);

    statement.setDate(2, scheduleDate);

    statement.setInt(3, 4

    ResultSet resultSet = statement.executeQuery();

    while (resultSet.next()) {

       ...

    }

    ...

    resultSet.close();

} catch (Exception e) {

   ...
}

[Tibor Blenessy]

Thank you for example, I created following JIRA ticket to handle the issue

https://jira.sonarsource.com/browse/SONARJAVA-2060

Best regards

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/047634ff-0a21-44c7-8dd7-eafbb4798078%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.