[JAVA] S2386 Mutable fields should not be "public static" - False Positive - singleton collection created by java.util.Collections are unmodifiable

[Adam Gabryś]

Hello,

The S2386 rule doesn't know that singleton collections created by java.util.Collections are unmodifiable:

Environment:

• SonarQube 5.6.7
• SonarJava 4.15.0.12310 (I checked the PublicStaticMutableMembersCheck class and the problem should occur also in the latest version) 

Example class:

https://github.com/agabrys/sonarqube-falsepositives/blob/master/src/main/java/biz/gabrys/agabrys/sonarqube/falsepositives/d20180305/S2386.java

Project:

https://github.com/agabrys/sonarqube-falsepositives

Build:

mvn clean package sonar

Regards

Adam Gabryś

[Michael Gumowski]

Hey Adam,

Thanks for the feedback and reproducer.

These are indeed 3 nice FPs, which are going to be handled by the following ticket: SONARJAVA-2660

Cheers,

Michael

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/DB6PR0801MB1287EF490B7ACECE1FA041A198DA0%40DB6PR0801MB1287.eurprd08.prod.outlook.com.
For more options, visit https://groups.google.com/d/optout.

--

Michael Gumowski | SonarSource

Software Developer, Language Team
https://www.sonarsource.com