Support for "legacy" firefox driver

[David Burns]

Hi All,

We, Mozilla, have been scratching our heads at an issue where there is a lot of verbose logging and we have tracked it down to extension logging pref in webdriver.json being set as true.

Now, to solve this I can either drop the pref as default in that file or... let me delete FirefoxDriver because ESR is the only reason to keep it and I believe only by luck we support those versions. Let's see about dropping it and moving it to leg-e(nd)sry branch.(Puns are not my forte)

David

David Burns
Email: david.burns@theautomatedtester.co.uk
URL: http://www.theautomatedtester.co.uk/

[Simon Stewart]

Hi,

A quick glance at the source, and a read of your email, suggests that the only reason you'd see the logging is if people were using the extension. The Right Thing to do is not to install the old extension if we're using geckodriver. I _think_ the Java bindings do this now, but I'd need to check properly. Obviously, blindly installing the legacy extension is less than efficient :)

Although the official line for Firefox support is N, N-1, ESR, ESR-1, I really do think we need to make an exception for the legacy firefox driver. There are already enough people who haven't upgraded their selenium versions because they believe that doing so would prevent them from using the old driver. Having said that, I also think that when we ship 4.0, that support should be in a legacy jar of some kind, and I'm okay with that only being available through the selenium server. (That is, we hurt our users by deleting the old driver. I'm not a fan of doing that)

Even if we do move it to a separate jar, the code will still be in master. Let's figure out where this setting is being injected, and then tweak that if we detect we're using geckodriver.

Simon

On Mon, Aug 13, 2018 at 8:55 PM David Burns <david...@theautomatedtester.co.uk> wrote:

Hi All,

We, Mozilla, have been scratching our heads at an issue where there is a lot of verbose logging and we have tracked it down to extension logging pref in webdriver.json being set as true.

Now, to solve this I can either drop the pref as default in that file or... let me delete FirefoxDriver because ESR is the only reason to keep it and I believe only by luck we support those versions. Let's see about dropping it and moving it to leg-e(nd)sry branch.(Puns are not my forte)

David

David Burns
Email: david...@theautomatedtester.co.uk
URL: http://www.theautomatedtester.co.uk/

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAPmg_cvqkDwq9jAbT4fkvRwJcw6tfCk6Ebt1J9it64zegbRpvA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Alexei Barantsev]

We can safely unfreeze this preference, or ever delete it from webdriver.json, it will not hurt legacy driver.

Regards,

-- 

Alexei Barantsev

Software-Testing.Ru

Selenium2.Ru