Sorry for the slow reply -- yeah, that seems to work for me as well. Go
ahead and clean up the history. Do you think the console messages are
something that needs addressing? Unless we think it's likely to cause
problems, my instinct is to leave it.
-Ian
Quoting Dan Krol (2023-03-13 16:51:54)
> I pushed my changes to sandstormports/etherpad-lite-sandstorm on branch
> `update-1.8.18-dan` since orblivion/etherpad-lite-sandstorm points to
> sandstormports/etherpad-lite-sandstorm. I made this new branch because
> I didn't want to overwrite your work, particularly because I rebased
> `main` to get the `make` dependency in there.
> The only things I know about that remain:
> * Those "hook function" related browser console messages.
> * I did not edit the etherpad-lite patches, I made a new one. This was
> in the interest of getting this to you sooner. I figured maybe we'd
> have more to do and I didn't want to take the time to clean it up
> twice.
> Other than that, maybe I'm done? Again in the interest of time I didn't
> really test it (other than the name and avatar since I touched that
> part).
> 5 hours total so far.
>
> On Mon, Mar 13, 2023 at 3:44�PM Dan Krol <[1]
orbl...@gmail.com>
> wrote:
>
> I take it back - the subsequent errors did not happen to be silent.
> They were also due to our patch. If I comment out some of our patch, I
> can get the pad to show up.
> The stuff I comment out is related to setting the author name. It seems
> Etherpad may have changed how that's handled slightly; hopefully I can
> get around it. I'll figure it out and put it in a decent state and push
> it to github.
> Also, lots of browser console error messages, "The hook function
> neither called the callback nor returned a non-undefined value. This is
> prohibited because it will result in freezes when a future version of
> Etherpad updates the hook to support asynchronous behavior.", which
> sounds more like a deprecation warning. It might not even be a
> regression.
>
> On Mon, Mar 13, 2023 at 3:06�PM Dan Krol <[2]
orbl...@gmail.com>
> wrote:
>
> Okay quick update - I got past that particular hurdle but it's not
> showing up yet.
> The next step was pretty simple. The websocket message actually was
> received by the server, I just didn't debug early enough up the chain.
> The bug was in the socket.on('message' handler; upstream renamed the
> variable from "client" to "socket", and we had a patch in that function
> that used the old variable name.
> What's particularly troubling about this is that I didn't get any error
> message about this. Whatever the next error is, I'll probably have to
> keep poking around for it. Furthermore, we could very well have more
> silent errors that we won't find out about right away.
> 1) Is there some sort of obvious setting I could be checking to show
> errors? I'm not great with Node. I wouldn't think logging level would
> be it, since errors would be pretty high priority. I'm gonna look to
> see if there's some etherpad level setting.
> 2) Would it be worth the time to audit all of our patches to make sure
> other variable names didn't change? (though if I get stuck I might
> resort to this anyway)
>
> On Mon, Mar 13, 2023 at 12:53�PM Dan Krol <[3]
orbl...@gmail.com>
> wrote:
>
> I don't know if pairing would help just yet; I *just* got to this
> point. Maybe if I get stuck here.
> I briefly looked at the network tab and I think I found one websocket
> connection but I didn't understand what it meant. I didn't see a
> payload. I'll look again and if I can't figure it out, maybe this is
> where I could use your help.
>
> On Sun, Mar 12, 2023 at 9:16�PM Ian Denhardt <[4]
i...@zenhack.net>
> wrote:
>
> Anything interesting in the network tab?
> I'd be open to pairing on this at some point, if you think that
> would be
> helpful.
> -Ian
> Quoting Dan Krol (2023-03-12 21:03:03)
> >� � Okay, 4 hours in total now.
> >� � I got as far as sendClientReady getting called and completing
> on the
> >� � client side, but no message seems to be received on the
> server side. Or
> >� � so it seems at first glance, but I'm at the stopping point.
> If I
> >� � continue, I'll dig into it.
> >
> >� � On Sun, Mar 12, 2023 at 4:00�PM Dan Krol
> <[1][5]
orbl...@gmail.com>
> >� � wrote:
> >
> >� � I still have an hour to put in today but I want to say - I
> tried not
> >� � running the plugins at all, and I got the same error in
> etherpad per
> >� � se. So I just explicitly installed `async-stacktrace`, and
> that error
> >� � went away. I don't don't see any more error messages. But
> it's still
> >� � stuck on "Loading...".
> >� � This position is a bit harder now because I'm getting no
> feedback, I
> >� � have no idea where it's stuck. The control flow isn't that
> obvious. So
> >� � I'm console.log debugging.
> >
> >� � On Fri, Mar 10, 2023 at 3:37�PM Ian Denhardt
> <[2][6]
i...@zenhack.net>
> >� � wrote:
> >
> >� � � Go for it.
> >� � � Quoting Dan Krol (2023-03-10 15:13:38)
> >� � � >�� �� Sure. So should I go on for my next two
> hours?
> >� � � >
> >� � � >�� �� On Fri, Mar 10, 2023 at 2:31�PM Ian
> Denhardt
> >� � � <[1][3][7]
i...@zenhack.net>
> >� � � >�� �� wrote:
> >� � � >
> >� � � >�� �� �� Quoting Dan Krol (2023-03-10 13:35:08)
> >� � � >�� �� �� >��� ��� I think the error is
> more likely in the
> >� � � backend log; I see
> >� � � >�� �� �� lots of
> >� � � >�� �� �� >��� ��� `Error: Cannot find
> module
> >� � � 'async-stacktrace'`. Do you see
> >� � � >�� �� �� that?
> >� � � >�� �� �� Yeah, I'm seeing that as well. Looks
> like it's related to
> >� � � >�� �� �� ep_comments_page?
> >� � � >�� �� �� ...maybe worth seeing if updating the
> plugins helps?
> >� � � >
> >� � � > Verweise
> >� � � >
> >� � � >�� �� 1. mailto:[4][8]
i...@zenhack.net
> >
> >� � --
> >� � You received this message because you are subscribed to the
> Google
> >� � Groups "Sandstorm Development" group.
> >� � To unsubscribe from this group and stop receiving emails from
> it, send
> >� � an email to [5][9]
sandstorm-de...@googlegroups.com.
> >� � To view this discussion on the web visit
> >� �
> [6][10]
https://groups.google.com/d/msgid/sandstorm-dev/CAAWRcS_wvN0e
> JK1EGkk
> >� � 76WQCUoZZorCT7esbRZfehTBbfLLCew%[11]
40mail.gmail.com.
> >
> > Verweise
> >
> >� � 1. mailto:[12]
orbl...@gmail.com
> >� � 2. mailto:[13]
i...@zenhack.net
> >� � 3. mailto:[14]
i...@zenhack.net
> >� � 4. mailto:[15]
i...@zenhack.net
> >� � 5. mailto:[16]
sandstorm-de...@googlegroups.com
> >� � 6.
> [17]
https://groups.google.com/d/msgid/sandstorm-dev/CAAWRcS_wvN0eJK1
> EGkk76WQCUoZZorCT7esbRZfehTBbfLLCew%
40mail.gmail.com?utm_medium=emai
> l&utm_source=footer
>
> Verweise
>
> 1. mailto:
orbl...@gmail.com
> 2. mailto:
orbl...@gmail.com
> 3. mailto:
orbl...@gmail.com
> 4. mailto:
i...@zenhack.net
> 5. mailto:
orbl...@gmail.com
> 6. mailto:
i...@zenhack.net
> 7. mailto:
i...@zenhack.net
> 8. mailto:
i...@zenhack.net
> 9. mailto:
sandstorm-dev%2Bunsu...@googlegroups.com
> 10.
https://groups.google.com/d/msgid/sandstorm-dev/CAAWRcS_wvN0eJK1EGkk
> 11.
http://40mail.gmail.com/
> 12. mailto:
orbl...@gmail.com
> 13. mailto:
i...@zenhack.net
> 14. mailto:
i...@zenhack.net
> 15. mailto:
i...@zenhack.net
> 16. mailto:
sandstorm-dev%2Bunsu...@googlegroups.com
> 17.
https://groups.google.com/d/msgid/sandstorm-dev/CAAWRcS_wvN0eJK1EGkk76WQCUoZZorCT7esbRZfehTBbfLLCew%40mail.gmail.com?utm_medium=email&utm_source=footer