New trac status badges

57 views
Skip to first unread message

Tobias Diez

unread,
Feb 13, 2022, 4:26:06 PM2/13/22
to sage-devel
Hi everyone,

as you probably have already seen, there are a few new status badges in the trac ticket display.
We have now:
1. Linter that checks that the code of the current branch adheres to the style guidelines. In order to see details when it fails, you can click on it and then select the most recent workflow run. (This already exists for a while)
2. Buid & test that builds sage for the current branch (incrementally on top of the system packages of the develop branch) and runs the test. Details are again available by clicking on the badge. (This is currently still gray until https://trac.sagemath.org/ticket/33263 is merged into master)
3. Build documentation workflow that builds the documentation for the current branch. If you click on it, you get the html output of the successful run. The idea is to use this to easily inspect changes to the documentation without the need to locally rebuild the docs yourself. If the doc build fails, you can go to https://github.com/sagemath/sagetrac-mirror/actions/workflows/doc-build.yml and choose the particular branch to see what went wrong.
4. Open in gitpod. This will spin up a pre-configured dev environment in the browser (based on VS code), where the branch is already checked-out and everything is pre-build. Feel free to use it to quickly check that the changes in the ticket work as expected or to even make further changes yourself. To find out more: https://www.gitpod.io/

The idea is that these three status badges complement the existing patchbots (and maybe even replace them in the future). In particular, they are supposed to always be green. Please keep this in mind when reviewing a ticket.

Matthias Koeppe

unread,
Feb 13, 2022, 7:15:13 PM2/13/22
to sage-devel
Thanks a lot for this work, Tobias! Glad to see that it is merged now.

I have added a bit based on your posting to https://wiki.sagemath.org/ReleaseTours/sage-9.6

Dima Pasechnik

unread,
Feb 14, 2022, 5:01:29 AM2/14/22
to sage-devel
Hi,
I'm testing this on a ticket, and noticed that the Ubuntu host it runs
on has Linuxbrew installed.

gitpod /workspace/sagetrac-mirror (public/build/github_build) $ which brew
/home/linuxbrew/.linuxbrew/bin/brew
As a result, ./configure thinks it's a Homebrew macOS system...
(This is e.g. trac 32753 - not worked on yet)

Perhaps, if possible, not having Linuxbrew on the host might be a good
idea, for the time being.

Dima
> --
> You received this message because you are subscribed to the Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/fa011350-6b93-40e2-948d-a88bce053c35n%40googlegroups.com.

Tobias Diez

unread,
Feb 14, 2022, 7:18:58 AM2/14/22
to sage-devel
I agree that linuxbrew might not be most optimal choice for sage. It is currently installed by gitpod automatically in their full-image that we use. But they are also in the process to restructure their images at https://github.com/gitpod-io/workspace-images/tree/master. For example, the new workspace-python package seems promising https://hub.docker.com/r/gitpod/workspace-python/tags. Maybe wait a bit until their tooling is stabilized and then reevaluate what we use as the base image? Or do you experience any issues with linuxbrew (except for the misleading configure message)?

Matthias Koeppe

unread,
Feb 14, 2022, 11:46:51 AM2/14/22
to sage-devel
Ticket for gitpod usability improvements: https://trac.sagemath.org/ticket/33113
Reply all
Reply to author
Forward
0 new messages