looking for reviewers

68 views
Skip to first unread message

Travis Scholl

unread,
Jun 29, 2020, 7:24:21 PM6/29/20
to sage-devel
Hello,

I was hoping someone could review the following two tickets:



Is there a standard way to request reviewers besides marking a ticket as "needs_review"?

Travis

Michael Orlitzky

unread,
Jun 29, 2020, 9:49:23 PM6/29/20
to sage-...@googlegroups.com
You can CC people that you think might be interested; otherwise, begging
on the mailing list is fairly popular.

For what it's worth, these tickets look easy to review.

Since I looked at the commits, here's my drive-by suggestion: the
different() examples could use some explanatory text between them. For
example, knowing nothing about them, this one

sage: K.<c> = NumberField(x^2+1)
sage: K.different() == K.ideal(c.different())
True

looks to me like it's demonstrating something important but I've no idea
what.

John Cremona

unread,
Jun 30, 2020, 3:39:18 AM6/30/20
to sage-devel
For number theory tickets like these I suggest posting on sage-nt.  I'll look at both tickets now anyway.

John 
Reply all
Reply to author
Forward
0 new messages