libnauty: args inversed in spkg-configure.m4

32 views
Skip to first unread message

Thierry Thomas

unread,
Oct 3, 2020, 11:57:36 AM10/3/20
to sage-devel
Hello,

I´m working on Sage-9.2.beta14, and I noticed that 2 args are switched
in AC_SEARCH_LIBS: densenauty is the function and nauty is the library:

--- build/pkgs/libnauty/spkg-configure.m4.orig 2020-10-02 15:26:33 UTC
+++ build/pkgs/libnauty/spkg-configure.m4
@@ -2,6 +2,6 @@ SAGE_SPKG_CONFIGURE([libnauty], [
SAGE_SPKG_DEPCHECK([nauty], [
dnl The library is actually installed by the nauty spkg.
AC_CHECK_HEADER([nauty/nauty.h], [], [sage_spkg_install_libnauty=yes])
- AC_SEARCH_LIBS([nauty], [densenauty], [], [sage_spkg_install_libnauty=yes])
+ AC_SEARCH_LIBS([densenauty], [nauty], [], [sage_spkg_install_libnauty=yes])
])
])

Best regards.
--
Th. Thomas.

Dima Pasechnik

unread,
Oct 3, 2020, 12:10:28 PM10/3/20
to sage-devel, Matthias Koeppe
Good catch.
Matthias, this seems to be your code there.
Dima

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/20201003155728.GA87337%40graf.pompo.net.

Matthias Koeppe

unread,
Oct 3, 2020, 12:55:59 PM10/3/20
to sage-devel
Thanks for catching this. I have created https://trac.sagemath.org/ticket/30703 for this. Could you push your fix to the ticket please?
Reply all
Reply to author
Forward
0 new messages