Deprecation warnings

[John Cremona]

Deprecation warnings have a parameter which is interpreted as a trac ticket number, and output a second line after the warning text, of the form

See https://trac.sagemath.org/12345 for details.

Is the solution simply to replace the template for that output with a suitable GitHub issue number (or PR number if there was no issue created)?

John

[John Cremona]

PS ... and then every doctest which has this output needs to be changed...

 

John

[Dima Pasechnik]

this has been taken care of in PR 35015

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAD0p0K4zDvvJ_xqP8cj--HEKkPuuLnnOnOJ5LVwqFKV0xKWWyQ%40mail.gmail.com.

[John Cremona]

On Thu, 16 Feb 2023, 16:59 Dima Pasechnik, <dim...@gmail.com> wrote:

this has been taken care of in PR 35015

Thanks, I should have guessed that this had already been dealt with.

There are a lot of PRs with positive review (maybe there always were).  Has the release manager's job become harder?  I assume that after every merge of a PR which passes all tests,  they have to wait for all the other PRs to be retested.

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq220OXCdkujr6XLXi9TMsEOH9Veq-UjMkwZ2yG1Zxfj5g%40mail.gmail.com.

[Dima Pasechnik]

On Thu, 16 Feb 2023, 17:33 John Cremona, <john.c...@gmail.com> wrote:

On Thu, 16 Feb 2023, 16:59 Dima Pasechnik, <dim...@gmail.com> wrote:

this has been taken care of in PR 35015

Thanks, I should have guessed that this had already been dealt with.

There are a lot of PRs with positive review (maybe there always were).  Has the release manager's job become harder? 

no, I don't think anything substantially changed

here, compared to the old setup.

I assume that after every merge of a PR which passes all tests,  they have to wait for all the other PRs to be retested.

no,  I guess Volker merges a bunch of PRs, tests the result, if all good, keeps going, else, unmerges the culprit, sets it aside, tries other ready PRs, etc

On Thu, 16 Feb 2023, 15:54 John Cremona, <john.c...@gmail.com> wrote:

On Thu, 16 Feb 2023 at 15:53, John Cremona <john.c...@gmail.com> wrote:

Deprecation warnings have a parameter which is interpreted as a trac ticket number, and output a second line after the warning text, of the form

See https://trac.sagemath.org/12345 for details.

Is the solution simply to replace the template for that output with a suitable GitHub issue number (or PR number if there was no issue created)?

PS ... and then every doctest which has this output needs to be changed...

 

John

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAD0p0K4zDvvJ_xqP8cj--HEKkPuuLnnOnOJ5LVwqFKV0xKWWyQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq220OXCdkujr6XLXi9TMsEOH9Veq-UjMkwZ2yG1Zxfj5g%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAD0p0K4pZB8z3RKOZ%2BuFmsqAG4HgSoqfvZcKPqB6fZhV_fexGg%40mail.gmail.com.