How do you close a trac ticket?

55 views
Skip to first unread message

Isuru Fernando

unread,
Jul 8, 2019, 7:33:30 PM7/8/19
to sage-devel
If there's another ticket for the same issue, how do you close the duplicate one?

Isuru

Vincent Delecroix

unread,
Jul 9, 2019, 2:25:19 AM7/9/19
to sage-...@googlegroups.com
The usual procedure is to set the milestone to "won't fix/duplicate" and
then "needs review".

I also closed ticket #25348.

Vincent

Simon King

unread,
Jul 9, 2019, 3:46:23 PM7/9/19
to sage-...@googlegroups.com
Hi Isuru,

On 2019-07-09, Vincent Delecroix <20100.d...@gmail.com> wrote:
> The usual procedure is to set the milestone to "won't fix/duplicate" and
> then "needs review".

To elaborate a bit more (because in the past at some point I had the
same problem):

A ticket can only be *closed* by someone with particular privileges on
trac, such as the release manager. Other users can only *suggest* a
particular resolution of a ticket.

Therefore the milestone should be set as Vincent said. But in addition
to that, the ticket shouldn't just be set to "needs review", but someone
(perhaps you) should indicate in a comment why this ticket is a
duplicate ("This is a duplicate of #11111."), should insert his/her name
into the "Reviewer" field, and change the ticket to "positive review".

If I understand correctly, the release manager will look at the tickets
with positive review and take action on them (either merging them or
closing them or pointing out problems that the reviewer didn't notice,
etc.)

Best regards,
Simon

Reply all
Reply to author
Forward
0 new messages