Adding labels to github issues

120 views
Skip to first unread message

David Roe

unread,
Feb 8, 2023, 7:51:40 AM2/8/23
to sage-devel
Yesterday I manually added a bunch of people that I recognized to the sagemath organization triage team on github, which gives people the ability to edit labels.  I don't intend to exclude any active Sage developers, so if you want to be able to change labels and didn't get added, please let me know and I'll add you!
David

brettpim

unread,
Mar 2, 2023, 12:23:04 PM3/2/23
to sage-devel
David,

Do we have to be a member of the triage team to add labels to a PR we create?  Aaron Dwyer and I have just finished an initial implementation of covering arrays for sagemath and posted it as a PR ready for review.  The Provisional workflow on GitHub suggest attaching labels to the PR which we cannot figure out how to do.

regards
brett stevens

David Roe

unread,
Mar 4, 2023, 2:44:33 AM3/4/23
to sage-...@googlegroups.com
Hi Brett,
Yes, you do need to be part of the Triage team to add labels (this is a function of how permissions on github work).  There's currently a PR on the trac-to-github repository aiming to add a bot to our github workflow in an attempt to improve the situation.  If you have ideas, you're welcome to contribute to the discussion there.

I looked for the PR you're referring to in the list of Sage PRs and wasn't sure what you were referring to.  If you can send a link I (or someone else) can add the Needs Review tag manually (if it hasn't yet been done).
David

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/29978d83-02f0-4657-85c3-329f1b201716n%40googlegroups.com.

Emmanuel Charpentier

unread,
Mar 5, 2023, 8:50:16 AM3/5/23
to sage-devel
Dear David,

Le mercredi 8 février 2023 à 13:51:40 UTC+1, David Roe a écrit :
Yesterday I manually added a bunch of people that I recognized to the sagemath organization triage team on github,

This currently is 404 (page not found)...

Dima Pasechnik

unread,
Mar 5, 2023, 8:52:50 AM3/5/23
to sage-devel


On Sun, 5 Mar 2023, 13:50 Emmanuel Charpentier, <emanuel.c...@gmail.com> wrote:
Dear David,

Le mercredi 8 février 2023 à 13:51:40 UTC+1, David Roe a écrit :
Yesterday I manually added a bunch of people that I recognized to the sagemath organization triage team on github,

This currently is 404 (page not found)...

perhaps only visible to logged in github users
I see it fine after I log in
 
which gives people the ability to edit labels.  I don't intend to exclude any active Sage developers, so if you want to be able to change labels and didn't get added, please let me know and I'll add you!
David

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.

Emmanuel Charpentier

unread,
Mar 5, 2023, 5:00:31 PM3/5/23
to sage-devel
Le dimanche 5 mars 2023 à 14:52:50 UTC+1, Dima Pasechnik a écrit :


On Sun, 5 Mar 2023, 13:50 Emmanuel Charpentier, <emanuel.c...@gmail.com> wrote:
Dear David,

Le mercredi 8 février 2023 à 13:51:40 UTC+1, David Roe a écrit :
Yesterday I manually added a bunch of people that I recognized to the sagemath organization triage team on github,

This currently is 404 (page not found)...

perhaps only visible to logged in github users
I see it fine after I log in

I am logged in, as EmmanuelCharpentier, and I still get 404...
Reply all
Reply to author
Forward
0 new messages