We need 1237 more functions to get to 99% coverage.

[ph h]

~/sage-9.6/git/rc2$ sage.mod/sage --coverageall
__init__.py: 100.0% (1 of 1)
algebras/affine_nil_temperley_lieb.py: 100.0% (11 of 11)
algebras/algebra.py: 100.0% (1 of 1)
algebras/askey_wilson.py: 100.0% (21 of 21)
algebras/associated_graded.py: 100.0% (9 of 9)
algebras/cellular_basis.py: 100.0% (9 of 9)
algebras/clifford_algebra.py: 100.0% (64 of 64)
algebras/cluster_algebra.py: 100.0% (82 of 82)
algebras/commutative_dga.py: 100.0% (86 of 86)

...

...

...

typeset/character_art.py: 100.0% (20 of 20)
typeset/character_art_factory.py: 100.0% (12 of 12)
typeset/symbols.py: 100.0% (6 of 6)
typeset/unicode_art.py: 100.0% (3 of 3)

Overall weighted coverage score: 96.7%
Total number of functions: 53125
We need 1237 more functions to get to 99% coverage.

[davida...@gmail.com]

If you have a question you should ask it, because I don't think that simply posting the output of a command is useful here.

[ph h]

Hi,

Sorry about that. Honestly it is hard to formulate a question from this output. Let's try.

What are these 1237 functions, where would they come from and why 99% but not 100%.
Actually, this run was meant to test the Refactor&Source to see if anything is broken, without knowing what it does and what should the outcome be.

(She is still waiting for advice on how to test it)
Did  Refactor&Source break 'sage --coverageall' ?

Regards,

phiho

[Matthias Koeppe]

If you have made changes to the code and would like to discuss them, the procedure is to open a Trac ticket and to push the branch there.

https://doc.sagemath.org/html/en/faq/faq-contribute.html#i-want-to-contribute-code-to-sage-how-do-i-get-started

[ph h]

Hi,

> If you have made changes to the code and would like to discuss them, 

> the procedure is to open a Trac ticket and to push the branch there.

Thank you for the advice. The idea is still being explored. 

It will be shared when tests are encouraging.

Help in testing is much appreciated.

Regards,

phiho

--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/324c003d-9960-4fec-b5d7-f691935c4f46n%40googlegroups.com.

[John H Palmieri]

Why 99%? The code says

    for goal in [70, 75, 80, 85, 90, 95, 99]:
        if score < goal:

            ...

so whoever wrote it decided that 99% was a worthwhile goal to report, along with 70%, 75%, etc.

What are the functions? The output lists all of the files and their scores, so you can search for those without 100% coverage and examine them using `./sage --coverage FILE`. For example:

% ./sage --coverage src/sage/interfaces/octave.py
------------------------------------------------------------------------
SCORE src/sage/interfaces/octave.py: 96.8% (30 of 31)

Missing documentation:
     * line 317: def _keyboard_interrupt(self)

Possibly wrong (function name doesn't occur in doctests):
     * line 366: def _equality_symbol(self)
     * line 377: def _true_symbol(self)
     * line 386: def _false_symbol(self)

So the function `_keyboard_interrupt` in this file is not documented.

On Wednesday, April 27, 2022 at 7:35:54 AM UTC-7 hohoa...@gmail.com wrote:

[ph h]

Hi,

Thank you so much for such a clear explanation on all the 'what', 'why' and 'where'.

Regards,

phiho